Integrated: 8288948: Few J2DBench tests indicate lower primitive drawing performance with metal rendering pipeline

2022-07-17 Thread Ajit Ghaisas
On Wed, 22 Jun 2022 16:32:11 GMT, Ajit Ghaisas wrote: > J2DBench test option files attached to > [JDK-8288948](https://bugs.openjdk.org/browse/JDK-8288948) indicate lower > drawing performance on macOS with Metal rendering pipeline as compared to > OpenGL rendering pipeline. > > **Analysis :*

Re: RFR: 6391806: JLabel and AbstractButton's imageUpdate method should be better specified [v7]

2022-07-17 Thread Abhishek Kumar
> JLabel and AbstractButton's imageUpdate method description updated. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: JLabel and AbstractButton's imageUpdate method description updated - Changes: - all: https://git.o

Re: RFR: 6391806: JLabel and AbstractButton's imageUpdate method should be better specified [v6]

2022-07-17 Thread Abhishek Kumar
On Fri, 15 Jul 2022 22:11:48 GMT, Phil Race wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JLabel and AbstractButton imageUpdate method description modified > > src/java.desktop/share/classes/javax/swing/Abstrac

Re: RFR: 8290278: JavaDoc of index parameter of method JTabbedPane.insertTab

2022-07-17 Thread Tejesh R
On Thu, 14 Jul 2022 15:58:18 GMT, Tejesh R wrote: > JavaDoc of _JTabbedPane.inseetTab()_ is updated. The index position to insert > a new tab ranges from 0 to _TabCount_(Position after the last tab position), > the same is updated from _> 0_ to _>= 0_ . > @prrace has indicated that a [compatib

Re: RFR: 8285306: Fix typos in java.desktop [v6]

2022-07-17 Thread Phil Race
On Fri, 13 May 2022 16:53:00 GMT, Magnus Ihse Bursie wrote: >> I ran `codespell` on the `src/java.desktop` directory, and accepted those >> changes where it indeed discovered real typos. >> >> I ignored typos in public methods and variables. Maybe they can be fixed >> later on without much fan

Re: RFR: 8264999: GeneralPath.lineTo() to itself produces jagged lines [v4]

2022-07-17 Thread Phil Race
On Fri, 10 Jun 2022 01:24:48 GMT, Jeremy wrote: >> Previously when you drew a line that moved exactly (+0, +0) with a miter >> stroke the Stroker class acted like a horizontal miter was appropriate. Now >> we abort instead, so no miter is applied. >> >> The new unit test tests the original ste

Re: RFR: 8064787: [macosx] In Nimbus LaF, Ctrl+Alt mnemonic doesn't work

2022-07-17 Thread Phil Race
On Thu, 14 Jul 2022 08:03:34 GMT, Prasanta Sadhukhan wrote: > In SwingSet2 application, "File" menu has a visible mnemonic set on F. > > ![image](https://user-images.githubusercontent.com/43534309/178932400-ab70602a-9c4f-4cab-b3b7-0508b26d2ebe.png) > > Now, in MacOS, with Aqua, Java (Metal), a

Re: RFR: 8290278: JavaDoc of index parameter of method JTabbedPane.insertTab

2022-07-17 Thread Phil Race
On Thu, 14 Jul 2022 15:58:18 GMT, Tejesh R wrote: > JavaDoc of _JTabbedPane.inseetTab()_ is updated. The index position to insert > a new tab ranges from 0 to _TabCount_(Position after the last tab position), > the same is updated from _> 0_ to _>= 0_ . src/java.desktop/share/classes/javax/swi

Re: RFR: 8170794: [macosx] Error when using setDesktopManager on a JDesktopPane on MacOS X with Look and Feel Aqua

2022-07-17 Thread Phil Race
On Thu, 7 Jul 2022 11:11:27 GMT, Prasanta Sadhukhan wrote: > When we call JDesktopPane.setDesktopManager(new DefaultDesktopManager()) and > try to iconify an internalframe, it results in NPE > > Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException > at > javax.swing.RepaintMa

Re: RFR: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent [v2]

2022-07-17 Thread Phil Race
On Fri, 17 Jun 2022 03:30:31 GMT, Sergey Bylokhov wrote: >> Sergey Bylokhov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent [v2]

2022-07-17 Thread Phil Race
On Thu, 23 Jun 2022 06:12:37 GMT, Sergey Bylokhov wrote: >> The specification of the ICC_ColorSpace.fromCIEXYZ method >> [says](https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java#L428): >> >>> * This me