Re: RFR: 8286270: [java.desktop] Replace color search in XColors with a switch statement [v4]

2022-07-21 Thread SWinxy
On Sat, 16 Jul 2022 16:31:31 GMT, SWinxy wrote: >> The current implementation creates ~750 new objects on load, and uses a >> binary array search with a Comparable implementation. This implementation is >> probably bad. Instead, we can use the enhanced switch feature to possibly >> save time,

Re: RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v3]

2022-07-21 Thread Harshitha Onkar
On Thu, 21 Jul 2022 00:20:35 GMT, Harshitha Onkar wrote: >> More than that - this code needs to call setlocation, and do "whatever" to >> make sure that is actually pushed to the "window manager" and the REAL >> location of the window come back. The way the code is written it sets a >> couple

Re: RFR: 6445283: ProgressMonitorInputStream not large file aware (>2GB)

2022-07-21 Thread Alexander Zvegintsev
On Thu, 21 Jul 2022 10:47:38 GMT, Prasanta Sadhukhan wrote: > Fix is to check if adding bytes-to-read to number-bytes-already-read will > exceed MAX_INT, then set Progress to max so that ProgressMonitor can close > the tracker https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/c

RFR: 8281966: Absolute path of symlink is null in JFileChooser

2022-07-21 Thread Tejesh R
Absolute path of Symbolic Link created in Windows is set to `null` in `BasicFileChooserUI` class. This happens when propertyChangeListener is implemented to get the Symbolic link's Absolute path on Mouse click through JFileChooser. The reason being that on click of Symbolic link, the _ValueChan

Re: RFR: 8290399: [macos] Aqua LAF does not fire an action event if combo box menu is displayed

2022-07-21 Thread Alexander Zvegintsev
On Tue, 19 Jul 2022 08:13:23 GMT, Prasanta Sadhukhan wrote: > When the user types Enter in an editable combo box, Aqua LAF fails to fire an > action event if the menu is displayed. > It seems actionEvent is fired when popup menu is not visible. > Fix is to make sure ActionEvent is fired irresp

Re: RFR: 4797982: Setting negative size of JSplitPane divider leads to unexpected results.

2022-07-21 Thread Alexander Zvegintsev
On Wed, 20 Jul 2022 09:12:38 GMT, Prasanta Sadhukhan wrote: > Setting JSplitPane divider size to negative value leads to unexpected results > and is not desirable and seems to be not practical. > I guess we should return IAE but it might break existing app so fixed to > clamp it to 0 incase ne

Re: RFR: 8269806: Emoji rendering on Linux [v10]

2022-07-21 Thread Nikita Gubarkov
> It was implemented in JetBrains Runtime a year ago and was ported & > refactored for this PR > It includes: > - Bitmap glyph loading via Freetype > - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or > bilinear-mipmap style algorithms depending on the text antialiasing h

Re: RFR: 8269806: Emoji rendering on Linux [v9]

2022-07-21 Thread Nikita Gubarkov
> It was implemented in JetBrains Runtime a year ago and was ported & > refactored for this PR > It includes: > - Bitmap glyph loading via Freetype > - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or > bilinear-mipmap style algorithms depending on the text antialiasing h

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v11]

2022-07-21 Thread Abhishek Kumar
> JFileChooser - empty file size issue fixed. > For empty file, now the size 0 bytes. > Manual Test Case "ZeroFileSizeCheck.java" created. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: Deleted ZeroFileSizeCheck file and updated t

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v10]

2022-07-21 Thread Abhishek Kumar
On Thu, 21 Jul 2022 10:30:07 GMT, Abhishek Kumar wrote: >> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 bytes. >> Manual Test Case "ZeroFileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since

RFR: 6445283: ProgressMonitorInputStream not large file aware (>2GB)

2022-07-21 Thread Prasanta Sadhukhan
If ProgressMonitor has to show progress for reading file > 2GB, it goes to 100% and then again start from 0. This is because it uses "int" to store bytes read (`nread`) and when it reads data from file, it adds "number-bytes-to-read "nr" to number-bytes-already-read "nread" variable [`nread +=

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v10]

2022-07-21 Thread Abhishek Kumar
> JFileChooser - empty file size issue fixed. > For empty file, now the size 0 bytes. > Manual Test Case "ZeroFileSizeCheck.java" created. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: added os.family tag and updated summary tag

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v8]

2022-07-21 Thread Abhishek Kumar
On Thu, 21 Jul 2022 10:08:15 GMT, Abhishek Kumar wrote: >> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 bytes. >> Manual Test Case "ZeroFileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v9]

2022-07-21 Thread Abhishek Kumar
> JFileChooser - empty file size issue fixed. > For empty file, now the size 0 bytes. > Manual Test Case "ZeroFileSizeCheck.java" created. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: whitespace removed from FileSizeCheck file

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v8]

2022-07-21 Thread Abhishek Kumar
> JFileChooser - empty file size issue fixed. > For empty file, now the size 0 bytes. > Manual Test Case "ZeroFileSizeCheck.java" created. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: manual test case moved to directory and mult