On Fri, 29 Jul 2022 11:35:45 GMT, Prasanta Sadhukhan
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> bug id changed, added isVisible check
>
> src/java.desktop/share/classes/javax/swing/JTabbedPane.java line 16
> A simple change listener is used in JTabbedPane to lazily fill with
> components - this is done by adding the components to JTabbedPane using the
> `setComponentAt` in the change listener.
>
> Previously, if the change listener was placed before calling `addTab()` , the
> previous visible com
On Fri, 29 Jul 2022 22:01:44 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added screen insets to account for taskbar position, doc changes
>
> Well .. there surely must be test scenarios where
On Thu, 21 Jul 2022 00:27:04 GMT, Harshitha Onkar wrote:
>> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds
>> of test instruction frame are added to PassFailJFrame to handle positioning
>> of multiple test frames.
>>
>> In scenarios where multiple test windows migh
On Fri, 29 Jul 2022 21:10:39 GMT, Phil Race wrote:
> > Please let me know your suggestions on JSplitPane approach.
>
> I think it very unlikely a JSplitPane would satisfy all test requirements.
@prrace Do you mean - a multiple frame test scenario or any other scenario is
particular? We could r
On Fri, 29 Jul 2022 21:04:52 GMT, Harshitha Onkar wrote:
> Please let me know your suggestions on JSplitPane approach.
I think it very unlikely a JSplitPane would satisfy all test requirements.
-
PR: https://git.openjdk.org/jdk/pull/9525
On Fri, 29 Jul 2022 20:12:47 GMT, Phil Race wrote:
> I can confirm that on Linux / Gnome with menu bar at the top and
> toolbar on the left, that the requested location of 0,0 is not where
> the window is placed but if called immediately both getLocation()
@prrace Thank you for checking it on Li
On Fri, 29 Jul 2022 20:31:46 GMT, Alisen Chung wrote:
>> test/jdk/java/awt/image/multiresolution/MultiresolutionIconTest.java line
>> 131:
>>
>>> 129: private boolean checkPressedColor(int x, int y, Color ok) {
>>> 130:
>>> 131: r.mouseMove(x+5, y+5);
>>
>> What's the purpose of m
On Fri, 29 Jul 2022 18:18:03 GMT, Alisen Chung wrote:
>> Removed darkening of icons on button press in Aqua to match other L&Fs. The
>> icon darkening was causing this test to fail on MacOS.
>>
>> The test is passing on all platforms after this change.
>
> Alisen Chung has updated the pull requ
On Fri, 29 Jul 2022 20:29:17 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reverted changes to AquaButtonUI
>
> test/jdk/java/awt/image/multiresolution/MultiresolutionIconTest.java line 131:
>
On Fri, 29 Jul 2022 18:18:03 GMT, Alisen Chung wrote:
>> Removed darkening of icons on button press in Aqua to match other L&Fs. The
>> icon darkening was causing this test to fail on MacOS.
>>
>> The test is passing on all platforms after this change.
>
> Alisen Chung has updated the pull requ
On Thu, 21 Jul 2022 00:27:04 GMT, Harshitha Onkar wrote:
>> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds
>> of test instruction frame are added to PassFailJFrame to handle positioning
>> of multiple test frames.
>>
>> In scenarios where multiple test windows migh
On Fri, 29 Jul 2022 18:18:03 GMT, Alisen Chung wrote:
>> Removed darkening of icons on button press in Aqua to match other L&Fs. The
>> icon darkening was causing this test to fail on MacOS.
>>
>> The test is passing on all platforms after this change.
>
> Alisen Chung has updated the pull requ
On Fri, 29 Jul 2022 18:14:14 GMT, Alexey Ivanov wrote:
>> Absolute path of Symbolic Link created in Windows is set to `null` in
>> `BasicFileChooserUI` class. This happens when propertyChangeListener is
>> implemented to get the Symbolic link's Absolute path on Mouse click through
>> JFileChoo
On Thu, 21 Jul 2022 18:31:46 GMT, Tejesh R wrote:
> Absolute path of Symbolic Link created in Windows is set to `null` in
> `BasicFileChooserUI` class. This happens when propertyChangeListener is
> implemented to get the Symbolic link's Absolute path on Mouse click through
> JFileChooser. The
> Removed darkening of icons on button press in Aqua to match other L&Fs. The
> icon darkening was causing this test to fail on MacOS.
>
> The test is passing on all platforms after this change.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last re
On Fri, 29 Jul 2022 14:24:34 GMT, Tejesh R wrote:
>> `DebugGraphics` class has a Graphics instance which is been used in slowed
>> down drawing. The `graphics` object is not initialized anywhere inside the
>> class, where it is expected to set explicitly by the user. When the user
>> doesn't s
I'm not sure it would necessarily break things but it is churn (today
setVisible(boolean) actually calls show(boolean)! )
that doesn't help anything that I can see. We'd still have show() and
hide() .. so what would it solve ?
FWIW I never really liked that show() and hide() were deprecated.
Th
I am afraid that this change will instantly break >80% of all deployed
applications. Same for setSize()/resize().
-andy
From: client-libs-dev on behalf of SWinxy
Date: Thursday, 2022/07/28 at 23:25
To: client-libs-dev@openjdk.org
Subject: Migrating show/hide code to setVisible
The show()
> `DebugGraphics` class has a Graphics instance which is been used in slowed
> down drawing. The `graphics` object is not initialized anywhere inside the
> class, where it is expected to set explicitly by the user. When the user
> doesn't set it and try to use the any mehtods like `drawing/setFo
On Thu, 28 Jul 2022 21:38:56 GMT, Harshitha Onkar wrote:
> A simple change listener is used in JTabbedPane to lazily fill with
> components - this is done by adding the components to JTabbedPane using the
> `setComponentAt` in the change listener.
>
> Previously, if the change listener was pla
> If ProgressMonitor has to show progress for reading file > 2GB, it goes to
> 100% and then again start from 0.
> This is because
> it uses "int" to store bytes read (`nread`) and when it reads data from file,
> it adds
> "number-bytes-to-read "nr" to number-bytes-already-read "nread" variable
On Thu, 28 Jul 2022 20:41:38 GMT, Phil Race wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix
>
> src/java.desktop/share/classes/javax/swing/ProgressMonitorInputStream.java
> line 93:
>
>> 91: }
>
23 matches
Mail list logo
