Re: RFR: 6521141: DebugGraphics NPE @ setFont(); [v7]

2022-08-02 Thread Andrey Turbanov
On Tue, 2 Aug 2022 06:51:36 GMT, Tejesh R wrote: >> `DebugGraphics` class has a Graphics instance which is been used in slowed >> down drawing. The `graphics` object is not initialized anywhere inside the >> class, where it is expected to set explicitly by the user. When the user >> doesn't se

Re: RFR: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName

2022-08-02 Thread Alan Bateman
On Tue, 2 Aug 2022 20:30:17 GMT, Phil Race wrote: > My best guess is that it was added so that the tests deliberately provoked > using continuations to verify everything worked but that with the change > there's no point since it won't load any classes that use them .. ? That's right. These te

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v4]

2022-08-02 Thread Ao Qi
On Tue, 2 Aug 2022 17:25:19 GMT, Alan Bateman wrote: > Just an FYI that the [ORDER OF > TAGS](https://openjdk.org/jtreg/tag-spec.html#ORDER) section of the tag > language spec recommends putting the `@requires` before the `@modules` and > `@library` tags. Done. Didn't know that. Thank you for

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v5]

2022-08-02 Thread Ao Qi
> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and > `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java` > are added or modified by > [JDK-8284161](https://bugs.openjdk.org/browse/JDK-8284161), and they are > failed if Loom or JVMTI is

Re: RFR: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName

2022-08-02 Thread Phil Race
On Tue, 2 Aug 2022 06:52:38 GMT, Alan Bateman wrote: > One other comment on this is that the proposed change should mean that the > tests no longer need to run with --enable-preview. You've lost me all over again. Why did these two tests need that in the first place and why would they no longe

Re: RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v4]

2022-08-02 Thread Alexey Ivanov
On Thu, 21 Jul 2022 00:27:04 GMT, Harshitha Onkar wrote: >> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds >> of test instruction frame are added to PassFailJFrame to handle positioning >> of multiple test frames. >> >> In scenarios where multiple test windows migh

Re: RFR: 8064787: [macosx] In Nimbus LaF, Ctrl+Alt mnemonic doesn't work

2022-08-02 Thread Damon Nguyen
On Thu, 14 Jul 2022 08:03:34 GMT, Prasanta Sadhukhan wrote: > In SwingSet2 application, "File" menu has a visible mnemonic set on F. > > ![image](https://user-images.githubusercontent.com/43534309/178932400-ab70602a-9c4f-4cab-b3b7-0508b26d2ebe.png) > > Now, in MacOS, with Aqua, Java (Metal), a

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v4]

2022-08-02 Thread Leonid Mesnik
On Tue, 2 Aug 2022 06:32:09 GMT, Ao Qi wrote: >> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and >> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java` >> are added or modified by >> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v14]

2022-08-02 Thread Abhishek Kumar
On Mon, 1 Aug 2022 16:36:13 GMT, Andy Goryachev wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> creating and deleting test files dynamically > > looks good. @andy-goryachev-oracle Checked in Oracle Linux and it

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v13]

2022-08-02 Thread Abhishek Kumar
On Mon, 1 Aug 2022 16:35:44 GMT, Andy Goryachev wrote: > Looks like it matches on ubuntu. > > Do we care about other linuxes / desktop environments / file browsers? I checked in Oracle Linux and it is showing file size similar to native. - PR: https://git.openjdk.org/jdk/pull/9327

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v2]

2022-08-02 Thread Artem Semenov
On Fri, 15 Jul 2022 18:19:33 GMT, Phil Race wrote: >> @azuev-java @prrace please review this CSR ticket >> [JDK-8286674](https://bugs.openjdk.org/browse/JDK-8286674) > >> @azuev-java @prrace please review this CSR ticket >> [JDK-8286674](https://bugs.openjdk.org/browse/JDK-8286674) > > Before

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v4]

2022-08-02 Thread Alan Bateman
On Tue, 2 Aug 2022 06:32:09 GMT, Ao Qi wrote: >> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and >> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java` >> are added or modified by >> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-

Re: RFR: 4850101: Setting mnemonic to VK_F4 underlines the letter S in a button.

2022-08-02 Thread Dio Brando
On Tue, 2 Aug 2022 10:22:48 GMT, Prasanta Sadhukhan wrote: > It is seen that using VK_F4 in JButton's setMnemonic(int i), causes the > letter 'S' in the JButton to be underlined if JButton's text has 'S' in its > string. > This is because > [**VK_F4**](https://github.com/openjdk/jdk/blob/mast

RFR: 4850101: Setting mnemonic to VK_F4 underlines the letter S in a button.

2022-08-02 Thread Prasanta Sadhukhan
It is seen that using VK_F4 in JButton's setMnemonic(int i), causes the letter 'S' in the JButton to be underlined if JButton's text has 'S' in its string. This is because [**VK_F4**](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/event/KeyEvent.java#L506) key