Re: RFR: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName [v2]

2022-08-04 Thread Alan Bateman
On Fri, 5 Aug 2022 02:25:11 GMT, Ao Qi wrote: >> The issue comes from >> https://github.com/openjdk/jdk/pull/9677#issuecomment-1200811357. >> >> If Loom is not supported, two XMLDecoder tests would fail. The issue could >> be reproduced by zero, for example: >> >> >> ---

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v5]

2022-08-04 Thread Tejesh R
On Thu, 4 Aug 2022 18:53:30 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > Changes requested by aivanov (Reviewer). @aivanov-jdk Updated your review comments. L

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v6]

2022-08-04 Thread Tejesh R
> Absolute path of Symbolic Link created in Windows is set to `null` in > `BasicFileChooserUI` class. This happens when propertyChangeListener is > implemented to get the Symbolic link's Absolute path on Mouse click through > JFileChooser. The reason being that on click of Symbolic link, the >

Re: RFR: 6521141: DebugGraphics NPE @ setFont(); [v7]

2022-08-04 Thread Tejesh R
On Thu, 4 Aug 2022 20:25:13 GMT, Phil Race wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > test/jdk/javax/swing/DebugGraphics/DebugGraphicsNPETest.java line 30: > >> 28: /* @test >

Re: RFR: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName

2022-08-04 Thread Ao Qi
On Mon, 1 Aug 2022 16:23:59 GMT, Ao Qi wrote: > The issue comes from > https://github.com/openjdk/jdk/pull/9677#issuecomment-1200811357. > > If Loom is not supported, two XMLDecoder tests would fail. The issue could be > reproduced by zero, for example: > > > ---

Re: RFR: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName [v2]

2022-08-04 Thread Ao Qi
> The issue comes from > https://github.com/openjdk/jdk/pull/9677#issuecomment-1200811357. > > If Loom is not supported, two XMLDecoder tests would fail. The issue could be > reproduced by zero, for example: > > > -- > TEST: java/beans/XMLDecode

Re: RFR: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent [v3]

2022-08-04 Thread Sergey Bylokhov
> The specification of the ICC_ColorSpace.fromCIEXYZ method > [says](https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java#L428): > >> * This method transforms color values using relative colorimetry, as def

Re: RFR: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent [v2]

2022-08-04 Thread Sergey Bylokhov
On Sun, 17 Jul 2022 23:20:30 GMT, Phil Race wrote: >> Sergey Bylokhov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commit

Re: RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v4]

2022-08-04 Thread Harshitha Onkar
On Thu, 21 Jul 2022 00:27:04 GMT, Harshitha Onkar wrote: >> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds >> of test instruction frame are added to PassFailJFrame to handle positioning >> of multiple test frames. >> >> In scenarios where multiple test windows migh

Re: RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v5]

2022-08-04 Thread Harshitha Onkar
> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds > of test instruction frame are added to PassFailJFrame to handle positioning > of multiple test frames. > > In scenarios where multiple test windows might be present, the test windows > might overlap the instruction

Re: RFR: 8290973: In AffineTransform, equals(Object) is inconsistent with hashCode()

2022-08-04 Thread Phil Race
On Fri, 10 Jun 2022 09:39:48 GMT, Martin Desruisseaux wrote: > `AffineTransform.equals(Object)` and `hashCode()` break two contracts: > > * `A.equals(A)` returns `false` if at least one affine transform coefficient > is NaN. > * `A.equals(B)` should imply `A.hashCode() == B.hashCode()`, but it

Re: RFR: 8291266: RenderPerfTest: missing content while rendering some primitives

2022-08-04 Thread Alexey Ushakov
On Thu, 4 Aug 2022 21:07:02 GMT, Alexey Ushakov wrote: > Do not cause redundant endEncoder calls with batch processing of drawing > primitives Looks like the only way is to use Robot. The problem is not reproducible with VolatileImage. I'll try to come up with something reliable.

Re: RFR: 8291266: RenderPerfTest: missing content while rendering some primitives

2022-08-04 Thread Sergey Bylokhov
On Thu, 4 Aug 2022 21:07:02 GMT, Alexey Ushakov wrote: > Do not cause redundant endEncoder calls with batch processing of drawing > primitives Is it possible to integrate DrawTest.java as a test case? - PR: https://git.openjdk.org/jdk/pull/9756

RFR: 8291266: RenderPerfTest: missing content while rendering some primitives

2022-08-04 Thread Alexey Ushakov
Do not cause redundant endEncoder calls with batch processing of drawing primitives - Commit messages: - 8291266: RenderPerfTest: missing content while rendering some primitives Changes: https://git.openjdk.org/jdk/pull/9756/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9

Integrated: 8272998: ImageIO.read() throws incorrect exception type

2022-08-04 Thread Phil Race
On Thu, 9 Jun 2022 19:53:22 GMT, Phil Race wrote: > ImageIO.read() only documents IOException for any kind of decoding problem > and since > it is a convenience API we don't want to start requiring applications to > handle other RuntimeExceptions. > So in the unlikely case of some problem decod

Re: RFR: 4850101: Setting mnemonic to VK_F4 underlines the letter S in a button.

2022-08-04 Thread Phil Race
On Tue, 2 Aug 2022 10:22:48 GMT, Prasanta Sadhukhan wrote: > It is seen that using VK_F4 in JButton's setMnemonic(int i), causes the > letter 'S' in the JButton to be underlined if JButton's text has 'S' in its > string. > This is because > [**VK_F4**](https://github.com/openjdk/jdk/blob/mast

Re: RFR: 8267374: (macos) Option+Up/Down arrow dont traverse to beginning/end of line in textarea [v8]

2022-08-04 Thread Phil Race
On Thu, 28 Jul 2022 08:39:46 GMT, Prasanta Sadhukhan wrote: >> Unlike in native "Notes" editor where Option+Up/Down traverses to start/end >> of each line respectively, >> Java does not honour these key combination in editor. >> >> Added the key combination support by moving the caret to start

Integrated: 8169187: [macosx] Aqua: java/awt/image/multiresolution/MultiresolutionIconTest.java

2022-08-04 Thread Alisen Chung
On Fri, 8 Jul 2022 22:33:39 GMT, Alisen Chung wrote: > Removed darkening of icons on button press in Aqua to match other L&Fs. The > icon darkening was causing this test to fail on MacOS. > > The test is passing on all platforms after this change. This pull request has now been integrated. Ch

Re: RFR: 8289208: Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS [v2]

2022-08-04 Thread Phil Race
On Mon, 1 Aug 2022 14:30:54 GMT, Maxim Kartashev wrote: >> Java2D's `Disposer` maintains a record of objects to dispose of with the >> help of a collection that isn't thread safe. When `DisposerRecords` objects >> are being added to it at the same time as others are being disposed on the >> To

Re: RFR: 6521141: DebugGraphics NPE @ setFont(); [v7]

2022-08-04 Thread Phil Race
On Tue, 2 Aug 2022 06:51:36 GMT, Tejesh R wrote: >> `DebugGraphics` class has a Graphics instance which is been used in slowed >> down drawing. The `graphics` object is not initialized anywhere inside the >> class, where it is expected to set explicitly by the user. When the user >> doesn't se

Re: RFR: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName

2022-08-04 Thread Phil Race
On Mon, 1 Aug 2022 16:23:59 GMT, Ao Qi wrote: > The issue comes from > https://github.com/openjdk/jdk/pull/9677#issuecomment-1200811357. > > If Loom is not supported, two XMLDecoder tests would fail. The issue could be > reproduced by zero, for example: > > > ---

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v5]

2022-08-04 Thread Alexey Ivanov
On Thu, 4 Aug 2022 18:45:21 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v5]

2022-08-04 Thread Tejesh R
> Absolute path of Symbolic Link created in Windows is set to `null` in > `BasicFileChooserUI` class. This happens when propertyChangeListener is > implemented to get the Symbolic link's Absolute path on Mouse click through > JFileChooser. The reason being that on click of Symbolic link, the >

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v4]

2022-08-04 Thread Tejesh R
On Thu, 4 Aug 2022 15:32:17 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix for multi selection and updated the test to handle both single and >> multi selection > > It works fine now. Thank you

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v4]

2022-08-04 Thread Alexey Ivanov
On Thu, 4 Aug 2022 12:08:15 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v2]

2022-08-04 Thread Alexey Ivanov
On Wed, 3 Aug 2022 15:50:37 GMT, Tejesh R wrote: > In the single-selection case, I see the following output: > > ``` > Absolute Path : null > Absolute Path : C:\filechooser\link > ``` Sorry about that. Upon re-testing, this scenario worked fine with your original changes. > For link it doesn'

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v4]

2022-08-04 Thread Tejesh R
> Absolute path of Symbolic Link created in Windows is set to `null` in > `BasicFileChooserUI` class. This happens when propertyChangeListener is > implemented to get the Symbolic link's Absolute path on Mouse click through > JFileChooser. The reason being that on click of Symbolic link, the >

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v3]

2022-08-04 Thread Tejesh R
On Wed, 3 Aug 2022 15:14:22 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Added Dialog information for printing Absolute path >> - Updated based on review comments > > Changes requested by aivan

Integrated: 4890041: Remove TAB and Shift TAB from Popup Menu in Motif Look & Feel

2022-08-04 Thread Prasanta Sadhukhan
On Fri, 22 Jul 2022 09:23:41 GMT, Prasanta Sadhukhan wrote: > This is a cleanup of unneeded TAB and Shift TAB keybindings for > PopupMenu.selectedWindowInputMapBindings which is consistent with other L&Fs > as can be seen here > > https://github.com/openjdk/jdk/blob/master/src/java.desktop/sh

Re: RFR: 8269806: Emoji rendering on Linux [v12]

2022-08-04 Thread Nikita Gubarkov
On Wed, 3 Aug 2022 09:51:22 GMT, Alexey Ushakov wrote: >> Nikita Gubarkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix rotated text metrics > > src/java.desktop/share/classes/sun/font/StandardGlyphVector.java line 1835: > >> 1833

Re: RFR: 8269806: Emoji rendering on Linux [v12]

2022-08-04 Thread Nikita Gubarkov
On Wed, 3 Aug 2022 09:48:58 GMT, Alexey Ushakov wrote: >> Nikita Gubarkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix rotated text metrics > > src/java.desktop/macosx/classes/sun/font/CCompositeGlyphMapper.java line 67: > >> 65: