On Fri, 5 Aug 2022 19:37:57 GMT, Harshitha Onkar wrote:
>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 297:
>>
>>> 295: .getDefaultScreenDevice().getDefaultConfiguration();
>>> 296: Insets screenInsets =
>>> Toolkit.getDefaultToolkit().getScreenInsets(gc);
> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds
> of test instruction frame are added to PassFailJFrame to handle positioning
> of multiple test frames.
>
> In scenarios where multiple test windows might be present, the test windows
> might overlap the instruction
On Fri, 5 Aug 2022 20:26:31 GMT, Phil Race wrote:
>> Is that possible? Toolkit thread is not EDT, therefore native events are
>> processed, it's probably enough to update the frame coordinates while EDT is
>> blocked and doesn't handle events.
>
> Can you expand on what you mean ?
> What's the
On Fri, 5 Aug 2022 18:01:26 GMT, Alexey Ushakov wrote:
>> Do not cause redundant endEncoder calls with batch processing of drawing
>> primitives
>
> Alexey Ushakov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8291266: RenderPerfTest: mi
On Fri, 5 Aug 2022 20:14:35 GMT, Alexey Ivanov wrote:
>> The intention is that it can be called either way - on or off.
>
> Is that possible? Toolkit thread is not EDT, therefore native events are
> processed, it's probably enough to update the frame coordinates while EDT is
> blocked and doesn
On Fri, 5 Aug 2022 20:10:48 GMT, Phil Race wrote:
>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 309:
>>
>>> 307: } catch (InterruptedException e) {
>>> 308: e.printStackTrace();
>>> 309: }
>>
>> Is it safe to call on EDT?
>>
>> If `positio
On Fri, 5 Aug 2022 19:18:21 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added null check in positionWindow
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 309:
>
>> 307:
On Fri, 5 Aug 2022 19:13:18 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added null check in positionWindow
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 297:
>
>> 295:
On Fri, 5 Aug 2022 17:42:03 GMT, Harshitha Onkar wrote:
>> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds
>> of test instruction frame are added to PassFailJFrame to handle positioning
>> of multiple test frames.
>>
>> In scenarios where multiple test windows might
On Thu, 28 Jul 2022 10:08:24 GMT, Abhishek Kumar wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since
On Thu, 28 Jul 2022 10:08:24 GMT, Abhishek Kumar wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since
On Fri, 5 Aug 2022 18:01:26 GMT, Alexey Ushakov wrote:
>> Do not cause redundant endEncoder calls with batch processing of drawing
>> primitives
>
> Alexey Ushakov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8291266: RenderPerfTest: mi
> Do not cause redundant endEncoder calls with batch processing of drawing
> primitives
Alexey Ushakov has updated the pull request incrementally with one additional
commit since the last revision:
8291266: RenderPerfTest: missing content while rendering some primitives
Added regression
On Fri, 5 Aug 2022 09:46:13 GMT, Julian Waters wrote:
> FileFontStrike#initNative calls memset with LCDLUTCOUNT (the maximum length)
> as the number of bytes to zero out, which is incorrect as the elements are
> not 1 byte in size (unsigned char*), and will result in only part of the IG
> Tabl
On Fri, 22 Jul 2022 20:31:44 GMT, Phil Race wrote:
>> Following is a proposed solution to push the latest position changes to the
>> window manager.
>>
>> The get and setLocation calls are wrapped in invokeLater().
>> Robot.waitForIdle() are added between setLocation() and the subsequent
>> g
On Fri, 5 Aug 2022 00:45:59 GMT, Harshitha Onkar wrote:
>> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds
>> of test instruction frame are added to PassFailJFrame to handle positioning
>> of multiple test frames.
>>
>> In scenarios where multiple test windows might
> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds
> of test instruction frame are added to PassFailJFrame to handle positioning
> of multiple test frames.
>
> In scenarios where multiple test windows might be present, the test windows
> might overlap the instruction
On Fri, 5 Aug 2022 08:58:51 GMT, Prasanta Sadhukhan
wrote:
> Issue is Arrow in submenu with empty title have a wrong position in Aqua L&F
> as can be seen
>
> src="https://user-images.githubusercontent.com/43534309/183023538-de8e51b4-31e6-45d7-b2bd-35da5e29c1e8.png";>
>
>
> which is because
On Fri, 5 Aug 2022 11:35:54 GMT, Tejesh R wrote:
>> `DebugGraphics` class has a Graphics instance which is been used in slowed
>> down drawing. The `graphics` object is not initialized anywhere inside the
>> class, where it is expected to set explicitly by the user. When the user
>> doesn't se
On Fri, 5 Aug 2022 02:25:11 GMT, Ao Qi wrote:
>> The issue comes from
>> https://github.com/openjdk/jdk/pull/9677#issuecomment-1200811357.
>>
>> If Loom is not supported, two XMLDecoder tests would fail. The issue could
>> be reproduced by zero, for example:
>>
>>
>> ---
On Fri, 5 Aug 2022 11:35:54 GMT, Tejesh R wrote:
>> `DebugGraphics` class has a Graphics instance which is been used in slowed
>> down drawing. The `graphics` object is not initialized anywhere inside the
>> class, where it is expected to set explicitly by the user. When the user
>> doesn't se
On Fri, 5 Aug 2022 08:58:51 GMT, Prasanta Sadhukhan
wrote:
> Issue is Arrow in submenu with empty title have a wrong position in Aqua L&F
> as can be seen
>
> src="https://user-images.githubusercontent.com/43534309/183023538-de8e51b4-31e6-45d7-b2bd-35da5e29c1e8.png";>
>
>
> which is because
On Fri, 10 Jun 2022 09:39:48 GMT, Martin Desruisseaux wrote:
> `AffineTransform.equals(Object)` and `hashCode()` break two contracts:
>
> * `A.equals(A)` returns `false` if at least one affine transform coefficient
> is NaN.
> * `A.equals(B)` should imply `A.hashCode() == B.hashCode()`, but it
On Fri, 5 Aug 2022 05:46:20 GMT, Tejesh R wrote:
>> Absolute path of Symbolic Link created in Windows is set to `null` in
>> `BasicFileChooserUI` class. This happens when propertyChangeListener is
>> implemented to get the Symbolic link's Absolute path on Mouse click through
>> JFileChooser. T
> It was implemented in JetBrains Runtime a year ago and was ported &
> refactored for this PR
> It includes:
> - Bitmap glyph loading via Freetype
> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or
> bilinear-mipmap style algorithms depending on the text antialiasing h
On Fri, 5 Aug 2022 05:46:20 GMT, Tejesh R wrote:
>> Absolute path of Symbolic Link created in Windows is set to `null` in
>> `BasicFileChooserUI` class. This happens when propertyChangeListener is
>> implemented to get the Symbolic link's Absolute path on Mouse click through
>> JFileChooser. T
On Fri, 5 Aug 2022 10:52:43 GMT, Prasanta Sadhukhan
wrote:
>> Tejesh R has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Updated based on review comments
>> - Updated based on review comments
>
> test/jdk/javax/swing/DebugGraphics/Debu
> `DebugGraphics` class has a Graphics instance which is been used in slowed
> down drawing. The `graphics` object is not initialized anywhere inside the
> class, where it is expected to set explicitly by the user. When the user
> doesn't set it and try to use the any mehtods like `drawing/setFo
On Fri, 5 Aug 2022 09:32:05 GMT, Tejesh R wrote:
>> `DebugGraphics` class has a Graphics instance which is been used in slowed
>> down drawing. The `graphics` object is not initialized anywhere inside the
>> class, where it is expected to set explicitly by the user. When the user
>> doesn't se
FileFontStrike#initNative calls memset with LCDLUTCOUNT (the maximum length) as
the number of bytes to zero out, which is incorrect as the elements are not 1
byte in size (unsigned char*), and will result in only part of the IG Table
being correctly zeroed. This is more correctly resolved by pas
On Thu, 4 Aug 2022 20:24:38 GMT, Phil Race wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> src/java.desktop/share/classes/javax/swing/DebugGraphics.java line 79:
>
>> 77: *
>
On Thu, 28 Jul 2022 18:11:02 GMT, Phil Race wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed whitespace error
>
> You wrote " The graphics object is not initialized anywhere inside the class,
> where it is expe
> `DebugGraphics` class has a Graphics instance which is been used in slowed
> down drawing. The `graphics` object is not initialized anywhere inside the
> class, where it is expected to set explicitly by the user. When the user
> doesn't set it and try to use the any mehtods like `drawing/setFo
Issue is Arrow in submenu with empty title have a wrong position in Aqua L&F as
can be seen
https://user-images.githubusercontent.com/43534309/183023538-de8e51b4-31e6-45d7-b2bd-35da5e29c1e8.png";>
which is because the text being null/empty, `labelR` rectangle width/height is
0 so arrowIcon y c
On Fri, 10 Jun 2022 09:39:48 GMT, Martin Desruisseaux wrote:
> `AffineTransform.equals(Object)` and `hashCode()` break two contracts:
>
> * `A.equals(A)` returns `false` if at least one affine transform coefficient
> is NaN.
> * `A.equals(B)` should imply `A.hashCode() == B.hashCode()`, but it
On Wed, 13 Jul 2022 08:58:38 GMT, Sergey Bylokhov wrote:
>>> The code that disposes on the rendering thread is invoked from a dispose()
>>> method
>> that was on the Disposer thread. It then waits for that to finish.
>> At that time the Disposer thread is blocked so not doing anything and the
>
On Wed, 3 Aug 2022 05:59:34 GMT, Alan Bateman wrote:
>>> One other comment on this is that the proposed change should mean that the
>>> tests no longer need to run with --enable-preview.
>>
>> You've lost me all over again.
>> Why did these two tests need that in the first place and why would t
37 matches
Mail list logo
