Integrated: 8292244: Remove unnecessary include directories

2022-08-11 Thread Daniel Jeliński
On Thu, 11 Aug 2022 09:56:29 GMT, Daniel Jeliński wrote: > Remove `java.base:include` from `EXTRA_HEADER_DIRS`. > > The directory contains base versions of the files present in > `/support/modules_include/java.base`; the latter is automatically > [included in every JDK library > build](https:

Re: RFR: 8290973: In AffineTransform, equals(Object) is inconsistent with hashCode()

2022-08-11 Thread Martin Desruisseaux
On Fri, 10 Jun 2022 09:39:48 GMT, Martin Desruisseaux wrote: > `AffineTransform.equals(Object)` and `hashCode()` break two contracts: > > * `A.equals(A)` returns `false` if at least one affine transform coefficient > is NaN. > * `A.equals(B)` should imply `A.hashCode() == B.hashCode()`, but it

Re: RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v7]

2022-08-11 Thread Harshitha Onkar
On Thu, 11 Aug 2022 20:36:48 GMT, Alexey Ivanov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> helper method added to sync location > > test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 313: > >> 311:

Re: RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v8]

2022-08-11 Thread Harshitha Onkar
> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds > of test instruction frame are added to PassFailJFrame to handle positioning > of multiple test frames. > > In scenarios where multiple test windows might be present, the test windows > might overlap the instruction

Re: RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v7]

2022-08-11 Thread Alexey Ivanov
On Fri, 5 Aug 2022 23:50:57 GMT, Harshitha Onkar wrote: >> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds >> of test instruction frame are added to PassFailJFrame to handle positioning >> of multiple test frames. >> >> In scenarios where multiple test windows might

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-11 Thread Alexey Ivanov
On Thu, 11 Aug 2022 19:30:18 GMT, Phil Race wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Smaller file sizes display one decimal precision > > src/java.desktop/share/classes/sun/swing/FilePane.java line 1209: >

Re: RFR: 8290973: In AffineTransform, equals(Object) is inconsistent with hashCode()

2022-08-11 Thread Phil Race
On Fri, 10 Jun 2022 09:39:48 GMT, Martin Desruisseaux wrote: > `AffineTransform.equals(Object)` and `hashCode()` break two contracts: > > * `A.equals(A)` returns `false` if at least one affine transform coefficient > is NaN. > * `A.equals(B)` should imply `A.hashCode() == B.hashCode()`, but it

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-11 Thread Alexey Ivanov
On Thu, 11 Aug 2022 10:02:56 GMT, Abhishek Kumar wrote: >> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 KB. >> Manual Test Case "FileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-11 Thread Phil Race
On Thu, 11 Aug 2022 10:02:56 GMT, Abhishek Kumar wrote: >> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 KB. >> Manual Test Case "FileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the las

Integrated: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName

2022-08-11 Thread Ao Qi
On Mon, 1 Aug 2022 16:23:59 GMT, Ao Qi wrote: > The issue comes from > https://github.com/openjdk/jdk/pull/9677#issuecomment-1200811357. > > If Loom is not supported, two XMLDecoder tests would fail. The issue could be > reproduced by zero, for example: > > > ---

Integrated: 8291959: FileFontStrike#initNative does not properly initialize IG Table on Windows

2022-08-11 Thread Julian Waters
On Fri, 5 Aug 2022 09:46:13 GMT, Julian Waters wrote: > FileFontStrike#initNative calls memset with LCDLUTCOUNT (the maximum length) > as the number of bytes to zero out, which is incorrect as the elements are > not 1 byte in size (unsigned char*), and will result in only part of the IG > Tabl

Re: RFR: 8286313 [macos] Voice over reads the boolean value as null in the JTable

2022-08-11 Thread Phil Race
On Mon, 25 Jul 2022 16:24:15 GMT, Artem Semenov wrote: > I have a Table which is extended from AbstractTableModel with String, integer > and Boolean values ( to represent checkbox). When the row is selected Voice > over reads the Boolean value as null. > > @azuev-java @mrserb @prrace please r

Re: RFR: 8289208: Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS [v2]

2022-08-11 Thread Phil Race
On Mon, 1 Aug 2022 14:30:54 GMT, Maxim Kartashev wrote: >> Java2D's `Disposer` maintains a record of objects to dispose of with the >> help of a collection that isn't thread safe. When `DisposerRecords` objects >> are being added to it at the same time as others are being disposed on the >> To

Re: RFR: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines [v3]

2022-08-11 Thread Phil Race
On Fri, 15 Jul 2022 20:58:41 GMT, Phil Race wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments fixed: Reverted variable name change, reverted +20 in point > > test/jdk/java/awt/PopupMenu/PopupMenuLoca

Re: RFR: 8291266: RenderPerfTest: missing content while rendering some primitives [v2]

2022-08-11 Thread Phil Race
On Fri, 5 Aug 2022 18:01:26 GMT, Alexey Ushakov wrote: >> Do not cause redundant endEncoder calls with batch processing of drawing >> primitives > > Alexey Ushakov has updated the pull request incrementally with one additional > commit since the last revision: > > 8291266: RenderPerfTest: mi

Re: RFR: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName [v2]

2022-08-11 Thread Phil Race
On Fri, 5 Aug 2022 02:25:11 GMT, Ao Qi wrote: >> The issue comes from >> https://github.com/openjdk/jdk/pull/9677#issuecomment-1200811357. >> >> If Loom is not supported, two XMLDecoder tests would fail. The issue could >> be reproduced by zero, for example: >> >> >> ---

Re: RFR: 8292244: Remove unnecessary include directories

2022-08-11 Thread Phil Race
On Thu, 11 Aug 2022 09:56:29 GMT, Daniel Jeliński wrote: > Remove `java.base:include` from `EXTRA_HEADER_DIRS`. > > The directory contains base versions of the files present in > `/support/modules_include/java.base`; the latter is automatically > [included in every JDK library > build](https:

Re: RFR: 7189422: [macosx] Submenu's arrow have a wrong position

2022-08-11 Thread Phil Race
On Fri, 5 Aug 2022 08:58:51 GMT, Prasanta Sadhukhan wrote: > Issue is Arrow in submenu with empty title have a wrong position in Aqua L&F > as can be seen > > src="https://user-images.githubusercontent.com/43534309/183023538-de8e51b4-31e6-45d7-b2bd-35da5e29c1e8.png";> > > > which is because

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v5]

2022-08-11 Thread Damon Nguyen
On Thu, 11 Aug 2022 16:43:29 GMT, Damon Nguyen wrote: >> When a JComboBox is editable, the button segment of the combo box is >> misaligned vertically and has a different height. This change fixes these >> issues and adds a manual test that checks the appearance of an editable and >> non-edita

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v4]

2022-08-11 Thread Damon Nguyen
On Thu, 11 Aug 2022 15:53:20 GMT, Andrey Turbanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed newline. > > src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxUI.java line 471: > >> 469:

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v4]

2022-08-11 Thread Damon Nguyen
On Thu, 11 Aug 2022 15:55:30 GMT, Harshitha Onkar wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed newline. > > src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxUI.java line 458: > >> 456: clas

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v5]

2022-08-11 Thread Damon Nguyen
> When a JComboBox is editable, the button segment of the combo box is > misaligned vertically and has a different height. This change fixes these > issues and adds a manual test that checks the appearance of an editable and > non-editable JComboBox. > > One of the discussions revolving this is

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v4]

2022-08-11 Thread Harshitha Onkar
On Thu, 11 Aug 2022 15:47:40 GMT, Damon Nguyen wrote: >> When a JComboBox is editable, the button segment of the combo box is >> misaligned vertically and has a different height. This change fixes these >> issues and adds a manual test that checks the appearance of an editable and >> non-edita

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v4]

2022-08-11 Thread Harshitha Onkar
On Thu, 11 Aug 2022 15:47:40 GMT, Damon Nguyen wrote: >> When a JComboBox is editable, the button segment of the combo box is >> misaligned vertically and has a different height. This change fixes these >> issues and adds a manual test that checks the appearance of an editable and >> non-edita

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v4]

2022-08-11 Thread Andrey Turbanov
On Thu, 11 Aug 2022 15:47:40 GMT, Damon Nguyen wrote: >> When a JComboBox is editable, the button segment of the combo box is >> misaligned vertically and has a different height. This change fixes these >> issues and adds a manual test that checks the appearance of an editable and >> non-edita

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v3]

2022-08-11 Thread Damon Nguyen
> When a JComboBox is editable, the button segment of the combo box is > misaligned vertically and has a different height. This change fixes these > issues and adds a manual test that checks the appearance of an editable and > non-editable JComboBox. > > One of the discussions revolving this is

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v4]

2022-08-11 Thread Damon Nguyen
> When a JComboBox is editable, the button segment of the combo box is > misaligned vertically and has a different height. This change fixes these > issues and adds a manual test that checks the appearance of an editable and > non-editable JComboBox. > > One of the discussions revolving this is

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-11 Thread Abhishek Kumar
On Thu, 11 Aug 2022 10:02:56 GMT, Abhishek Kumar wrote: >> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 KB. >> Manual Test Case "FileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-08-11 Thread Damon Nguyen
On Tue, 12 Jul 2022 22:56:37 GMT, Damon Nguyen wrote: >> When a JComboBox is editable, the button segment of the combo box is >> misaligned vertically and has a different height. This change fixes these >> issues and adds a manual test that checks the appearance of an editable and >> non-edita

Re: RFR: 8292244: Remove unnecessary include directories

2022-08-11 Thread Dio Brando
On Thu, 11 Aug 2022 09:56:29 GMT, Daniel Jeliński wrote: > Remove `java.base:include` from `EXTRA_HEADER_DIRS`. > > The directory contains base versions of the files present in > `/support/modules_include/java.base`; the latter is automatically > [included in every JDK library > build](https:

Re: RFR: 8292244: Remove unnecessary include directories

2022-08-11 Thread Erik Joelsson
On Thu, 11 Aug 2022 09:56:29 GMT, Daniel Jeliński wrote: > Remove `java.base:include` from `EXTRA_HEADER_DIRS`. > > The directory contains base versions of the files present in > `/support/modules_include/java.base`; the latter is automatically > [included in every JDK library > build](https:

Re: RFR: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName

2022-08-11 Thread Ao Qi
On Thu, 11 Aug 2022 10:52:17 GMT, Alan Bateman wrote: > > Thanks, @AlanBateman ! Let's wait and see if @prrace approves the change. > > I didn't see any more from @prrace. If you don't get a response in the next > day or so then I would suggest just integrating this. It will help others > that

RFR: 8292244: Remove unnecessary include directories

2022-08-11 Thread Daniel Jeliński
Remove `java.base:include` from `EXTRA_HEADER_DIRS`. The directory contains base versions of the files present in `/support/modules_include/java.base`; the latter is automatically [included in every JDK library build](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L434

Re: RFR: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName

2022-08-11 Thread Alan Bateman
On Wed, 3 Aug 2022 05:59:34 GMT, Alan Bateman wrote: >>> One other comment on this is that the proposed change should mean that the >>> tests no longer need to run with --enable-preview. >> >> You've lost me all over again. >> Why did these two tests need that in the first place and why would t

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v16]

2022-08-11 Thread Abhishek Kumar
On Wed, 10 Aug 2022 19:30:29 GMT, Phil Race wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated as per review comments > > To have all files 1->1000 bytes be 1.0kB and yet 1,100 -> 1,200 bytes be > 1.1kB d

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v17]

2022-08-11 Thread Abhishek Kumar
> JFileChooser - empty file size issue fixed. > For empty file, now the size 0 KB. > Manual Test Case "FileSizeCheck.java" created. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: Smaller file sizes display one decimal precision -

Integrated: 8292026: Remove redundant allocations from DoubleByteEncoder

2022-08-11 Thread Andrey Turbanov
On Fri, 5 Aug 2022 07:07:57 GMT, Andrey Turbanov wrote: > There are couple places where new byte array is allocated and then thrown > away. This pull request has now been integrated. Changeset: 2ddf7287 Author:Andrey Turbanov URL: https://git.openjdk.org/jdk/commit/2ddf72874faedaca