Re: RFR: 8292350: Use static methods for hashCode/toString primitives

2022-08-19 Thread Jaikiran Pai
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote: > It's a bit shorter and clearer. Looks fine to me. - Marked as reviewed by jpai (Reviewer). PR: https://git.openjdk.org/jdk/pull/9816

RFR: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different

2022-08-19 Thread Harshitha Onkar
On Windows, the insets obtained for a Non-Resizable AWT Frame was different when frame.pack() was called and subsequent call to frame.getInsets() or frame.getPreferredSize(). Due to this, the actual and preferred size differed when frame.pack() was called for Non-Resizable frame (on Windows).

Re: RFR: 8292350: Use static methods for hashCode/toString primitives

2022-08-19 Thread Alex Menkov
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote: > It's a bit shorter and clearer. Marked as reviewed by amenkov (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9816

Re: RFR: 8292304: [REDO] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS

2022-08-19 Thread Phil Race
On Tue, 16 Aug 2022 08:26:08 GMT, Maxim Kartashev wrote: > See also the [original pull > request](https://github.com/openjdk/jdk/pull/9362) where the change is > explained and discussed in details. > > Compared to the original version of this fix I > * changed the error reporting from `printS

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v21]

2022-08-19 Thread Abhishek Kumar
On Fri, 19 Aug 2022 10:27:53 GMT, Prasanta Sadhukhan wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> whitespace error removed > > test/jdk/javax/swing/JFileChooser/FileSizeCheck.java line 60: > >> 58:

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v22]

2022-08-19 Thread Abhishek Kumar
> JFileChooser - empty file size issue fixed. > For empty file, now the size 0 KB. > Manual Test Case "FileSizeCheck.java" created. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: Updated as per review comment - Chang

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v21]

2022-08-19 Thread Prasanta Sadhukhan
On Wed, 17 Aug 2022 09:08:00 GMT, Abhishek Kumar wrote: >> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 KB. >> Manual Test Case "FileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the las

Integrated: 8289562: Change bugs.java.com and bugreport.java.com URL's to https

2022-08-19 Thread Joe
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote: > 8289562: Change bugs.java.com and bugreport.java.com URL's to https This pull request has now been integrated. Changeset: 1f484dae Author:Joe Committer: Fairoz Matte URL: https://git.openjdk.org/jdk/commit/1f484dae4efaa60cf18a3d4df947c

RFR: 7175397: The divider color is not changed to green when dragging for Nimbus LaF.

2022-08-19 Thread Prasanta Sadhukhan
SplitPaneDivider.draggingColor UIProperty was not honoured in Nimbus L&F. Added support for setting SplitPane dragging color for Nimbus L&F by drawing a fillRect of the set color as done in BasicLookAndFeel. The fix relies on `continuousLayout` property being false by default which is enabled fo