Re: RFR: 4797982: Setting negative size of JSplitPane divider leads to unexpected results. [v6]

2022-08-21 Thread Prasanta Sadhukhan
On Sun, 21 Aug 2022 21:34:10 GMT, Phil Race wrote: >> We were not sure if -ve divider size can be used by third party >> implementation. It probably will be considered a compatibility issue as >> mentioned earlier. >> @prrace Will you be ok to throw IAE instead of ignoring -ve value as >> sug

Re: RFR: JDK-8292276 : Missing color names in CSS. [v6]

2022-08-21 Thread SWinxy
On Tue, 16 Aug 2022 21:37:30 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Missing color names in >> CSS](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Missing color names in >>

Re: RFR: 4797982: Setting negative size of JSplitPane divider leads to unexpected results. [v6]

2022-08-21 Thread Karl T
On Thu, 28 Jul 2022 04:07:55 GMT, Prasanta Sadhukhan wrote: >> Setting JSplitPane divider size to negative value leads to unexpected >> results and is not desirable and seems to be not practical. >> I guess we should return IAE but it might break existing app so fixed to >> clamp it to 0 incas

Re: RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v8]

2022-08-21 Thread Phil Race
On Thu, 11 Aug 2022 22:27:39 GMT, Harshitha Onkar wrote: >> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds >> of test instruction frame are added to PassFailJFrame to handle positioning >> of multiple test frames. >> >> In scenarios where multiple test windows migh

Re: RFR: 8292280: Unused field 'keyListener' in BasicRadioButtonUI [v2]

2022-08-21 Thread Andrey Turbanov
On Sun, 21 Aug 2022 21:27:30 GMT, Phil Race wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8292280: Unused field 'keyListener' in BasicRadioButtonUI >> >> reverted unrelated changes > > src/java.desktop/sh

Re: RFR: 8292280: Unused field 'keyListener' in BasicRadioButtonUI [v2]

2022-08-21 Thread Andrey Turbanov
> Field `keyListener` was added under > [JDK-8033699](https://bugs.openjdk.org/browse/JDK-8033699). But then all its > usages were removed in > [JDK-8249548](https://bugs.openjdk.org/browse/JDK-8249548) Andrey Turbanov has updated the pull request incrementally with one additional commit since

Re: RFR: 4797982: Setting negative size of JSplitPane divider leads to unexpected results. [v6]

2022-08-21 Thread Phil Race
On Thu, 18 Aug 2022 12:08:43 GMT, Prasanta Sadhukhan wrote: > We were not sure if -ve divider size can be used by third party > implementation. It probably will be considered a compatibility issue as > mentioned earlier. > @prrace Will you be ok to throw IAE instead of ignoring -ve value as >

Re: RFR: 8292280: Unused field 'keyListener' in BasicRadioButtonUI

2022-08-21 Thread Phil Race
On Thu, 11 Aug 2022 06:53:16 GMT, Andrey Turbanov wrote: > Field `keyListener` was added under > [JDK-8033699](https://bugs.openjdk.org/browse/JDK-8033699). But then all its > usages were removed in > [JDK-8249548](https://bugs.openjdk.org/browse/JDK-8249548) src/java.desktop/share/classes/ja

Re: RFR: 7175397: The divider color is not changed to green when dragging for Nimbus LaF.

2022-08-21 Thread Phil Race
On Fri, 19 Aug 2022 07:40:13 GMT, Prasanta Sadhukhan wrote: > SplitPaneDivider.draggingColor UIProperty was not honoured in Nimbus L&F. > Added support for setting SplitPane dragging color for Nimbus L&F by drawing > a fillRect of the set color as done in BasicLookAndFeel. > The fix relies on

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v22]

2022-08-21 Thread Phil Race
On Fri, 19 Aug 2022 10:40:14 GMT, Abhishek Kumar wrote: >> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 KB. >> Manual Test Case "FileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 7175397: The divider color is not changed to green when dragging for Nimbus LaF.

2022-08-21 Thread Andrey Turbanov
On Fri, 19 Aug 2022 07:40:13 GMT, Prasanta Sadhukhan wrote: > SplitPaneDivider.draggingColor UIProperty was not honoured in Nimbus L&F. > Added support for setting SplitPane dragging color for Nimbus L&F by drawing > a fillRect of the set color as done in BasicLookAndFeel. > The fix relies on