Re: RFR: 8293088: Fix compilation with the new Visual Studio preprocessor

2022-08-30 Thread Magnus Ihse Bursie
On Tue, 30 Aug 2022 12:08:09 GMT, Daniel Jeliński wrote: > Fix compilation with Zc:preprocessor enabled. > > The flag itself will be enabled in > [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the > flag using instructions found in Magnus's comment on that issue. > > W

Re: RFR: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different

2022-08-30 Thread Tejesh R
On Tue, 30 Aug 2022 13:39:00 GMT, Alexey Ivanov wrote: >> It could have been declared, initialized and deleted inside the if block >> right..? > > It was before. Now the `if`-condition uses `target` object: > > if (... || JNU_IsInstanceOfByName(env, target, "java/awt/Frame") > 0) > > Thus,

Re: RFR: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different

2022-08-30 Thread Alexey Ivanov
On Tue, 30 Aug 2022 06:57:05 GMT, Tejesh R wrote: >> It's used in the condition of the `if`-block. > > It could have been declared, initialized and deleted inside the if block > right..? It was before. Now the `if`-condition uses `target` object: if (... || JNU_IsInstanceOfByName(env, targ

RFR: 5074006: Swing JOptionPane shows tag as a string after newline

2022-08-30 Thread Prasanta Sadhukhan
If JOptionPane's message content both linefeed/cursor return and HTML tag, "" will be shown in the JOptionPane dialog box because after every new line it creates a new messageComponent so the characters after the newline ie html tag will be considered as a new JLabel string and displayed. Fix is

RFR: 8293088: Fix compilation with the new Visual Studio preprocessor

2022-08-30 Thread Daniel Jeliński
Fix compilation with Zc:preprocessor enabled. The flag itself will be enabled in [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the flag using instructions found in Magnus's comment on that issue. Windows 10 SDK version 2104 (10.0.20348.0) is required for successful com

Integrated: 8292850: Unused field 'expiredTimersKey' in javax.swing.TimerQueue

2022-08-30 Thread Andrey Turbanov
On Wed, 24 Aug 2022 18:05:40 GMT, Andrey Turbanov wrote: > 8292850: Unused field 'expiredTimersKey' in javax.swing.TimerQueue This pull request has now been integrated. Changeset: b3450e93 Author:Andrey Turbanov URL: https://git.openjdk.org/jdk/commit/b3450e930e52f03ffc3891de7672625

Integrated: 8291792: DefaultStyledDocument.setCharacterAttributes accepts negative length

2022-08-30 Thread Tejesh R
On Thu, 11 Aug 2022 05:21:48 GMT, Tejesh R wrote: > The Document for _DefaultStyledDocument.setCharacterAttribute_ states that > the range of length accepted is `length - the length >= 0`, whereas in code > the length check is done only for `length==0`. Meaning the control just > returns if th

Integrated: 8290344: Start/stop displaysync affects performance in metal rendering pipeline

2022-08-30 Thread Alexey Ushakov
On Fri, 15 Jul 2022 11:32:20 GMT, Alexey Ushakov wrote: > Reuse displaysync thread for subsequent updates This pull request has now been integrated. Changeset: f766d927 Author:Alexey Ushakov URL: https://git.openjdk.org/jdk/commit/f766d92755276a40f0cdc087db32c285548572fe Stats: