On Thu, 8 Sep 2022 21:07:49 GMT, Harshitha Onkar wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated copyright date. Added MacOS text to test.
>
> test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java line 74
On Fri, 9 Sep 2022 23:13:57 GMT, Damon Nguyen wrote:
>> When a JComboBox is editable, the button segment of the combo box is
>> misaligned vertically and has a different height. This change fixes these
>> issues and adds a manual test that checks the appearance of an editable and
>> non-editab
> When a JComboBox is editable, the button segment of the combo box is
> misaligned vertically and has a different height. This change fixes these
> issues and adds a manual test that checks the appearance of an editable and
> non-editable JComboBox.
>
> One of the discussions revolving this is
On Fri, 2 Sep 2022 11:12:53 GMT, Abhishek Kumar wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 KB.
>> Manual Test Case "FileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last
> JFileChooser - empty file size issue fixed.
> For empty file, now the size 0 KB.
> Manual Test Case "FileSizeCheck.java" created.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Review comments fix
-
Changes:
- al
On Fri, 26 Aug 2022 07:54:24 GMT, Matthias Baesken wrote:
>> https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-multibytetowidechar
>> states about MultiByteToWideChar : "The function returns 0 if it does not
>> succeed" and lists a few failure cases.
>> However we m
On Tue, 6 Sep 2022 11:07:09 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> I guess copyright year for FilePane.java needs to be updated.
> @kumarabhi006 U migh
On Fri, 9 Sep 2022 08:12:45 GMT, Tejesh R wrote:
>> JFileChooser.getSelectedFiles() failed to retrieve files with
>> multi-selection and double-click. This occurs when a single file is selected
>> then enable multi-selection then select the same file through mouse
>> double-click(Two file choo
On Fri, 9 Sep 2022 11:05:09 GMT, Tejesh R wrote:
> > @TejeshR13 I see some test failures in latest CI job like
> > javax/swing/JTree/4618767/JTreeSelectedElementTest.java. Have you verified
> > these are not regressions introduced by this change?
>
> Yeah, those tests are failing without my ch
On Fri, 9 Sep 2022 08:11:47 GMT, Tejesh R wrote:
>> I guess copyright year for FilePane.java needs to be updated.
>
> @kumarabhi006 U might have to re-review the PR as we have changed the logic.
> Previously the selected flies state was retained, now the state is been
> cleared on MultiSelectio
On Fri, 9 Sep 2022 08:11:47 GMT, Tejesh R wrote:
>> I guess copyright year for FilePane.java needs to be updated.
>
> @kumarabhi006 U might have to re-review the PR as we have changed the logic.
> Previously the selected flies state was retained, now the state is been
> cleared on MultiSelectio
> When comboBox have focus, pressing Alt+Down (or Up) should render the popup
> which is not happening for Aqua L&F.
>
> Fix is to add toggleAction for Alt+Down/Up keys as has been done for
> [MetalLookAndFeel](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing
On Thu, 25 Aug 2022 18:56:59 GMT, Phil Race wrote:
>> Could you please review the JDK-8292848 bug fixes?
>> The purpose of the isOel7 method is to detect differences in GNOME version
>> changes, and the isOel7
>> result should be true after version 8.
>> I modified the isOel7 method to use regu
On Tue, 6 Sep 2022 11:07:09 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> I guess copyright year for FilePane.java needs to be updated.
@kumarabhi006 U might
On Thu, 8 Sep 2022 17:32:34 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Filesize calculation logic modified
>
> src/java.desktop/share/classes/sun/swing/FilePane.java line 1277:
>
>> 1275:
On Thu, 8 Sep 2022 09:51:57 GMT, Jayathirth D V wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/MultiSelectionEnabledSelectedFilesTest.java
> line
On Thu, 8 Sep 2022 11:03:32 GMT, Jayathirth D V wrote:
>> I guess the dialogue is not not been removed when exception is thrown. Will
>> take a look into it.
>
> If the product fix that is being done will touch only Linux and Windows(And
> in Mac it looks like it not exiting properly), we can m
> JFileChooser.getSelectedFiles() failed to retrieve files with multi-selection
> and double-click. This occurs when a single file is selected then enable
> multi-selection then select the same file through mouse double-click(Two file
> chooser dialogs used before and after multi-selection enabl
On Thu, 8 Sep 2022 11:49:36 GMT, Jayathirth D V wrote:
>> Clearing the selection and setting it to null also solves the problem
>> though. When we call clear selection, reset will happen and selectedFiles
>> will be set.
>
> As discussed on call its better to clear selection when we move betwee
On Tue, 6 Sep 2022 05:37:02 GMT, Abhishek Kumar wrote:
> Disabled JMenu foreground color was not grayed out in GTK LAF for version 3.
> The issue didn't occur in GTK-2.
> After analysis it has been found that the JMenu widget type was changed to
> JMenuBar and the color value returned for the
On Wed, 31 Aug 2022 17:49:35 GMT, Damon Nguyen wrote:
>> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxUI.java line 471:
>>
>>> 469:
>>> 470: if (comboBox.getComponentOrientation().isLeftToRight()) {
>>> 471: return new Rectangle(insets.left, insets.top +
On Wed, 17 Aug 2022 22:37:46 GMT, Damon Nguyen wrote:
>> When a JComboBox is editable, the button segment of the combo box is
>> misaligned vertically and has a different height. This change fixes these
>> issues and adds a manual test that checks the appearance of an editable and
>> non-edita
22 matches
Mail list logo
