This is redo of https://bugs.openjdk.org/browse/JDK-8262297
In https://bugs.openjdk.org/browse/JDK-8262297 we added similar change but we
didnt allow 15bpp image in BMP, because of which many tests which were using
USHORT_555_RGB format were failing as reported at
https://bugs.openjdk.org/browse
On Fri, 23 Sep 2022 11:23:40 GMT, Tejesh R wrote:
> Is there any possibility to check for current Directory to be `root` before
> confirming that the traversal is stopping at root?
Added the condition to check if the current directory is root.
-
PR: https://git.openjdk.org/jdk/pul
On Fri, 23 Sep 2022 11:14:39 GMT, Tejesh R wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Comment added and test case condotion update
>
> test/jdk/javax/swing/JFileChooser/TestFileChooserDirectorySelection.java
On Fri, 23 Sep 2022 11:11:12 GMT, Tejesh R wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Comment added and test case condotion update
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChoose
> When a user selects ../ from directory list in GTK FileChooser continuosly,
> it leads to '../../../.' in combobox and selection textarea even though
> it the current directory is at root level.
>
> Fix for the issue is to check if current directory is root then don't process
> the select
On Thu, 22 Sep 2022 19:15:05 GMT, Harshitha Onkar wrote:
>> The color returned for `InteriorBackground` property is the default color
>> used for only _WindowsClassicLookAndFeel_. For _WindowsLookAndFeel_ the
>> `InteriorBackground` color is not been used when checkbox paint happens. In
>> _Wi
On Thu, 22 Sep 2022 12:23:36 GMT, Prasanta Sadhukhan
wrote:
>> If there is invalid tag, stack terminates but it still tries to recurse
>> through by calling legalElementContext() which results in StackOverflowError.
>> Fix is to return if stack is terminated after checking current tag is not
>
On Fri, 23 Sep 2022 19:05:53 GMT, Phil Race wrote:
>> API specification says about BasicTextAreaUI.create "Returns a
>> WrappedPlainView or PlainView".
>> But for
>> [bidi](https://github.com/openjdk/jdk/blob/d14e96d9701dae951aa365029f58afb6687a646a/src/java.desktop/share/classes/javax/swing/p
Appends: `, copying the array contents of {@code xpoints} and {@code ypoints}`
to specify that the arrays in the constructor are explicitly copied.
-
Commit messages:
- 4756278: RFE: Insufficient API documentation for java.awt.Polygon constructor
Changes: https://git.openjdk.org/jd
New documentation replaces the `This value can be null.`:
When created, {@link #invalidate() invalidated}, or {@link #reset() reset},
this becomes {@code null}. To get out of the null state,
{@link #getBounds()} called with {@link #npoints} being greater than
{@code 0} will transfer into a non-nul
> The `SDRenderType` enum is often returned using a variable declared at the
> start of functions. These can be inlined in the `return` itself. Using a
> ternary operator condenses what may be 12 lines into one, in the most extreme
> cases. `doRectUsingCG` and `doPolyUsingCG` were both modified
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
I'm not a committer (yet) so I can't [sponsor](https://openjdk.org/sponsor/)
this PR, even though I would.
-
PR: https://git.openjdk.org/jdk/pull/10
On Tue, 30 Aug 2022 09:55:18 GMT, Lance Andersen wrote:
>> src/java.base/share/native/libzip/zlib/zlib.h line 756:
>>
>>> 754:If this is done, the old level and strategy will be applied to the
>>> data
>>> 755:compressed before deflateParams(), and the new level and strategy
>>> will b
On Tue, 30 Aug 2022 09:31:07 GMT, Alan Bateman wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> src/java.base/share/native/libzip/zlib/zlib.h line 756:
>
>> 754:If this is done, the old level and strategy will be applied to the
>> data
>> 755:com
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
src/java.base/share/native/libzip/zlib/zlib.h line 756:
> 754:If this is done, the old level and strategy will be applied to the
> data
> 755:compressed
On Sun, 25 Sep 2022 16:51:27 GMT, SWinxy wrote:
> Oh no what happened
Oops! Thanks for pointing out the goof. It seems to be fixed now.
It has now been a month since I opened the pull request, and I have responded
to each substantive comment promptly. It would be great to merge this pull
r
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
Oh no what happened
src/java.xml/share/classes/com/
On Sat, 24 Sep 2022 10:41:05 GMT, Jaikiran Pai wrote:
> Splitting these changes into smaller PRs instead of one big one that touches
> several different areas of the JDK and 108 files, will help reviewers.
OK. I'll repeat my comment from before:
> Feel free to split up the pull request, if yo
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
Hello Michael,
> > these changes are mostly fine.
>
> Can you be specific about the exact problems that you noticed that prevented
> you from saying "these chan
On Mon, 5 Sep 2022 14:54:50 GMT, Michael Ernst wrote:
> Can you be specific about the exact problems that you noticed that prevented
> you from saying "these changes are fine"?
These changes are fine. I don't see an instance where the duplicated words
would mean a change in the specification.
On Mon, 5 Sep 2022 06:32:44 GMT, Jaikiran Pai wrote:
> these changes are mostly fine.
Can you be specific about the exact problems that you noticed that prevented
you from saying "these changes are fine"? It doesn't seem useful to make a
pull request with known deficiencies.
> we usually spl
On Thu, 25 Aug 2022 19:55:47 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
>> If you already are an OpenJDK
>> [Author](https://openjdk.java.net/bylaws#author),
>> [Committer](https://openjdk.java.net/bylaws#committer) or
>> [Reviewe
8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
-
Commit messages:
- Remove file that was removed upstream
- Fix inconsistency in capitalization
- Undo change in zlip
- Fix typos
Changes: https://git.openjdk.org/jdk/pull/10029/files
Webrev: https://we
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
> If you already are an OpenJDK
> [Author](https://openjdk.java.net/bylaws#author),
> [Committer](https://openjdk.java.net/bylaws#committer) or
> [Reviewer](htt
24 matches
Mail list logo
