Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-29 Thread Iris Clark
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated th

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org

2022-09-29 Thread Joe Darcy
On Fri, 30 Sep 2022 00:48:02 GMT, Mikael Vidstedt wrote: > Switch to https where needed/applicable while at it? Good idea; might as well do the update in a single changeset. - PR: https://git.openjdk.org/jdk/pull/10501

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-29 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with one additional commit sinc

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v3]

2022-09-29 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with one additional commit sinc

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org

2022-09-29 Thread Mikael Vidstedt
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote: > With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Switch to https where needed/app

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v2]

2022-09-29 Thread Mikael Vidstedt
On Fri, 30 Sep 2022 00:50:13 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated th

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v2]

2022-09-29 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with two additional commits sin

RFR: JDK-8294618: Update openjdk.java.net => openjdk.org

2022-09-29 Thread Joe Darcy
With the domain change from openjdk.java.net to openjdk.org, references to URLs in the sources should be updated. Updates were made using a shell script. I"ll run a copyright updater before any push. - Commit messages: - JDK-8294618: Update openjdk.java.net => openjdk.org Changes

Re: RFR: JDK-8015739: Background of JInternalFrame is located out of JInternalFrame [v4]

2022-09-29 Thread Harshitha Onkar
> JInternalFrame background color seems to overflow into the border region. > This issue is more prominently seen on Windows - Metal LAF (with fractional > scaling, as shown below). The primary reason is border scaling issue as > observed in - [JDK-8279614](https://bugs.openjdk.org/browse/JDK-82

Re: RFR: JDK-8015739: Background of JInternalFrame is located out of JInternalFrame [v3]

2022-09-29 Thread Harshitha Onkar
On Thu, 29 Sep 2022 19:47:43 GMT, Alexander Zuev wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added local variable for scaled corner > > test/jdk/javax/swing/JInternalFrame/InternalFrameBorderTest.java line 8

Re: RFR: 7175396: The text on label is not painted red for Nimbus LaF. [v5]

2022-09-29 Thread Andrey Turbanov
On Thu, 29 Sep 2022 09:24:21 GMT, Prasanta Sadhukhan wrote: >> Label.foreground UIProperty is not honored by Nimbus L&F. >> Added support for setting JLabel foreground color for Nimbus L&F > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the l

Re: RFR: JDK-8015739: Background of JInternalFrame is located out of JInternalFrame [v3]

2022-09-29 Thread Alexander Zuev
On Wed, 21 Sep 2022 18:16:39 GMT, Harshitha Onkar wrote: >> JInternalFrame background color seems to overflow into the border region. >> This issue is more prominently seen on Windows - Metal LAF (with fractional >> scaling, as shown below). The primary reason is border scaling issue as >> obs

Integrated: 8294595: Add javax/swing/plaf/aqua/CustomComboBoxFocusTest.java to problem list

2022-09-29 Thread Alexander Zvegintsev
On Thu, 29 Sep 2022 16:22:29 GMT, Alexander Zvegintsev wrote: > Problem listing PR This pull request has now been integrated. Changeset: 29c70f1a Author:Alexander Zvegintsev URL: https://git.openjdk.org/jdk/commit/29c70f1ab7df3b386d326509db48acf91dd124ab Stats: 1 line in 1 file

Re: RFR: 5080391: ArrayIndexOutOfBounds during "undo" of Right-to-Left text insert

2022-09-29 Thread Tejesh R
On Tue, 27 Sep 2022 11:16:36 GMT, Prasanta Sadhukhan wrote: > javax.swing.text.AbstractDocument$BranchElement.replace(...) method throws an > `ArrayIndexOutOfBoundsException: arraycopy: length -1 is negative` when using > an UndoManager on the default document of a JTextArea and you try to und

RFR: 8294595: Add javax/swing/plaf/aqua/CustomComboBoxFocusTest.java to problem list

2022-09-29 Thread Alexander Zvegintsev
Problem listing PR - Commit messages: - initial Changes: https://git.openjdk.org/jdk/pull/10495/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10495&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294595 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch:

Re: RFR: 8294595: Add javax/swing/plaf/aqua/CustomComboBoxFocusTest.java to problem list

2022-09-29 Thread Roger Riggs
On Thu, 29 Sep 2022 16:22:29 GMT, Alexander Zvegintsev wrote: > Problem listing PR Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10495

Re: RFR: JDK-8292276 : Missing color names in CSS [v23]

2022-09-29 Thread ScientificWare
On Thu, 29 Sep 2022 14:35:10 GMT, Alexey Ivanov wrote: > I said, I would submit a CSR for you after we agree on the updated javadoc > for StyleSheet.stringToColor. Sorry, I didn't realize the message was from the bot. - PR: https://git.openjdk.org/jdk/pull/9825

Re: RFR: 8276849: Refresh the window icon on graphics configuration changes [v4]

2022-09-29 Thread Emmanuel Bourg
On Thu, 24 Mar 2022 02:35:03 GMT, Phil Race wrote: >> Just tested on macOS 12 with a non Retina screen and OpenJDK 8: the icon >> displayed in the dock when the test frame is minimized is the 32x32 one. If >> I add more icons to the list, it picks the biggest one, up to 128x128. >> Bigger icon

Re: RFR: 8276849: Refresh the window icon on graphics configuration changes [v6]

2022-09-29 Thread Emmanuel Bourg
> When a list of icons is set on a window, the most appropiate icon is selected > depending on the graphics configuration. But if the graphics configuration > changes (because the window is moved to a different screen, or because the > DPI settings of the screen is changed), the frame icon isn't

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v30]

2022-09-29 Thread Abhishek Kumar
On Thu, 29 Sep 2022 12:27:03 GMT, Alexey Ivanov wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> modifiers order changed as per review comment > > src/java.desktop/share/classes/sun/swing/FilePane.java line 1129:

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v31]

2022-09-29 Thread Abhishek Kumar
> JFileChooser - empty file size issue fixed. > For empty file, now the size 0 KB. > Manual Test Case "FileSizeCheck.java" created. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: Review comment fix - Changes: - all

Re: RFR: JDK-8292276 : Missing color names in CSS [v23]

2022-09-29 Thread Alexey Ivanov
On Thu, 29 Sep 2022 14:11:03 GMT, ScientificWare wrote: > > ... please create a [CSR](https://wiki.openjdk.org/display/csr/Main) > > request for issue > > [JDK-8292276](https://bugs.openjdk.org/browse/JDK-8292276) with the correct > > fix version. This pull request cannot be integrated until t

Re: RFR: 8294456: Fix misleading-indentation warnings in JDK

2022-09-29 Thread Daniel Fuchs
On Thu, 29 Sep 2022 13:44:40 GMT, Raffaello Giulietti wrote: >> src/java.base/share/native/libfdlibm/e_asin.c line 102: >> >>> 100: } else >>> 101: t = x*x; >>> 102: p = t*(pS0+t*(pS1+t*(pS2+t*(pS3+t*(pS4+t*pS5); >> >> should we add an opening brace

Re: RFR: 8294456: Fix misleading-indentation warnings in JDK

2022-09-29 Thread Raffaello Giulietti
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti wrote: > This fixes misleading indentations, which allows enabling the (currently > disabled) `misleading-indentation` warning flag on two `.gmk` files. Sure. - PR: https://git.openjdk.org/jdk/pull/10487

Re: RFR: 8294456: Fix misleading-indentation warnings in JDK

2022-09-29 Thread Aleksey Shipilev
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti wrote: > This fixes misleading indentations, which allows enabling the (currently > disabled) `misleading-indentation` warning flag on two `.gmk` files. This looks okay, but let's wait for #10426 to integrate first? - PR: http

Re: RFR: JDK-8292276 : Missing color names in CSS [v23]

2022-09-29 Thread ScientificWare
On Thu, 29 Sep 2022 10:53:32 GMT, Alexey Ivanov wrote: > Shall I edit the subject of the issue to be more specific? “Add named colors > from CSS Color Module Level 4”? Yes, you may. Thanks. > ... please create a [CSR](https://wiki.openjdk.org/display/csr/Main) request > for issue [JDK-8292276

Re: RFR: 8294456: Fix misleading-indentation warnings in JDK

2022-09-29 Thread Raffaello Giulietti
On Thu, 29 Sep 2022 13:40:37 GMT, Daniel Fuchs wrote: >> This fixes misleading indentations, which allows enabling the (currently >> disabled) `misleading-indentation` warning flag on two `.gmk` files. > > src/java.base/share/native/libfdlibm/e_asin.c line 102: > >> 100: } else >> 1

Re: RFR: 8294456: Fix misleading-indentation warnings in JDK

2022-09-29 Thread Daniel Fuchs
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti wrote: > This fixes misleading indentations, which allows enabling the (currently > disabled) `misleading-indentation` warning flag on two `.gmk` files. src/java.base/share/native/libfdlibm/e_asin.c line 102: > 100: } else > 10

Re: RFR: 8294456: Fix misleading-indentation warnings in JDK

2022-09-29 Thread Raffaello Giulietti
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti wrote: > This fixes misleading indentations, which allows enabling the (currently > disabled) `misleading-indentation` warning flag on two `.gmk` files. The misleading indentation might indicate the original intent of the author, which mig

RFR: 8294456: Fix misleading-indentation warnings in JDK

2022-09-29 Thread Raffaello Giulietti
This fixes misleading indentations, which allows enabling the (currently disabled) `misleading-indentation` warning flag on two `.gmk` files. - Commit messages: - 8294456: Fix misleading-indentation warnings in JDK Changes: https://git.openjdk.org/jdk/pull/10487/files Webrev: http

Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v30]

2022-09-29 Thread Alexey Ivanov
On Wed, 28 Sep 2022 17:23:55 GMT, Abhishek Kumar wrote: >> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 KB. >> Manual Test Case "FileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 7175396: The text on label is not painted red for Nimbus LaF. [v3]

2022-09-29 Thread Alexey Ivanov
On Wed, 28 Sep 2022 06:42:07 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLabelUI.java line >> 222: >> >>> 220: if (fgColor != null) { >>> 221: label.setForeground(fgColor); >>> 222: } >> >> Why is the col

Re: RFR: 7175396: The text on label is not painted red for Nimbus LaF. [v5]

2022-09-29 Thread Alexey Ivanov
On Thu, 29 Sep 2022 09:24:21 GMT, Prasanta Sadhukhan wrote: >> Label.foreground UIProperty is not honored by Nimbus L&F. >> Added support for setting JLabel foreground color for Nimbus L&F > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the l

RFR: 6616245: NullPointerException when using JFileChooser with a custom FileView

2022-09-29 Thread Tejesh R
When a custom `FileView` is used and folder traversal is restricted to a particular directory NPE occurs when user tries to traverse/select other folders except traversable folder. This is caused because when user selects folder other than traversable, the traversal is rejected and hence no file

Re: RFR: JDK-8292276 : Missing color names in CSS [v23]

2022-09-29 Thread Alexey Ivanov
On Wed, 28 Sep 2022 17:13:42 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Missing color names in >> CSS](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Missing color names in >>

Re: RFR: JDK-8292276 : Missing color names in CSS [v23]

2022-09-29 Thread Alexey Ivanov
On Wed, 28 Sep 2022 17:13:42 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Missing color names in >> CSS](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Missing color names in >>

Re: RFR: 7175396: The text on label is not painted red for Nimbus LaF. [v4]

2022-09-29 Thread Prasanta Sadhukhan
On Wed, 28 Sep 2022 15:03:41 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Test fix > > test/jdk/javax/swing/plaf/nimbus/TestNimbusLabel.java line 47: > >> 45: { >> 46: private stati

Re: RFR: 7175396: The text on label is not painted red for Nimbus LaF. [v5]

2022-09-29 Thread Prasanta Sadhukhan
> Label.foreground UIProperty is not honored by Nimbus L&F. > Added support for setting JLabel foreground color for Nimbus L&F Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Test fix - Changes: - all: https://gi