On Mon, 3 Oct 2022 13:59:25 GMT, Jayathirth D V wrote:
> In https://bugs.openjdk.org/browse/JDK-8270915 we have a valid GIF image
> which was generated using a third party app, but it contains large amount of
> Metadata(numerous Application extension blocks).
>
> Also GIFImageReader doesn't us
On Mon, 3 Oct 2022 22:05:14 GMT, Sergey Bylokhov wrote:
> > I have updated readMedata() to also use
> > ReaderUtil.staggeredReadByteStream() where we are allocating upfront memory
> > based on parameters from metadata.
>
> Probably it is possible to create a small test just for this change?
T
On Mon, 26 Sep 2022 06:45:58 GMT, Jayathirth D V wrote:
> This is redo of https://bugs.openjdk.org/browse/JDK-8262297
> In https://bugs.openjdk.org/browse/JDK-8262297 we added similar change but we
> didnt allow 15bpp image in BMP, because of which many tests which were using
> USHORT_555_RGB f
On Mon, 26 Sep 2022 11:03:40 GMT, Tejesh R wrote:
> Can we move the test file to one directory back as we are doing it in swing
> test fix. Means moving the test to Multscreen folder, instead of
> MultiScreenLocationTest.?
I second this. The test can sit inside the Multiscreen folder witho
On Wed, 5 Oct 2022 21:00:11 GMT, Harshitha Onkar wrote:
>> JInternalFrame background color seems to overflow into the border region.
>> This issue is more prominently seen on Windows - Metal LAF (with fractional
>> scaling, as shown below). The primary reason is border scaling issue as
>> obse
On Wed, 5 Oct 2022 16:28:40 GMT, Alexey Ivanov wrote:
>>> @aivanov-jdk Regarding saving the screen capture -
>>>
>>> When JIF bounds are used, a partial image of JInternalFrame (JIF) is saved.
>>> Hence I'm using the entire outer JFrame bounds to capture the screenshot.
>>
>> Could be… It shou
> JInternalFrame background color seems to overflow into the border region.
> This issue is more prominently seen on Windows - Metal LAF (with fractional
> scaling, as shown below). The primary reason is border scaling issue as
> observed in - [JDK-8279614](https://bugs.openjdk.org/browse/JDK-82
On Tue, 4 Oct 2022 19:39:23 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review changes, saving a scaled version of image
>
> test/jdk/javax/swing/JInternalFrame/InternalFrameBorderTest.jav
On Tue, 4 Oct 2022 22:06:07 GMT, Harshitha Onkar wrote:
>> JInternalFrame background color seems to overflow into the border region.
>> This issue is more prominently seen on Windows - Metal LAF (with fractional
>> scaling, as shown below). The primary reason is border scaling issue as
>> obse
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote:
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
This pull request has now been i
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target base due to a merge or
a re
On Tue, 4 Oct 2022 18:48:19 GMT, Alexey Ivanov wrote:
>>> > Out of curiosity, can this test use `BufferedImage` to render
>>> > `JInternalFrame` into?
>>>
>>> @aivanov-jdk Thank you for reviewing. I wanted to clarify whether you meant
>>> saving just the JInternalFrame into BufferedImage?
>>
On Wed, 5 Oct 2022 14:06:21 GMT, Raffaello Giulietti
wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> addition
On Fri, 30 Sep 2022 17:42:43 GMT, Alexey Ivanov wrote:
>>> Shall I edit the subject of the issue to be more specific? “Add named
>>> colors from CSS Color Module Level 4”?
>>
>> Yes, you may. Thanks.
>>
>>> ... please create a [CSR](https://wiki.openjdk.org/display/csr/Main)
>>> request for i
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Wed, 5 Oct 2022 10:02:49 GMT, Raffaello Giulietti
wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8294456: Fix misleading-indentat
On Wed, 5 Oct 2022 13:46:23 GMT, Raffaello Giulietti
wrote:
>> I am not completely sure all `misleading-indentation` warnings are fixed in
>> Awt2d, this would require some more testing. I'd defer that to #10453.
>
> Awt2dLibraries.gmk in https://github.com/openjdk/jdk/pull/10453 seems more
>
On Wed, 5 Oct 2022 12:07:13 GMT, Aleksey Shipilev wrote:
>> What is the problem with Awt2d? Other conflicts?
>
> I am not completely sure all `misleading-indentation` warnings are fixed in
> Awt2d, this would require some more testing. I'd defer that to #10453.
Awt2dLibraries.gmk in https://git
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Wed, 5 Oct 2022 12:01:00 GMT, Raffaello Giulietti
wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 298:
>>
>>> 296: HEADERS_FROM_SRC := $(LIBLCMS_HEADERS_FROM_SRC), \
>>> 297: DISABLED_WARNINGS_gcc := format-nonliteral type-limits \
>>> 298: undef unused-functi
On Wed, 5 Oct 2022 10:16:10 GMT, Aleksey Shipilev wrote:
>> Raffaello Giulietti has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains two commits:
>>
>> - 8294456: Fix misleading-indentation warnings in JDK
>>
>>Merge branch 'm
On Thu, 29 Sep 2022 14:39:04 GMT, Abhishek Kumar wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 KB.
>> Manual Test Case "FileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the las
On Wed, 5 Oct 2022 10:02:49 GMT, Raffaello Giulietti
wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a
On Wed, 5 Oct 2022 10:02:49 GMT, Raffaello Giulietti
wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Raffaello Giulietti has updated the pull request with a new target base due to
a merge or a rebase. The pull request now contains two commits:
- 829
On Mon, 3 Oct 2022 20:37:11 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated the
27 matches
Mail list logo
