Re: RFR: 6616245: NullPointerException when using JFileChooser with a custom FileView [v2]

2022-10-09 Thread Abhishek Kumar
On Tue, 4 Oct 2022 05:45:50 GMT, Tejesh R wrote: >> You say that the current directory in `JFileChooser` gets set to `null` >> because of forbidden navigation to a folder which is not traversable. You >> avoid the NPE by a null-check. >> >> However, you should prevent the current directory to

Re: RFR: 8295007: javax/swing/JRadioButton/4314194/bug4314194.java fails in mach5 for WIndowLookAndFeel

2022-10-09 Thread Tejesh R
On Sat, 8 Oct 2022 05:04:57 GMT, Prasanta Sadhukhan wrote: > javax/swing/JRadioButton/4314194/bug4314194.java correct color pixels pixel % > varies between 30% for Metal to about 20% for Nimbus to about 19% for Windows > L But Nimbus in linux correct color pixel % falls to about 14% > so

RFR: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure

2022-10-09 Thread Damon Nguyen
The previous change to AquaComboBoxUI had 1 pixel of overlap between the text field and the combo button. This caused a few pixels to darken sometimes when an editable combobox is displayed. Since this test passes sometimes and fails some other times, it was not initially detected. Since these

Re: professional (24-bit) sampled audio support in the Windows native implementation of libjsound

2022-10-09 Thread SWinxy
JDK-8294904 [1] should be updated with your sample. I'm not exactly sure why it was marked as resolved this past Friday, but the resolution of 'incomplete' makes me think they didn't feel you provided enough information. Also I think the OS was set to 'generic' because the lack of support might

Re: RFR: 8295026: Remove unused fields in StyleSheet

2022-10-09 Thread SWinxy
On Sat, 1 Oct 2022 17:05:11 GMT, Andrey Turbanov wrote: > There are 3 unused fields in single `StyleSheet` file: > 1. `static final Border noBorder = new EmptyBorder(0,0,0,0);` > 2. `static final int DEFAULT_FONT_SIZE = 3;` > 3. `URL imageurl;` in nested

RFR: 8295026: Remove unused fields in StyleSheet

2022-10-09 Thread Andrey Turbanov
There are 3 unused fields in single `StyleSheet` file: 1. `static final Border noBorder = new EmptyBorder(0,0,0,0);` 2. `static final int DEFAULT_FONT_SIZE = 3;` 3. `URL imageurl;` in nested `javax.swing.text.html.StyleSheet.ListPainter` class - Commit messages: - [PATCH] Remove

Re: RFR: 8293984: Unnecessary Vector usage in PropertyEditorSupport [v2]

2022-10-09 Thread Andrey Turbanov
On Fri, 7 Oct 2022 00:07:31 GMT, Sergey Bylokhov wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8293984: Unnecessary Vector usage in PropertyEditorSupport >> >> use ArrayList constructor instead of clone

Re: RFR: 8293984: Unnecessary Vector usage in PropertyEditorSupport [v2]

2022-10-09 Thread Andrey Turbanov
> Field PropertyEditorSupport.listeners is accessed only under > `synchronized(this)`. > It means extra synchronization by Vector is not needed. Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8293984: Unnecessary Vector usage in

Re: RFR: 8295007: javax/swing/JRadioButton/4314194/bug4314194.java fails in mach5 for WIndowLookAndFeel

2022-10-09 Thread Alexey Ivanov
On Sat, 8 Oct 2022 05:04:57 GMT, Prasanta Sadhukhan wrote: > javax/swing/JRadioButton/4314194/bug4314194.java correct color pixels pixel % > varies between 30% for Metal to about 20% for Nimbus to about 19% for Windows > L But Nimbus in linux correct color pixel % falls to about 14% > so

RE: professional (24-bit) sampled audio support in the Windows native implementation of libjsound

2022-10-09 Thread magare31
Since I am new to this, and apologies for the broad email, could someone explain the following for the corresponding bug (JDK-8294904)? * This bug is listed as one for a generic OS, whereas I specified Windows (I can confirm that it is Windows only). * This bug is listed as

Withdrawn: 8288428: javax/swing/JInternalFrame/Test6505027.java fails frequently in MacOS 12 machines

2022-10-09 Thread duke
On Fri, 17 Jun 2022 14:28:15 GMT, Manukumar V S wrote: > javax/swing/JInternalFrame/Test6505027.java seems to be unstable in MacOS > machines, especially in MacOSX 12 machines and it fails intermittently in CI > causing some noise. > It seems to be a testbug as adding some stability