On Wed, 12 Oct 2022 21:30:42 GMT, Sergey Bylokhov wrote:
>> Yet you control which folders are non-traversable. Anyway… A test is better
>> than no test; an automatic test is better than a manual one.
>
> Probably it will be good to automate it, and cover the macOS? I do not see a
> reason why w
On Wed, 28 Sep 2022 12:42:14 GMT, Prasanta Sadhukhan
wrote:
>> CheckBox.disabledText and RadioButton.disabledText color UIProperty is not
>> honoured by Nimbus L&F when disabled text is drawn for JCheckBox and
>> JRadioButton, so disabled text color was rendered incorrectly.
>> Fix is to honou
On Mon, 10 Oct 2022 11:27:27 GMT, Alexey Ivanov wrote:
>> Ok, since the test has to select non traversable folders in both windows and
>> linux I had thought that making it as manual would be better.
>
> Yet you control which folders are non-traversable. Anyway… A test is better
> than no test;
On Wed, 12 Oct 2022 21:16:47 GMT, Sergey Bylokhov wrote:
>> @mrserb Thank for the suggestion. Are you suggesting that same
>> transformations be applied for width, height and additionally to x&y
>> translations?
>> https://github.com/openjdk/jdk/blob/ec4fb47b90c9737dfdc285ebe98367a221c90c79/sr
On Fri, 7 Oct 2022 08:40:42 GMT, Prasanta Sadhukhan
wrote:
>> Label.foreground UIProperty is not honored by Nimbus L&F.
>> Added support for setting JLabel foreground color for Nimbus L&F
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the la
On Fri, 7 Oct 2022 22:01:00 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line
>> 292:
>>
>>> 290: height = Region.clipRound(at.getScaleY() * h);
>>> 291: xtranslation = Region.clipRound(at.getScaleX() * x
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote:
> Markdown files are basically source code for documentation. It should have
> the same whitespace checks as all other source code, so we don't get spurious
> trailing whitespace changes.
This pull request has now been integrated.
Ch
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote:
> Markdown files are basically source code for documentation. It should have
> the same whitespace checks as all other source code, so we don't get spurious
> trailing whitespace changes.
Thank you! Since I enabled visible whitespace
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are
On Tue, 13 Sep 2022 22:03:44 GMT, Phil Race wrote:
>> I see now that Phil cryptically said:
>>
>>> Regarding changes in gif + freetype
>> diff --git a/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c
>> b/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c \
>> \
>> d
In autoconf 2.71, there is a warning generated for calling AC_CHECK_HEADERS
with a variable.
It is not clear to me why they consider this to be a problem, but the warning
is printed whenever you run configure with autoconf 2.71 or newer, and it is
annoying.
We're only doing this in one place.
Markdown files are basically source code for documentation. It should have the
same whitespace checks as all other source code, so we don't get spurious
trailing whitespace changes.
-
Commit messages:
- 8295205: Add jcheck whitespace checking for markdown files
Changes: https://gi
12 matches
Mail list logo
