Re: RFR: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure [v3]

2022-10-14 Thread Alisen Chung
On Tue, 11 Oct 2022 18:54:44 GMT, Damon Nguyen wrote: >> The previous change to AquaComboBoxUI had 1 pixel of overlap between the >> text field and the combo button. This caused a few pixels to darken >> sometimes when an editable combobox is displayed. Since this test passes >> sometimes and

Re: RFR: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails [v5]

2022-10-14 Thread Alexey Ivanov
On Fri, 14 Oct 2022 09:16:27 GMT, Prasanta Sadhukhan wrote: >> DefaultListSelectionModel.removeIndexInterva accepts `int` value which >> allows it to take in Integer.MAX_VALUE theoratically but it does calculation >> with that value which can results in IOOBE. >> Fix is to make sure the

Re: RFR: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails [v5]

2022-10-14 Thread Alexey Ivanov
On Fri, 14 Oct 2022 09:16:27 GMT, Prasanta Sadhukhan wrote: >> DefaultListSelectionModel.removeIndexInterva accepts `int` value which >> allows it to take in Integer.MAX_VALUE theoratically but it does calculation >> with that value which can results in IOOBE. >> Fix is to make sure the

Integrated: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks

2022-10-14 Thread Nikita Provotorov
On Mon, 26 Sep 2022 17:36:04 GMT, Nikita Provotorov wrote: > Hi there! > JetBrains has faced with a bug on Apple M2 MacBooks when tapping (_not_ > pressing) with two fingers on a trackpad generates wrong mouse modifiers > (which are returned by >

Re: RFR: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks

2022-10-14 Thread Nikita Provotorov
On Mon, 3 Oct 2022 20:38:43 GMT, Phil Race wrote: >> I don't have an M2 device to check, but I think (judging to the code) if we >> add `jmodifiers == 0` check here then users making a tap holding the Control >> will receive the mouse events with `modifiers` == `CTRL_DOWN_MASK | >>

RFR: 8295248: JEditorPane HTML form with multi selection broke drawing after reseting

2022-10-14 Thread Toshio Nakamura
When JEditorPane shown HTML form with multi-selection, the reset operation broke its drawing. There are two issues. The current method `OptionListModel.removeIndexInterval()` disabled selections, but it didn't fire the change. Then, no re-drawing. Another issue is the method works as remove

Re: RFR: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails [v5]

2022-10-14 Thread Prasanta Sadhukhan
> DefaultListSelectionModel.removeIndexInterva accepts `int` value which allows > it to take in Integer.MAX_VALUE theoratically but it does calculation with > that value which can results in IOOBE. > Fix is to make sure the calculation stays within bounds. Prasanta Sadhukhan has updated the

Re: RFR: 6616245: NullPointerException when using JFileChooser with a custom FileView [v4]

2022-10-14 Thread Tejesh R
On Fri, 14 Oct 2022 04:39:02 GMT, Tejesh R wrote: >>> Probably it will be good to automate it >> >> I've submitted [JDK-8295298](https://bugs.openjdk.org/browse/JDK-8295298): >> Automate javax/swing/JFileChooser/FileViewNPETest.java >> >>> … and cover the macOS? I do not see a reason why we

Re: RFR: 6616245: NullPointerException when using JFileChooser with a custom FileView [v2]

2022-10-14 Thread Tejesh R
On Mon, 10 Oct 2022 16:17:04 GMT, Alexey Ivanov wrote: >> Yeah, was not able to reproduce in macOS. > > You can set Metal L explicitly on macOS. Yeah, I checked it now and the issue is reproducible in macOS also, have to update the test to include macOS. Had thought that default L in macOS

Integrated: 7172359: HTML parser StackOverflowError on invalid HTML: tag inside an

2022-10-14 Thread Prasanta Sadhukhan
On Thu, 15 Sep 2022 08:05:29 GMT, Prasanta Sadhukhan wrote: > If there is invalid tag, stack terminates but it still tries to recurse > through by calling legalElementContext() which results in StackOverflowError. > Fix is to return if stack is terminated after checking current tag is not >

Re: RFR: 7172359: HTML parser StackOverflowError on invalid HTML: tag inside an [v4]

2022-10-14 Thread Prasanta Sadhukhan
> If there is invalid tag, stack terminates but it still tries to recurse > through by calling legalElementContext() which results in StackOverflowError. > Fix is to return if stack is terminated after checking current tag is not > valid in current context > > All other test/html/parser as well

RFR: 8295323: Unnecessary HashTable usage in StyleSheet

2022-10-14 Thread Andrey Turbanov
Hashtable was used only from single thread. And only non-null key/values added to it. We can safely replace it with HashSet. - Commit messages: - [PATCH] Unnecessary HashTable usage in StyleSheet Changes: https://git.openjdk.org/jdk/pull/10522/files Webrev:

Re: RFR: 8295323: Unnecessary HashTable usage in StyleSheet

2022-10-14 Thread SWinxy
On Sat, 1 Oct 2022 16:53:17 GMT, Andrey Turbanov wrote: > Hashtable was used only from single thread. And only non-null key/values > added to it. We can safely replace it with HashSet. src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java line 1364: > 1362:

Integrated: 8295026: Remove unused fields in StyleSheet

2022-10-14 Thread Andrey Turbanov
On Sat, 1 Oct 2022 17:05:11 GMT, Andrey Turbanov wrote: > There are 3 unused fields in single `StyleSheet` file: > 1. `static final Border noBorder = new EmptyBorder(0,0,0,0);` > 2. `static final int DEFAULT_FONT_SIZE = 3;` > 3. `URL imageurl;` in nested