RFR: 6201035: Undefined behavior of MatteBorder Ctors

2022-10-17 Thread Prasanta Sadhukhan
The behavior of MatteBorder constructors taking Insets object as a parameter is undocumented. It would throw NPE if null object is passed to it, which should be documented in the spec. - Commit messages: - 6201035: Undefined behavior of MatteBorder Ctors Changes: https://git.openj

Integrated: JDK-6229853: BasicTextAreaUI:create incompletely documents the possible returned View types

2022-10-17 Thread Prasanta Sadhukhan
On Wed, 21 Sep 2022 12:25:48 GMT, Prasanta Sadhukhan wrote: > API specification says about BasicTextAreaUI.create "Returns a > WrappedPlainView or PlainView". > But for > [bidi](https://github.com/openjdk/jdk/blob/d14e96d9701dae951aa365029f58afb6687a646a/src/java.desktop/share/classes/javax/s

Re: RFR: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails [v6]

2022-10-17 Thread Prasanta Sadhukhan
On Tue, 18 Oct 2022 04:56:07 GMT, Prasanta Sadhukhan wrote: >> DefaultListSelectionModel.removeIndexInterva accepts `int` value which >> allows it to take in Integer.MAX_VALUE theoratically but it does calculation >> with that value which can results in IOOBE. >> Fix is to make sure the calcul

Re: RFR: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails [v6]

2022-10-17 Thread Prasanta Sadhukhan
> DefaultListSelectionModel.removeIndexInterva accepts `int` value which allows > it to take in Integer.MAX_VALUE theoratically but it does calculation with > that value which can results in IOOBE. > Fix is to make sure the calculation stays within bounds. Prasanta Sadhukhan has updated the pull

Integrated: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure

2022-10-17 Thread Damon Nguyen
On Mon, 10 Oct 2022 05:26:23 GMT, Damon Nguyen wrote: > The previous change to AquaComboBoxUI had 1 pixel of overlap between the text > field and the combo button. This caused a few pixels to darken sometimes when > an editable combobox is displayed. Since this test passes sometimes and fails

RFR: 8295429: Update harfbuzz md file

2022-10-17 Thread Damon Nguyen
Update the harfbuzz md file with the newly generated md file. Matched format of previous license and organized copyright lines. - Commit messages: - Update md file Changes: https://git.openjdk.org/jdk/pull/10735/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10735&range=00

Re: RFR: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks

2022-10-17 Thread Sergey Bylokhov
On Mon, 26 Sep 2022 17:36:04 GMT, Nikita Provotorov wrote: > Hi there! > JetBrains has faced with a bug on Apple M2 MacBooks when tapping (_not_ > pressing) with two fingers on a trackpad generates wrong mouse modifiers > (which are returned by > [MouseEvent.getModifiersEx](https://docs.oracle

Re: RFR: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure [v2]

2022-10-17 Thread Damon Nguyen
On Tue, 11 Oct 2022 06:30:52 GMT, Jayathirth D V wrote: >> Damon Nguyen has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge branch 'master' into 8294254/overlapFixEditableCombobox >> - Merge branch 'openj