RFR: 8295006: Colored text is not shown on disabled checkbox and radiobutton with GTK LAF for bug4314194

2022-10-18 Thread Abhishek Kumar
Existing test `open/test/jdk/javax/swing/JRadioButton/4314194/bug4314194.java` was not showing colored text for disabled checkbox and radiobutton in GTK LAF. The fix is to get the disabled state color for checkbox and radiobutton from UIManager if it exists. Test case `open/test/jdk/javax/swin

Re: RFR: 8295429: Update harfbuzz md file [v2]

2022-10-18 Thread Alexander Zvegintsev
On Tue, 18 Oct 2022 21:55:20 GMT, Damon Nguyen wrote: >> Update the harfbuzz md file with the newly generated md file. Matched format >> of previous license and organized copyright lines. > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last rev

RFR: 8294466: Minimize disabled warnings in java.desktop

2022-10-18 Thread Magnus Ihse Bursie
After JDK-8294281, it is now possible to disable warnings for individual files instead for whole libraries. I used this opportunity to go through all disabled warnings in java.desktop native libraries. Any warnings that were only triggered in a few files were removed from the library as a whole

Re: RFR: 8295429: Update harfbuzz md file [v2]

2022-10-18 Thread Damon Nguyen
> Update the harfbuzz md file with the newly generated md file. Matched format > of previous license and organized copyright lines. Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Add copyrights. Add license path. - Cha

Re: RFR: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails [v6]

2022-10-18 Thread Alexey Ivanov
On Tue, 18 Oct 2022 04:56:07 GMT, Prasanta Sadhukhan wrote: >> DefaultListSelectionModel.removeIndexInterva accepts `int` value which >> allows it to take in Integer.MAX_VALUE theoratically but it does calculation >> with that value which can results in IOOBE. >> Fix is to make sure the calcul

Re: RFR: 8295470: Update openjdk.java.net => openjdk.org URLs in test code

2022-10-18 Thread Joe Darcy
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote: > This is a continuation of the effort to update all our URLs to the new > top-level domain. > > This patch updates (most) URLs in testing code. There still exists references > to openjdk.java.net, but that are not strictly used as no

Integrated: 8285306: Fix typos in java.desktop

2022-10-18 Thread Magnus Ihse Bursie
On Thu, 21 Apr 2022 08:35:36 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on the `src/java.desktop` directory, and accepted those > changes where it indeed discovered real typos. > > I ignored typos in public methods and variables. Maybe they can be fixed > later on without much fanfare,

Re: RFR: 8295470: Update openjdk.java.net => openjdk.org URLs in test code

2022-10-18 Thread Phil Race
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote: > This is a continuation of the effort to update all our URLs to the new > top-level domain. > > This patch updates (most) URLs in testing code. There still exists references > to openjdk.java.net, but that are not strictly used as no

Re: RFR: 8285306: Fix typos in java.desktop [v11]

2022-10-18 Thread Phil Race
On Wed, 12 Oct 2022 11:24:17 GMT, Magnus Ihse Bursie wrote: >> I ran `codespell` on the `src/java.desktop` directory, and accepted those >> changes where it indeed discovered real typos. >> >> I ignored typos in public methods and variables. Maybe they can be fixed >> later on without much fan

Re: RFR: 8295470: Update openjdk.java.net => openjdk.org URLs in test code

2022-10-18 Thread Michael McMahon
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote: > This is a continuation of the effort to update all our URLs to the new > top-level domain. > > This patch updates (most) URLs in testing code. There still exists references > to openjdk.java.net, but that are not strictly used as no

Re: RFR: 8295470: Update openjdk.java.net => openjdk.org URLs in test code

2022-10-18 Thread Magnus Ihse Bursie
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote: > This is a continuation of the effort to update all our URLs to the new > top-level domain. > > This patch updates (most) URLs in testing code. There still exists references > to openjdk.java.net, but that are not strictly used as no

RFR: 8295470: Update openjdk.java.net => openjdk.org URLs in test code

2022-10-18 Thread Magnus Ihse Bursie
This is a continuation of the effort to update all our URLs to the new top-level domain. This patch updates (most) URLs in testing code. There still exists references to openjdk.java.net, but that are not strictly used as normal URLs, which I deemed need special care, so I left them out of this

Integrated: 7175397: The divider color is not changed to green when dragging for Nimbus LaF.

2022-10-18 Thread Prasanta Sadhukhan
On Fri, 19 Aug 2022 07:40:13 GMT, Prasanta Sadhukhan wrote: > SplitPaneDivider.draggingColor UIProperty was not honoured in Nimbus L&F. > Added support for setting SplitPane dragging color for Nimbus L&F by drawing > a fillRect of the set color as done in BasicLookAndFeel. > The fix relies on

Re: RFR: 7175397: The divider color is not changed to green when dragging for Nimbus LaF. [v4]

2022-10-18 Thread Jayathirth D V
On Mon, 17 Oct 2022 06:13:35 GMT, Prasanta Sadhukhan wrote: >> SplitPaneDivider.draggingColor UIProperty was not honoured in Nimbus L&F. >> Added support for setting SplitPane dragging color for Nimbus L&F by drawing >> a fillRect of the set color as done in BasicLookAndFeel. >> The fix relies