On Mon, 24 Oct 2022 04:27:15 GMT, Phil Race wrote:
>> Toshio Nakamura has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed space
>
> Can you try again to describe the issue ?
> The bug summary is misleading I'm sure. "Drawing" as in RE
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote:
> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
> the files in that folder appear in the jdk bundle after installation like the
> "jawt.h".
Thank you for waiting while we sorted out the details. This looks go
On Sat, 1 Oct 2022 16:53:17 GMT, Andrey Turbanov wrote:
> Hashtable was used only from single thread. And only non-null key/values
> added to it. We can safely replace it with HashSet.
So I think this is OK, but please be sure you have run at least the related
Swing jtreg tests
-
On Mon, 24 Oct 2022 10:15:53 GMT, Alexey Ivanov wrote:
>> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
>> the files in that folder appear in the jdk bundle after installation like
>> the "jawt.h".
>
> Marked as reviewed by aivanov (Reviewer).
@aivanov-jdk has prep
On Mon, 24 Oct 2022 19:39:21 GMT, Jonathan Gibbons wrote:
> I think it would be better to try and remove incidental trailing whitespace
> first, before encoding any remaining whitespace. Hiding the trailing
> whitespace as a Unicode escape seems like a bad idea, equivalent to sweeping
> the is
On Mon, 24 Oct 2022 20:01:26 GMT, Magnus Ihse Bursie wrote:
> [JDK-8294466](https://bugs.openjdk.org/browse/JDK-8294466) trimmed down the
> set of disabled warnings. Unfortunately it turned out that running slowdebug
> on linux on Oracle's CI triggered yet another warning in libsplashscreen.
T
On Mon, 24 Oct 2022 20:01:26 GMT, Magnus Ihse Bursie wrote:
> [JDK-8294466](https://bugs.openjdk.org/browse/JDK-8294466) trimmed down the
> set of disabled warnings. Unfortunately it turned out that running slowdebug
> on linux on Oracle's CI triggered yet another warning in libsplashscreen.
T
On Mon, 24 Oct 2022 20:01:26 GMT, Magnus Ihse Bursie wrote:
> [JDK-8294466](https://bugs.openjdk.org/browse/JDK-8294466) trimmed down the
> set of disabled warnings. Unfortunately it turned out that running slowdebug
> on linux on Oracle's CI triggered yet another warning in libsplashscreen.
M
On Mon, 24 Oct 2022 20:08:02 GMT, Andy Goryachev wrote:
> Good idea! I wonder if this should be done as a unit test. go through all the
> bundles and check leading/trailing whitespace.
Right. Definitely not a job for `jcheck`, but it should be considered somewhere
in the l10n process.
---
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote:
> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
> the files in that folder appear in the jdk bundle after installation like the
> "jawt.h".
I suggest to disable that test, if it builds during the jdk build as
On Mon, 24 Oct 2022 19:58:31 GMT, Naoto Sato wrote:
> I think what we can do is check the original English properties values that
> the engineers provided, and if there is no trailing spaces there, we can
> safely remove trailing spaces in localized bundles.
Good idea! I wonder if this should
[JDK-8294466](https://bugs.openjdk.org/browse/JDK-8294466) trimmed down the set
of disabled warnings. Unfortunately it turned out that running slowdebug on
linux on Oracle's CI triggered yet another warning in libsplashscreen.
-
Commit messages:
- 8295847: slow debug build error af
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 24 Oct 2022 19:23:04 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert "Remove check for .properties from jcheck"
>>
>>This reverts commit c91fdaa19dc06351598bd1c061
On Mon, 24 Oct 2022 19:34:56 GMT, Magnus Ihse Bursie wrote:
> For the files which have trailing "whitespace" (now as unicode sequences), I
> will file follow-up bugs on the respective components to verify if this is
> indeed correct, or a bug that should be fixed.
probably not needed - if nobo
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 24 Oct 2022 19:20:24 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove check for .properties from jcheck
>> - Restore trailing whitespace for property values
>
> 368 files
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the coverage of the
> whitespace checks (in the old mercurial ve
On Thu, 20 Oct 2022 19:50:38 GMT, Alexey Ivanov wrote:
> This automates the test added in #9327.
>
> The test has a set of objects which store the size of the file and the
> expected displayed size, the file name is generated automatically. The
> pattern for the file names ensures the files ar
On Thu, 20 Oct 2022 19:31:27 GMT, Alexey Ivanov wrote:
> The automated test follows the instructions of the manual test that was added
> in #10485.
>
> Instead of selecting the parent folder from the **Look in** combo box, it
> calls `setCurrentDirectory` directly with the parent of the path w
On Sat, 1 Oct 2022 16:53:17 GMT, Andrey Turbanov wrote:
> Hashtable was used only from single thread. And only non-null key/values
> added to it. We can safely replace it with HashSet.
src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java line 1424:
> 1422: @SuppressWarn
On Sat, 1 Oct 2022 16:53:17 GMT, Andrey Turbanov wrote:
> Hashtable was used only from single thread. And only non-null key/values
> added to it. We can safely replace it with HashSet.
Looks good to me. All tests pass.
-
Marked as reviewed by aivanov (Reviewer).
PR: https://git.o
On Wed, 19 Oct 2022 15:33:31 GMT, Archie L. Cobbs wrote:
> Building on MacOS 12.6 M1 with Xcode 14.0 fails due to C compiler unused
> parameter warnings:
>
> Creating support/modules_libs/java.desktop/libosx.dylib from 1 file(s)
This pull request has been closed without being integrated.
On Wed, 19 Oct 2022 15:33:31 GMT, Archie L. Cobbs wrote:
> Building on MacOS 12.6 M1 with Xcode 14.0 fails due to C compiler unused
> parameter warnings:
>
> Creating support/modules_libs/java.desktop/libosx.dylib from 1 file(s)
OK thanks.
-
PR: https://git.openjdk.org/jdk/pull/1
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote:
> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
> the files in that folder appear in the jdk bundle after installation like the
> "jawt.h".
Marked as reviewed by aivanov (Reviewer).
-
PR: https:
On Thu, 20 Oct 2022 10:24:28 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in the accessibility native code.
>
> Any warnings that were
On Sun, 23 Oct 2022 00:37:55 GMT, Phil Race wrote:
> > > Can you please refrain from integrating this while I investigate while
> > > this was originally moved?
> >
> >
> > sure.
>
> It was moved because it was designed for use by AWT and SOMEHOW during all
> the reshuffle for the modular JD
On Thu, 20 Oct 2022 10:36:08 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in java.desktop native libraries.
>
> Any warnings that were
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote:
> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
> the files in that folder appear in the jdk bundle after installation like the
> "jawt.h".
Marked as reviewed by kizune (Reviewer).
-
PR: https:/
On Sun, 23 Oct 2022 01:22:33 GMT, Phil Race wrote:
> Superficially, it looks like the closed test has a direct pointer to where to
> get this which would need to be re-adjusted
The test has direct link to the include yet i had to add this line so jtreg
could find it in the build phase. The fac
35 matches
Mail list logo
