On Wed, 26 Oct 2022 10:28:21 GMT, Prasanta Sadhukhan
wrote:
> If getDefaultEditor() is called before the JTable model is setup, it results
> in NPE.
>
> This is because when JTable sets its model, which ends up firing a table
> changed event. The testcase is listening for tableChanged events
On Thu, 27 Oct 2022 22:41:26 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/classes/javax/swing/border/MatteBorder.java line 79:
>>
>>> 77: * @param matteColor the color rendered for the border
>>> 78: * @throws {@code NullPointerException} if {@code borderInsets}
>>> 79: *
> The behavior of MatteBorder constructors taking Insets object as a parameter
> is undocumented. It would throw NPE if null object is passed to it, which
> should be documented in the spec.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last
On Fri, 28 Oct 2022 03:32:18 GMT, Prasanta Sadhukhan
wrote:
>> DefaultListSelectionModel.removeIndexInterva accepts `int` value which
>> allows it to take in Integer.MAX_VALUE theoratically but it does calculation
>> with that value which can results in IOOBE.
>> Fix is to make sure the calcul
> DefaultListSelectionModel.removeIndexInterva accepts `int` value which allows
> it to take in Integer.MAX_VALUE theoratically but it does calculation with
> that value which can results in IOOBE.
> Fix is to make sure the calculation stays within bounds.
Prasanta Sadhukhan has updated the pull
On Fri, 7 Oct 2022 12:51:26 GMT, Alan Bateman wrote:
>> Michael Ernst has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Reinstate typos in Apache code that is copied into the JDK
>> - Merge ../jdk-openjdk into
On Wed, 19 Oct 2022 07:13:44 GMT, Abhishek Kumar wrote:
>> Existing test
>> `open/test/jdk/javax/swing/JRadioButton/4314194/bug4314194.java` was not
>> showing colored text for disabled checkbox and radiobutton in GTK LAF.
>>
>> The fix is to get the disabled state color for checkbox and radio
On Sat, 15 Oct 2022 13:03:26 GMT, Andrey Turbanov wrote:
> Test failed on Ubuntu, because both implementations of `MixerProvider` have
> no devices:
> 1. com.sun.media.sound.DirectAudioDeviceProvider#nGetNumDevices returns `0`
> .
@Renjithkannath you need to begin the comment with `/covered`. Could y
Updated the documentation with proper meaningful message for better
understanding.
-
Commit messages:
- JDK-8252075 : Documentation error in LayoutManager2 interface
Changes: https://git.openjdk.org/jdk/pull/10549/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10549&range=
The Java2d do not use "half" float in the image layouts, so we can disable it
in the LittleCMS library during the build. It is possible to do using
[this](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/liblcms/lcms2.h#L85)
public option:
// Uncomment to get rid of the
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote:
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
> to parse or construct any URL.
>
> The `java.net.URL` class does not itself encode or decode any URL components
> according to the escaping mechanism defined in
On Wed, 12 Oct 2022 16:41:52 GMT, Rajat Mahajan wrote:
> This fix is based on a similar approach as described here
> https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648.
> We rescale the line border to render the Textfield border correctly, so that
> all sides of the Textfield bor
On Sat, 1 Oct 2022 16:53:17 GMT, Andrey Turbanov wrote:
> Hashtable was used only from single thread. And only non-null key/values
> added to it. We can safely replace it with HashSet.
This pull request has now been integrated.
Changeset: 907d5833
Author:Andrey Turbanov
URL:
https:
On Thu, 27 Oct 2022 17:50:37 GMT, Andrey Turbanov wrote:
>> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
>> to parse or construct any URL.
>>
>> The `java.net.URL` class does not itself encode or decode any URL components
>> according to the escaping mechanism de
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote:
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
> to parse or construct any URL.
>
> The `java.net.URL` class does not itself encode or decode any URL components
> according to the escaping mechanism defined in
On Thu, 27 Oct 2022 17:20:04 GMT, Joe Wang wrote:
> Hi Daniel, if it's not a major improvement, we'd like to keep the java.xml
> module at the JDK 8 code level. Can we remove the 'var' usage in a few
> java.xml classes?
No problem - I will make this change when we have settled on a name for th
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote:
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
> to parse or construct any URL.
>
> The `java.net.URL` class does not itself encode or decode any URL components
> according to the escaping mechanism defined in
On Wed, 26 Oct 2022 10:48:48 GMT, Prasanta Sadhukhan
wrote:
>> The behavior of MatteBorder constructors taking Insets object as a parameter
>> is undocumented. It would throw NPE if null object is passed to it, which
>> should be documented in the spec.
>
> Prasanta Sadhukhan has updated the p
On Wed, 26 Oct 2022 10:48:48 GMT, Prasanta Sadhukhan
wrote:
>> The behavior of MatteBorder constructors taking Insets object as a parameter
>> is undocumented. It would throw NPE if null object is passed to it, which
>> should be documented in the spec.
>
> Prasanta Sadhukhan has updated the p
On Thu, 27 Oct 2022 09:17:29 GMT, Michael McMahon wrote:
>> Having unnamed local variables[^1] would probably be best for this.
>>
>> [^1]: https://openjdk.org/jeps/8294349
>
> How about `_unused` or `_unused1`, `_unused2` then in the meantime?
I'd be happy to make the change. Let's wait to see
On Wed, 11 May 2022 12:49:34 GMT, Artem Semenov wrote:
>> A11Y implementation on macOS has to directly call the
>> 'JList.setSelectedIndex' method in order to request selection on an item
>> (see 'CAccessibility.requestSelection'). The reason is that a11y API lacks
>> appropriate method.There'
On Thu, 27 Oct 2022 09:27:00 GMT, Prasanta Sadhukhan
wrote:
> > > Can you also please test it works ok (or atleast not regress) for other
> > > selection mode FILES_ONLY, DIRECTORIES_ONLY in the test?
> >
> >
> > Verified for file selection mode of `DIRECTORIES_ONLY`, test passed for all
> >
On Thu, 27 Oct 2022 08:37:48 GMT, Abhishek Kumar wrote:
> > Can you also please test it works ok (or atleast not regress) for other
> > selection mode FILES_ONLY, DIRECTORIES_ONLY in the test?
>
> Verified for file selection mode of `DIRECTORIES_ONLY`, test passed for all
> LAFs.
>
> In case
On Thu, 27 Oct 2022 05:14:19 GMT, ExE Boss wrote:
>> src/java.base/share/classes/java/net/JarURLConnection.java line 177:
>>
>>> 175: @SuppressWarnings("deprecation")
>>> 176: var tmp = jarFileURL = new URL(spec.substring(0, separator++));
>>> 177:
>>
>> I realise that @Suppres
On Thu, 27 Oct 2022 05:48:53 GMT, Prasanta Sadhukhan
wrote:
> Also, please see if
> [JDK-4912623](https://bugs.openjdk.org/browse/JDK-4912623) is related and
> fixed by this?
Ok, I will check.
-
PR: https://git.openjdk.org/jdk/pull/10866
On Thu, 27 Oct 2022 04:00:35 GMT, Prasanta Sadhukhan
wrote:
> Can you also please test it works ok (or atleast not regress) for other
> selection mode FILES_ONLY, DIRECTORIES_ONLY in the test?
Verified for file selection mode of `DIRECTORIES_ONLY`, test passed for all
LAFs.
In case of select
> While using a JFileChooser with the file selection mode FILES_AND_DIRECTORIES
> and multiSelection enabled, it is impossible to select a single directory in
> GTK LAF.
>
> The condition check has been modified when multiselection is enabled and user
> has selected single directory.
> After th
29 matches
Mail list logo
