RFR: 8296905: Replace the native LCMS#getProfileID() method with the accessor

2022-11-11 Thread Sergey Bylokhov
The native method used to access the private method in the `ICC_Profile` class is replaced by the accessor. - Commit messages: - 8296905: Replace the native LCMS#getProfileID() method with the accessor Changes: https://git.openjdk.org/jdk/pull/6/files Webrev:

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2022-11-11 Thread Sergey Bylokhov
On Fri, 11 Nov 2022 09:12:21 GMT, Artem Semenov wrote: >> src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java line >> 574: >> >>> 572: return; >>> 573: } >>> 574: as.addAccessibleSelection(i); >> >> I would like to clarify

Re: RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

2022-11-11 Thread Sergey Bylokhov
On Fri, 11 Nov 2022 04:01:17 GMT, Prasanta Sadhukhan wrote: >> Please recheck, setLocationRelativeTo() calculates the location based on the >> size of the current frame, which is wrong before the pack. I just run it and >> the frame is sifted to the right part of the screen. > > WHich

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-11 Thread lawrence . andrews
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 8296546: Add @spec tags to API

2022-11-11 Thread Lance Andersen
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote: > Please review a "somewhat automated" change to insert `@spec` tags into doc > comments, as appropriate, to leverage the recent new javadoc feature to > generate a new page listing the references to all external specifications >

Re: RFR: 8296546: Add @spec tags to API

2022-11-11 Thread Daniel Fuchs
On Fri, 11 Nov 2022 11:45:43 GMT, Lance Andersen wrote: > It would probably be easier for the reviewers and for you if the PR could be > broken out by areas into separate PRs Leaving out the non-public and non-exported classes would also reduce the PR size. - PR:

Re: RFR: 8296546: Add @spec tags to API

2022-11-11 Thread Daniel Fuchs
On Thu, 10 Nov 2022 21:56:26 GMT, Jonathan Gibbons wrote: > On the same text but linking to different RFCs: that's tantamount to a bug > somewhere. The spec for `@spec` dictates that the URLs and titles should be > in 1-1 correspondence, and this is supposed to be enforced in the docket. In >

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-11 Thread Manukumar V S
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2022-11-11 Thread Artem Semenov
On Fri, 11 Nov 2022 02:16:15 GMT, Sergey Bylokhov wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> We are not using author tags in tests either - but that's just a nitpick. > >

RFR: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null'

2022-11-11 Thread Tejesh R
Observation found when JFileChooser is instantiated in WindowsLookAndFeel which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find the exact root cause so predicting it to be an issue with icons not loaded where resolutionVariants map is empty in _public Image

Re: RFR: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

2022-11-11 Thread Tejesh R
On Thu, 10 Nov 2022 06:00:27 GMT, Tejesh R wrote: > Observation found when _JFileChooser_ is instantiated in _WindowsLookAndFeel_ > which invokes _getSystemIcon()_ from WindowsFileChooserUI class. Could not > find the exact root cause so predicting it to be an issue with icons not > loaded

Withdrawn: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

2022-11-11 Thread Tejesh R
On Thu, 10 Nov 2022 06:00:27 GMT, Tejesh R wrote: > Observation found when _JFileChooser_ is instantiated in _WindowsLookAndFeel_ > which invokes _getSystemIcon()_ from WindowsFileChooserUI class. Could not > find the exact root cause so predicting it to be an issue with icons not > loaded

Re: RFR: 8295779: Xcode 14.0 fails to build jdk on m1 macos

2022-11-11 Thread Lutz Schmidt
On Wed, 19 Oct 2022 15:33:31 GMT, Archie L. Cobbs wrote: > Building on MacOS 12.6 M1 with Xcode 14.0 fails due to C compiler unused > parameter warnings: > > Creating support/modules_libs/java.desktop/libosx.dylib from 1 file(s) This is a moving target, and the changes depend on the build

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-11 Thread ravi gupta
> This testcase Verify the content changes of a TextArea for the following > assertions. > > a. TextListener get invoked when the content of a TextArea gets changed. > b. TextListener not get invoked during text selection or when Special keys > such as Function Keys are pressed. > > >