Re: RFR: 8296905: Replace the native LCMS#getProfileID() method with the accessor [v2]

2022-11-19 Thread Sergey Bylokhov
On Mon, 14 Nov 2022 08:03:40 GMT, Sergey Bylokhov wrote: >> src/java.desktop/share/classes/sun/awt/AWTAccessor.java line 891: >> >>> 889: */ >>> 890: public static ICC_ProfileAccessor getICC_ProfileAccessor() { >>> 891: if (iccProfileAccessor == null) { >> >> For

Re: RFR: 8296905: Replace the native LCMS#getProfileID() method with the accessor [v2]

2022-11-19 Thread Sergey Bylokhov
> The native method used to access the private method in the `ICC_Profile` > class is replaced by the accessor. Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Re: RFR: 8165943: LineBreakMeasurer does not measure correctly if TextAttribute.TRACKING is set.

2022-11-19 Thread Phil Race
On Thu, 15 Sep 2022 16:51:27 GMT, Olga Mikhaltsova wrote: > This is a fix for LineBreakMeasurer. It takes into account the > TextAttribute.TRACKING value (not eq 0) while calculating the line breaks. > > Tested on Linux x64, Windows x64, macOS x64 with the reproducer > (LineBreakSample.java)

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v4]

2022-11-19 Thread Sergey Bylokhov
On Mon, 14 Nov 2022 11:07:56 GMT, Artem Semenov wrote: >> Probably because of the endless notifications loop? implementation of >> addSelectionInterval looks similar to setSelectionInterval. In some cases >> the addSelectionInterval just call setSelectionInterval. > > It looks like it is.

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v3]

2022-11-19 Thread Laurent Bourgès
On Sat, 19 Nov 2022 01:43:59 GMT, Phil Race wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added HugePolygonClipTest > > src/java.desktop/share/classes/sun/java2d/marlin/MarlinProperties.java line > 87: > >>

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v3]

2022-11-19 Thread Laurent Bourgès
> Initial PR Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: added HugePolygonClipTest - Changes: - all: https://git.openjdk.org/jdk/pull/11225/files - new:

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v2]

2022-11-19 Thread Laurent Bourgès
> Initial PR Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: fixed typos - Changes: - all: https://git.openjdk.org/jdk/pull/11225/files - new: https://git.openjdk.org/jdk/pull/11225/files/4516b8de..86364d55