Re: RFR: 8296812: sprintf is deprecated in Xcode 14

2022-11-20 Thread David Holmes
On Mon, 21 Nov 2022 06:14:44 GMT, Xue-Lei Andrew Fan wrote: >> Please don't add uses of `jio_snprintf` or `::snprintf` to hotspot. Use >> `os::snprintf`. >> >> Regarding `jio_snprintf`, see https://bugs.openjdk.org/browse/JDK-8198918. >> Regarding `os::snprintf` and `os::vsnprintf`, see >> htt

Re: RFR: 8296812: sprintf is deprecated in Xcode 14

2022-11-20 Thread Xue-Lei Andrew Fan
On Sun, 13 Nov 2022 20:48:04 GMT, Kim Barrett wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that use spri

Re: RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem [v6]

2022-11-20 Thread Naveen Narayanan
> This testcase will > 1) Verify setAccelerator method of JMenuitem. > 2) Check that the selection of a menu item in the menu bar will generate > action by a key combination of META+M. > > Testing: > Tested using Mach5(20 times per platform) in Mac OS, Linux and Windows and > got all pass. Nave

Re: RFR: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java

2022-11-20 Thread Jayathirth D V
On Fri, 18 Nov 2022 12:27:46 GMT, Jayathirth D V wrote: > This is follow up of > https://github.com/openjdk/jdk/pull/11158#discussion_r1025574199 > > I have added empty paint() and update() methods back for the frame in this > test. > Ran the test 20 times in our CI machines on all platforms.

Withdrawn: 8293478: [java.desktop/macOS] Condense SDRenderType usages in QuartzRenderer.m

2022-11-20 Thread duke
On Mon, 5 Sep 2022 23:41:40 GMT, SWinxy wrote: > The `SDRenderType` enum is often returned using a variable declared at the > start of functions. These can be inlined in the `return` itself. Using a > ternary operator condenses what may be 12 lines into one, in the most extreme > cases. `doRec

Re: RFR: JDK-8296661 : Fix typo

2022-11-20 Thread SWinxy
On Fri, 4 Nov 2022 01:56:05 GMT, ScientificWare wrote: > This is referenced in Java Bug Database as > - [JDK-8296661 : Fix > typo](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661) > > This is tracked in JBS as > - [JDK-8296661 : Fix typo](https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8297303: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all

2022-11-20 Thread Daniel D . Daugherty
On Sun, 20 Nov 2022 15:14:40 GMT, Alan Bateman wrote: >> A trivial fix to ProblemList >> java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all > > Marked as reviewed by alanb (Reviewer). @AlanBateman and @azvegint - Thanks for the fast reviews! - PR: https://git.openjdk

Integrated: 8297303: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all

2022-11-20 Thread Daniel D . Daugherty
On Sun, 20 Nov 2022 14:59:12 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all This pull request has now been integrated. Changeset: dd553101 Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk

Re: RFR: 8297303: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all

2022-11-20 Thread Alan Bateman
On Sun, 20 Nov 2022 14:59:12 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11252

Re: RFR: 8297303: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all

2022-11-20 Thread Alexander Zvegintsev
On Sun, 20 Nov 2022 14:59:12 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all Marked as reviewed by azvegint (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11252

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v3]

2022-11-20 Thread Laurent Bourgès
On Sun, 20 Nov 2022 11:15:33 GMT, Sergey Bylokhov wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added HugePolygonClipTest > > src/java.desktop/share/classes/sun/java2d/marlin/ArrayCacheDouble.java line > 51:

Re: RFR: JDK-8297230: Update Marlin2D to 0.9.4.6 [v3]

2022-11-20 Thread Sergey Bylokhov
On Sat, 19 Nov 2022 22:03:44 GMT, Laurent Bourgès wrote: >> Initial PR > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > added HugePolygonClipTest src/java.desktop/share/classes/sun/java2d/marlin/ArrayCacheDouble.java lin

RFR: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion

2022-11-20 Thread Sergey Bylokhov
The quality of the cmm library is increased since the bug was reported. This is the request to import the test from the bug description to improve the code coverage. - Commit messages: - 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion Changes: https://git.openjdk.org/jdk/pu