On Sun, 20 Nov 2022 09:10:48 GMT, Sergey Bylokhov wrote:
> The quality of the cmm library is increased since the bug was reported. This
> is the request to import the test from the bug description to improve the
> code coverage.
Looks good to me.
Test is verified in CI and passes on all
On Wed, 23 Nov 2022 02:06:43 GMT, Sergey Bylokhov wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed Review Comments: Removed redundant code
>
> test/jdk/java/awt/EventDispatchThread/InterruptEDTTest.java
On Thu, 17 Nov 2022 08:20:54 GMT, Jayathirth D V wrote:
> This test was failing because of timing or color difference issues.
> Updated test to:
>
> 1) Use EDT for UI drawing instead of manual synchronisation
> 2) Use Robot.waitForIdle before screen capture
> 3) Increase color tolerance delta
On Tue, 18 Oct 2022 06:36:49 GMT, Prasanta Sadhukhan
wrote:
> The behavior of MatteBorder constructors taking Insets object as a parameter
> is undocumented. It would throw NPE if null object is passed to it, which
> should be documented in the spec.
This pull request has now been
On Wed, 23 Nov 2022 02:16:31 GMT, Sergey Bylokhov wrote:
>> I tried calling clearSelection again instead of adding an interface:
>>
>> if (as == null) return;
>> if (pac.getAccessibleRole().equals(AccessibleRole.LIST)) {
>>
On Mon, 21 Nov 2022 10:44:43 GMT, Artem Semenov wrote:
>> It is unclear why the `setSelectionInterval `is actually any better than
>> `addAccessibleSelection`. Both have a similar implementation, in some
>> cases, the addSelectionInterval just calls setSelectionInterval, and seems
>> that
On Mon, 7 Nov 2022 07:28:02 GMT, Srinivas Mandalika
wrote:
>> 8295707: Create a regression test for JDK-7184401
>>
>> JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for
>> 7162144
>> Above bug got introduced due to a fix for
>>
On Mon, 21 Nov 2022 10:15:01 GMT, Laurent Bourgès wrote:
>> Initial PR
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fixed class header comment
Marked as reviewed by serb (Reviewer).
On Tue, 22 Nov 2022 05:33:21 GMT, Jayathirth D V wrote:
>> This test was failing because of timing or color difference issues.
>> Updated test to:
>>
>> 1) Use EDT for UI drawing instead of manual synchronisation
>> 2) Use Robot.waitForIdle before screen capture
>> 3) Increase color tolerance
Updated Metal Border code for JInternalFrame.
- Added instanceof check before casting Graphics to G2D.
- Replaced roundHalfDown with Region.clipRound()
-
Commit messages:
- removed unused import
- JIF MetalBorder update
Changes: https://git.openjdk.org/jdk/pull/11305/files
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed in the `@spec` tags.
>
> "Somewhat automated" means that
On Fri, 18 Nov 2022 00:17:47 GMT, Damon Nguyen wrote:
> This is an older test that failed intermittently but had a fix specifically
> for mac systems by adding key presses on mac only. This test still
> intermittently failed after this fix long ago and was problem listed.
>
> I ran this test
On Mon, 21 Nov 2022 17:28:58 GMT, Damon Nguyen wrote:
>> This is an older test that failed intermittently but had a fix specifically
>> for mac systems by adding key presses on mac only. This test still
>> intermittently failed after this fix long ago and was problem listed.
>>
>> I ran this
On Mon, 21 Nov 2022 01:22:49 GMT, Sergey Bylokhov wrote:
> Implementation of SAFE_SIZE_NEW_ARRAY2 in the `sizecalc.h` missed one cast to
> the size_t
This pull request has now been integrated.
Changeset: fb6c992f
Author:Sergey Bylokhov
URL:
On Tue, 22 Nov 2022 15:51:09 GMT, Abhishek Kumar wrote:
> The Backspace key doesn't lead to parent directory of current directory for
> JFileChooser in GTK LAF.
> Added the lazy input value in `GTKLookandFeel` and fix is working fine.
>
> Implemented a manual test to check BackSpace behavior
The Backspace key doesn't lead to parent directory of current directory for
JFileChooser in GTK LAF.
Added the lazy input value in `GTKLookandFeel` and fix is working fine.
Implemented a manual test to check BackSpace behavior for all installed LAF in
Linux platform.
The test mentioned in
On Thu, 17 Nov 2022 18:10:38 GMT, Sergey Bylokhov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 706:
>
>> 704: setModel(dm);
>>
> If getDefaultEditor() is called before the JTable model is setup, it results
> in NPE.
>
> This is because when JTable sets its model, which ends up firing a table
> changed event. The testcase is listening for tableChanged events and querying
> the editor. But the editor isn't installed
> If getDefaultEditor() is called before the JTable model is setup, it results
> in NPE.
>
> This is because when JTable sets its model, which ends up firing a table
> changed event. The testcase is listening for tableChanged events and querying
> the editor. But the editor isn't installed
I think it is good
reviewed
Le lun. 21 nov. 2022 à 16:08, azul-jf a écrit :
> On Sun, 20 Nov 2022 03:39:56 GMT, Phil Race wrote:
>
> >> This is a fix for LineBreakMeasurer. It takes into account the
> TextAttribute.TRACKING value (not eq 0) while calculating the line breaks.
> >>
> >> Tested
On Mon, 21 Nov 2022 17:28:58 GMT, Damon Nguyen wrote:
>> This is an older test that failed intermittently but had a fix specifically
>> for mac systems by adding key presses on mac only. This test still
>> intermittently failed after this fix long ago and was problem listed.
>>
>> I ran this
On Mon, 7 Nov 2022 07:28:02 GMT, Srinivas Mandalika
wrote:
>> 8295707: Create a regression test for JDK-7184401
>>
>> JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for
>> 7162144
>> Above bug got introduced due to a fix for
>>
On Thu, 17 Nov 2022 15:51:50 GMT, Alexander Zvegintsev
wrote:
> This test needs more stabilization:
>
> - The test can be easily hang by replacing iteration on
> `keycharHash.elements()` with `keycharHash.forEach((k, v) ->
> punchCtrlKey(robot, v));`
> I do not see any reason why we need a
On Fri, 18 Nov 2022 13:38:47 GMT, Matthias Baesken wrote:
> The image related test UnexpectedSourceImageSize test introduced with
> https://bugs.openjdk.org/browse/JDK-8264666
> sometimes times out on slow machines when fastdebug is used. This happens
> especially in 11 and 17; in 20 it seems
On Fri, 18 Nov 2022 19:25:32 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warnings are
>> disabled for codes that
25 matches
Mail list logo
