> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14 because of security concerns, and the
> use of it causing building failure. The build could pass if warnings are
> disabled for codes that use sprintf method. For the long run, the sprintf
> could be
Set the text caret to be visible but not blinking on the non-editable text area.
-
Commit messages:
- 4512626: Non-editable JTextArea provides no visual indication of keyboard
focus
Changes: https://git.openjdk.org/jdk/pull/11408/files
Webrev:
On Mon, 28 Nov 2022 20:01:31 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/classes/javax/imageio/spi/IIORegistry.java line 89:
>>
>>> 87: * categories (superinterfaces) to be used in the constructor.
>>> 88: */
>>> 89: private static final ArrayList> initialCategories =
On Sun, 27 Nov 2022 22:22:54 GMT, David Schlosnagle wrote:
>> Field `javax.imageio.spi.IIORegistry#initialCategories` is modified only in
>> `static {}` block, which makes it effectively final. Instead of legacy
>> synchronized `Vector` we can use non-threadsafe `ArrayList` here.
>
>
On Sun, 27 Nov 2022 17:51:15 GMT, Andrey Turbanov wrote:
> Field `javax.imageio.spi.IIORegistry#initialCategories` is modified only in
> `static {}` block, which makes it effectively final. Instead of legacy
> synchronized `Vector` we can use non-threadsafe `ArrayList` here.
Field `javax.imageio.spi.IIORegistry#initialCategories` is modified only in
`static {}` block, which makes it effectively final. Instead of legacy
synchronized `Vector` we can use non-threadsafe `ArrayList` here.
-
Commit messages:
- 8297750: Unnecessary Vector usage in
On Fri, 18 Nov 2022 21:13:29 GMT, Alexey Ivanov wrote:
>> Naveen Narayanan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8296275: Review comments fixed.
>
> Since the test has nothing to do with `Desktop` class it should be moved to
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14 because of security concerns, and the
> use of it causing building failure. The build could pass if warnings are
> disabled for codes that use sprintf method. For the long run, the sprintf
> could be
On Mon, 28 Nov 2022 22:11:13 GMT, Phil Race wrote:
> Please split the long line before pushing. Also you'll probably need to
> update the PR to match the new bug summary. ALWAYS consider if a bug summary
> is well written as part of the bug evaluation
PR description changed to match the bug
> The Backspace key doesn't lead to parent directory of current directory for
> JFileChooser in GTK LAF.
> Added the lazy input value in `GTKLookandFeel` and fix is working fine.
>
> Implemented a manual test to check BackSpace behavior for all installed LAF
> in Linux platform.
> The test
On Tue, 29 Nov 2022 02:04:32 GMT, Damon Nguyen wrote:
>> Test ran on all OS 100 times and passed. Test previously failed on macOS but
>> no longer reproducible. Added screen capture on moment of failure to have
>> more evidence of failures in the future (previously a runtime exception was
>>
On Thu, 24 Nov 2022 14:59:37 GMT, Prasanta Sadhukhan
wrote:
> This is in continuation with
> https://github.com/openjdk/jdk/commit/7133fc93e168f3671d048b2ae654f84ec289b98d
> fix done for [JDK-7172359](https://bugs.openjdk.org/browse/JDK-7172359)
> issue where fix was done to rectify invalid
On Thu, 3 Nov 2022 07:05:10 GMT, Prasanta Sadhukhan
wrote:
> When editing of a table cell is canceled, the function editingCanceled of the
> registered listener CellEditorListener is not called as actionPerformed on
> ESC key press was not notifying the "cancel" listeners.
> Fix is to handle
> When editing of a table cell is canceled, the function editingCanceled of the
> registered listener CellEditorListener is not called as actionPerformed on
> ESC key press was not notifying the "cancel" listeners.
> Fix is to handle "Cancel" action in actionPerformed() by forwarding the
>
On Mon, 28 Nov 2022 23:09:56 GMT, Phil Race wrote:
> Where are we at with making a diagnostic update to this code and the failing
> test(s) ?
It looks like the imageIcon were not loaded for _downloads_ folder, which might
be the cause for `retVal` getting null value instead of ImageIcon.
On Tue, 29 Nov 2022 00:05:18 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line
>> 267:
>>
>>> 265: }
>>> 266:
>>> 267: AffineTransform at = null;
>>
>> Because we'd no longer be causing a `ClassCastException`
> Test ran on all OS 100 times and passed. Test previously failed on macOS but
> no longer reproducible. Added screen capture on moment of failure to have
> more evidence of failures in the future (previously a runtime exception was
> thrown only).
Damon Nguyen has updated the pull request
On Tue, 11 Oct 2022 14:17:42 GMT, Manukumar V S wrote:
> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS
> machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as
> adding some stability improvements fixes the issue. It intermittently fails
> in CI
On Mon, 28 Nov 2022 23:07:12 GMT, SWinxy wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review changes
>
> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line
> 267:
>
>> 265:
On Thu, 17 Nov 2022 14:26:48 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy for
> some selected classes.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
> Here is how it would look like:
>
>
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>>
On Fri, 25 Nov 2022 01:34:26 GMT, Sergey Bylokhov wrote:
>> The native method used to access the private method in the `ICC_Profile`
>> class is replaced by the accessor.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a
> merge or a rebase. The incremental
On Fri, 11 Nov 2022 08:18:19 GMT, Tejesh R wrote:
> Observation found when JFileChooser is instantiated in WindowsLookAndFeel
> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find
> the exact root cause so predicting it to be an issue with icons not loaded
> where
On Mon, 28 Nov 2022 20:25:19 GMT, Harshitha Onkar wrote:
>> Updated Metal Border code for JInternalFrame.
>>
>> - Added instanceof check before casting Graphics to G2D.
>> - Replaced roundHalfDown with Region.clipRound()
>
> Harshitha Onkar has updated the pull request incrementally with one
On Sun, 27 Nov 2022 16:25:15 GMT, Abhishek Kumar wrote:
>> The Backspace key doesn't lead to parent directory of current directory for
>> JFileChooser in GTK LAF.
>> Added the lazy input value in `GTKLookandFeel` and fix is working fine.
>>
>> Implemented a manual test to check BackSpace
On Thu, 24 Nov 2022 14:59:37 GMT, Prasanta Sadhukhan
wrote:
> This is in continuation with
> https://github.com/openjdk/jdk/commit/7133fc93e168f3671d048b2ae654f84ec289b98d
> fix done for [JDK-7172359](https://bugs.openjdk.org/browse/JDK-7172359)
> issue where fix was done to rectify invalid
On Tue, 22 Nov 2022 03:15:55 GMT, Sergey Bylokhov wrote:
> The usage of DocumentFilter in the JPasswordField is excluded from the
> [JDK-8258373](https://bugs.openjdk.org/browse/JDK-8258373). That will be
> responsibility of the application to cleanup the password if DocumentFilter
> is set.
On Sat, 26 Nov 2022 02:58:15 GMT, Sergey Bylokhov wrote:
> The specification for the DataBuffer.TYPE_SHORT/TYPE_FLOAT/TYPE_DOUBLE
> mentioned that all of them are "Placeholder for future use" which is not true.
>
> They are used and it is possible to create the ComponentColorModel for each
>
On Tue, 22 Nov 2022 03:15:55 GMT, Sergey Bylokhov wrote:
> The usage of DocumentFilter in the JPasswordField is excluded from the
> [JDK-8258373](https://bugs.openjdk.org/browse/JDK-8258373). That will be
> responsibility of the application to cleanup the password if DocumentFilter
> is set.
The usage of DocumentFilter in the JPasswordField is excluded from the
[JDK-8258373](https://bugs.openjdk.org/browse/JDK-8258373). That will be
responsibility of the application to cleanup the password if DocumentFilter is
set.
-
Commit messages:
- Update
> Updated Metal Border code for JInternalFrame.
>
> - Added instanceof check before casting Graphics to G2D.
> - Replaced roundHalfDown with Region.clipRound()
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last revision:
review changes
On Mon, 28 Nov 2022 19:26:52 GMT, Alexey Ivanov wrote:
> This test is very similar to that in #11052: `TextField` vs `TextArea`
> ([JDK-8296632](https://bugs.openjdk.org/browse/JDK-8296632)).
>
> Is it possible to modify the test so that it runs twice for both components?
I agree with
On Thu, 24 Nov 2022 06:10:20 GMT, ravi gupta wrote:
>> This testcase Verify the content changes of a TextField for the following
>> assertions.
>>
>> a. TextListener get invoked when the content of a TextField gets changed.
>> b. TextListener not get invoked during text selection or when
> A printed content is truncated on macOS if the content paper size width
> larger than height with portrait orientation or width is less than height
> with landscape orientation.
>
> To reproduce the issue run the
>
> A printed content is truncated on macOS if the content paper size width
> larger than height with portrait orientation or width is less than height
> with landscape orientation.
>
> To reproduce the issue run the
>
On Thu, 24 Nov 2022 06:10:20 GMT, ravi gupta wrote:
>> This testcase Verify the content changes of a TextField for the following
>> assertions.
>>
>> a. TextListener get invoked when the content of a TextField gets changed.
>> b. TextListener not get invoked during text selection or when
On Sun, 27 Nov 2022 06:26:48 GMT, Sergey Bylokhov wrote:
> I have found that drawing the BufferedImage.4BYTE_ABGR_PRE to the
> INT_ARGB_PRE image caused java2d to do an additional conversion from/to ARGB
> format. That conversion is done via a native
>
On Tue, 27 Sep 2022 11:14:11 GMT, Nikita Gubarkov wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix italic and bold styles for colored outline glyphs
>
>
@YaaZ Could you merge with latest openjdk20 master
On Sun, 27 Nov 2022 16:25:15 GMT, Abhishek Kumar wrote:
>> The Backspace key doesn't lead to parent directory of current directory for
>> JFileChooser in GTK LAF.
>> Added the lazy input value in `GTKLookandFeel` and fix is working fine.
>>
>> Implemented a manual test to check BackSpace
On Wed, 9 Nov 2022 09:42:00 GMT, Artem Semenov wrote:
>> A11Y implementation on macOS has to directly call the
>> 'JList.setSelectedIndex' method in order to request selection on an item
>> (see 'CAccessibility.requestSelection'). The reason is that a11y API lacks
>> appropriate
On Fri, 25 Nov 2022 09:15:08 GMT, Matthias Baesken wrote:
> There are still a few places where GetPrimitiveArrayCritical calls miss the
> result check. This should be adjusted.
> A similar case was recently adjusted here :
> https://bugs.openjdk.org/browse/JDK-8297480
LGTM.
Client CI test run
On Sun, 27 Nov 2022 17:49:57 GMT, Michael Ernst wrote:
> Could someone who knows the undocumented ins and outs of creating JDK pull
> requests could split this pull request up into multiple PRs? Then it can be
> merged, rather than wasting all the effort that went into it.
I've raised
42 matches
Mail list logo
