On Wed, 7 Dec 2022 05:48:57 GMT, Tejesh R wrote:
> Disable functionality not working for JFileChooser. `public void
> setEnabled(boolean enabled)` functionality is overridden in JFileChooser
> class which enable/disable each sub-component of FileChooser.
> The added functionality is tested in
On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warnings are
>> disabled for codes that u
On Sun, 4 Dec 2022 22:17:55 GMT, Alexander Zuev wrote:
>> Add try/catch clause to ignore an exception since it is harmless for we
>> isolated
>> the massge data before passing it ro processor.
>> Add test case.
>
> Alexander Zuev has updated the pull request with a new target base due to a
> me
Disable functionality not working for JFileChooser. `public void
setEnabled(boolean enabled)` functionality is overridden in JFileChooser class
which enable/disable each sub-component of FileChooser.
The added functionality is tested in mach5 and no regression found. The fix
includes automated
On Tue, 6 Dec 2022 18:24:17 GMT, Phil Race wrote:
>>> src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c: In
>>> function 'allocateRasterArray':
>>> src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c:2944:73:
>>> error: 'roff[3]' may be used uninitialized in this
The MenuItemLayoutHelper.clearUsedParentClientProperties must be called
automatically when the DPI was changed.
Workaround added in the test for this bug is removed.
CI tests are ok.
-
Commit messages:
- 8244400: MenuItem may cache the size and did not update it when the screen
D
> I changed GCC toolchain from GCC6 to GCC8 on SLES12SP5 Linux s390x.
> I could see following errors:
>
> src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c: In
> function 'allocateRasterArray':
> src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c:2944:73:
> error
On Tue, 6 Dec 2022 23:06:25 GMT, Olga Mikhaltsova
wrote:
>> test/jdk/java/awt/font/LineBreakMeasurer/LineBreakWithTracking.java line 50:
>>
>>> 48:
>>> 49: private float textTracking = 0.0f;
>>> 50: private static String fontName = "Bitstream Cyberbit";
>>
>> Did you previously use this f
On Tue, 6 Dec 2022 22:26:38 GMT, Phil Race wrote:
>> Olga Mikhaltsova has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Deleted trailing whitespaces, added new line at the end
>
> test/jdk/java/awt/font/LineBreakMeasurer/LineBreakWithTrack
On Tue, 6 Dec 2022 22:13:47 GMT, Olga Mikhaltsova
wrote:
>> This is a fix for LineBreakMeasurer. It takes into account the
>> TextAttribute.TRACKING value (not eq 0) while calculating the line breaks.
>>
>> Tested on Linux x64, Windows x64, macOS x64 with the reproducer
>> (LineBreakSample.ja
On Thu, 1 Dec 2022 20:16:19 GMT, Phil Race wrote:
>> Olga Mikhaltsova has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix tracking for CJK, Arabic and Hebrew
>> - Manual test
>
> test/jdk/java/awt/font/LineBreakMeasurer/LineBreakWithT
> This is a fix for LineBreakMeasurer. It takes into account the
> TextAttribute.TRACKING value (not eq 0) while calculating the line breaks.
>
> Tested on Linux x64, Windows x64, macOS x64 with the reproducer
> (LineBreakSample.java) attached to JDK-8165943 and the following group of
> tests:
On Mon, 5 Dec 2022 19:52:00 GMT, Alisen Chung wrote:
>> Test was run on mac, windows, linux 50 times and passed after change
>> Before fix, test fails about once every 50 runs on linux and windows
>> platforms
>
> Alisen Chung has updated the pull request with a new target base due to a
> merge
On Tue, 6 Dec 2022 21:38:45 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList 4 different tests:
> [JDK-8298214](https://bugs.openjdk.org/browse/JDK-8298214) ProblemList
> java/util/concurrent/forkjoin/AsyncShutdownNow.java
> [JDK-8298218](https://bugs.openjdk.org/browse/JDK-8298218
On Tue, 6 Dec 2022 21:33:33 GMT, SWinxy wrote:
>> New documentation replaces the `This value can be null.`:
>>
>> When created, {@link #invalidate() invalidated}, or {@link #reset() reset},
>> this becomes {@code null}. To get out of the null state,
>> {@link #getBounds()} called with {@link #np
> New documentation replaces the `This value can be null.`:
>
> When created, {@link #invalidate() invalidated}, or {@link #reset() reset},
> this becomes {@code null}. To get out of the null state,
> {@link #getBounds()} called with {@link #npoints} being greater than
> {@code 0} will transfer in
On Tue, 6 Dec 2022 21:21:59 GMT, Olga Mikhaltsova
wrote:
>> This is a fix for LineBreakMeasurer. It takes into account the
>> TextAttribute.TRACKING value (not eq 0) while calculating the line breaks.
>>
>> Tested on Linux x64, Windows x64, macOS x64 with the reproducer
>> (LineBreakSample.ja
> This is a fix for LineBreakMeasurer. It takes into account the
> TextAttribute.TRACKING value (not eq 0) while calculating the line breaks.
>
> Tested on Linux x64, Windows x64, macOS x64 with the reproducer
> (LineBreakSample.java) attached to JDK-8165943 and the following group of
> tests:
On Mon, 5 Dec 2022 04:11:16 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/java/awt/Mouse/EnterExitEvents/DragWindowTest.java line 58:
>>
>>> 56:
>>> 57: Robot robot = new Robot();
>>> 58: robot.setAutoDelay(250);
>>
>> We normally do not need so much delay for test to work, 100ms
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote:
> We have a number of places in the codebase where a macro could help when we
> check an exception and afterwrads free something and return.
The existing (and new) macro naming doesn't make clear that it always returns
from the function
On Fri, 30 Sep 2022 21:18:45 GMT, Phil Race wrote:
>> SWinxy has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Use javadoc code syntax for null
>
> src/java.desktop/share/classes/java/awt/Polygon.java line 111:
>
>> 109: * {@link #ge
On Tue, 6 Dec 2022 01:18:24 GMT, SWinxy wrote:
>> New documentation replaces the `This value can be null.`:
>>
>> When created, {@link #invalidate() invalidated}, or {@link #reset() reset},
>> this becomes {@code null}. To get out of the null state,
>> {@link #getBounds()} called with {@link #np
On Mon, 5 Dec 2022 22:10:15 GMT, Harshitha Onkar wrote:
>> The above test was failing due to incorrect pixel color and wrong window
>> bounds on Mac-ARM, Windows and Linux platforms.
>>
>> The following changes have been made:
>> - Correct window bounds are obtained using the current ScreenDevi
On Sat, 3 Dec 2022 22:11:47 GMT, Rajat Mahajan wrote:
> The test is failing because there was no gap between the Textfields.
> I fixed it by adding Vertical Struts in between Textfields.
This pull request has now been integrated.
Changeset: ea83cb96
Author:Rajat Mahajan
Committer: Harshith
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote:
> We have a number of places in the codebase where a macro could help when we
> check an exception and afterwrads free something and return.
I'm OK with the idea and the specific desktop change.
I'll leave the rest to the appropriate com
On Mon, 5 Dec 2022 18:22:15 GMT, Phil Race wrote:
>> I changed GCC toolchain from GCC6 to GCC8 on SLES12SP5 Linux s390x.
>> I could see following errors:
>>
>> src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c: In
>> function 'allocateRasterArray':
>> src/java.desktop/share/nat
We have a number of places in the codebase where a macro could help when we
check an exception and afterwrads free something and return.
-
Commit messages:
- JDK-8298170
Changes: https://git.openjdk.org/jdk/pull/11539/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11539&r
On Mon, 5 Dec 2022 18:22:15 GMT, Phil Race wrote:
>> I changed GCC toolchain from GCC6 to GCC8 on SLES12SP5 Linux s390x.
>> I could see following errors:
>>
>> src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c: In
>> function 'allocateRasterArray':
>> src/java.desktop/share/nat
On Tue, 6 Dec 2022 02:11:19 GMT, Sergey Bylokhov wrote:
> I think that using the VoiceOver or JAWS will highlight the currently focused
> component since we should send that information to them, no?
That paragraph consists of two statements - first is that focus should be
visible and one can t
On Tue, 6 Dec 2022 02:00:44 GMT, Sergey Bylokhov wrote:
> The library provides a way to set different cursors and the application may
> use that
The library does not provide an ability to set caret to visible permanently in
case of text component being non-editable. Every time focus will chang
> When `JFileChooser` uses custom `FileSystemView`, traversing to link/shortcut
> to a folder throw `InternalError java.lang.InternalError ` in Windows. The
> issue found out to be in BasicFileChooserUI class which was unable to resolve
> the link path during directory setting. The `UsesShellFol
On Tue, 6 Dec 2022 09:32:18 GMT, Sergey Bylokhov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review Comments
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java
> lin
On Tue, 6 Dec 2022 10:02:21 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review Comments
>
> test/jdk/javax/swing/JFileChooser/FileSystemView/CustomFSVLinkTest.java line
> 131:
On Tue, 6 Dec 2022 06:14:56 GMT, Harshitha Onkar wrote:
>> test/jdk/java/awt/FullScreen/FullScreenInsets/FullScreenInsets.java line 44:
>>
>>> 42: * @bug 8003173 7019055
>>> 43: * @summary Full-screen windows should have the proper insets.
>>> 44: * @requires (os.family != "linux")
>>
>> You
On Mon, 5 Dec 2022 11:35:11 GMT, Tejesh R wrote:
> When `JFileChooser` uses custom `FileSystemView`, traversing to link/shortcut
> to a folder throw `InternalError java.lang.InternalError ` in Windows. The
> issue found out to be in BasicFileChooserUI class which was unable to resolve
> the li
On Mon, 5 Dec 2022 22:01:44 GMT, Phil Race wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> move freeing into awt_parseColorModel
>
> src/java.desktop/share/native/libawt/awt/image/awt_parseImage.c line 104:
>
> The cleanup and error handling in function awt_parseColorModel in
> awt_parseImage.c could be improved.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
move freeing into awt_parseColorModel
-
Changes:
- all: htt
On Tue, 20 Sep 2022 18:24:26 GMT, Alisen Chung wrote:
> Fixed test bug where mouse location was being calculated before robot
> mouseMove operation was complete
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/10363
On Mon, 5 Dec 2022 11:35:11 GMT, Tejesh R wrote:
> When `JFileChooser` uses custom `FileSystemView`, traversing to link/shortcut
> to a folder throw `InternalError java.lang.InternalError ` in Windows. The
> issue found out to be in BasicFileChooserUI class which was unable to resolve
> the li
39 matches
Mail list logo
