Re: RFR: 8298449: Unnecessary Vector usage in MetaData.ProxyPersistenceDelegate

2022-12-08 Thread SWinxy
On Fri, 11 Nov 2022 07:00:52 GMT, Andrey Turbanov wrote: > `Vector args` is used only in single method and then it converted to > `Object[]`. > So we can avoid usage of legacy synchronized `Vector` here and use > `ArrayList` instead. src/java.desktop/share/classes/java/beans/MetaData.java line

Re: RFR: 8298449: Unnecessary Vector usage in MetaData.ProxyPersistenceDelegate

2022-12-08 Thread Sergey Bylokhov
On Fri, 11 Nov 2022 07:00:52 GMT, Andrey Turbanov wrote: > `Vector args` is used only in single method and then it converted to > `Object[]`. > So we can avoid usage of legacy synchronized `Vector` here and use > `ArrayList` instead. the patch looks fine. - PR: https://git.openjd

RFR: 8298449: Unnecessary Vector usage in MetaData.ProxyPersistenceDelegate

2022-12-08 Thread Andrey Turbanov
`Vector args` is used only in single method and then it converted to `Object[]`. So we can avoid usage of legacy synchronized `Vector` here and use `ArrayList` instead. - Commit messages: - [PATCH] Unnecessary Vector usage in MetaData.ProxyPersistenceDelegate Changes: https://git.

Re: RFR: 8298447: Unnecessary Vector usage in DocPrintJob implementations

2022-12-08 Thread Sergey Bylokhov
On Mon, 5 Dec 2022 08:23:58 GMT, Andrey Turbanov wrote: > There are 3 implementations of javax.print.DocPrintJob in the JDK (It seems > they were copy-pasted from each other): > 1. PSStreamPrintJob > 2. UnixPrintJob > 3. Win32PrintJob > > They have Vector fields 'jobListeners', 'attrListeners',

Re: RFR: 8298447: Unnecessary Vector usage in DocPrintJob implementations

2022-12-08 Thread SWinxy
On Mon, 5 Dec 2022 08:23:58 GMT, Andrey Turbanov wrote: > There are 3 implementations of javax.print.DocPrintJob in the JDK (It seems > they were copy-pasted from each other): > 1. PSStreamPrintJob > 2. UnixPrintJob > 3. Win32PrintJob > > They have Vector fields 'jobListeners', 'attrListeners',

RFR: 8298447: Unnecessary Vector usage in DocPrintJob implementations

2022-12-08 Thread Andrey Turbanov
There are 3 implementations of javax.print.DocPrintJob in the JDK (It seems they were copy-pasted from each other): 1. PSStreamPrintJob 2. UnixPrintJob 3. Win32PrintJob They have Vector fields 'jobListeners', 'attrListeners', 'listenedAttributeSets', but they are always accessed only under sync

Re: RFR: 8298380: Clean up redundant array length checks in JDK code base

2022-12-08 Thread Vyom Tewari
On Thu, 8 Dec 2022 12:37:17 GMT, Sergey Tsypanov wrote: > Newer version of IntelliJ IDEA introduces new > [inspection](https://youtrack.jetbrains.com/issue/IDEA-301797/IDEA-should-report-redundant-array-length-check-in-certain-cases) > detecting redundant array length check in snippets like >

Re: RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem [v8]

2022-12-08 Thread Naveen Narayanan
> This testcase will > 1) Verify setAccelerator method of JMenuitem. > 2) Check that the selection of a menu item in the menu bar will generate > action by a key combination of META+M. > > Testing: > Tested using Mach5(20 times per platform) in Mac OS, Linux and Windows and > got all pass. Nave

Re: RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem [v6]

2022-12-08 Thread Naveen Narayanan
On Tue, 29 Nov 2022 16:04:27 GMT, Alexey Ivanov wrote: >> Naveen Narayanan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8296275: Review comments fixed. > > test/jdk/java/awt/Desktop/JMenuItemSetAcceleratorTest.java line 48: > >> 46:

Re: RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem [v7]

2022-12-08 Thread Naveen Narayanan
> This testcase will > 1) Verify setAccelerator method of JMenuitem. > 2) Check that the selection of a menu item in the menu bar will generate > action by a key combination of META+M. > > Testing: > Tested using Mach5(20 times per platform) in Mac OS, Linux and Windows and > got all pass. Nave

Re: [External] : Re: Quick fix for openjdk20

2022-12-08 Thread Ajit Ghaisas
Hi Alexey, There could be other reasons as well, but - those recorded results were for x64 only at that time. Performance degradation is comparatively more when run on M1 systems. Regards, Ajit On 09-Dec-2022, at 12:50 AM, Alexey Ushakov mailto:alexey.usha...@jetbrains.com>> wrote: Hi Aji

Re: RFR: 7030853: JDK 7 Serializable Swing classes not compatible with JDK 6 [v4]

2022-12-08 Thread Prasanta Sadhukhan
> The serialized form of the following classes in JDK 7 builds are not > compatible with prior versions of Java: > javax.swing.text.html.parser.ParserDelegator > javax.swing.LayoutComparator > They need to be declared as not compatible between releases in the API > documentation, as is th

Re: RFR: 7030853: JDK 7 Serializable Swing classes not compatible with JDK 6 [v3]

2022-12-08 Thread Phil Race
On Thu, 8 Dec 2022 03:35:36 GMT, Prasanta Sadhukhan wrote: >> The serialized form of the following classes in JDK 7 builds are not >> compatible with prior versions of Java: >> javax.swing.text.html.parser.ParserDelegator >> javax.swing.LayoutComparator >> They need to be declared as no

Re: RFR: 7030853: JDK 7 Serializable Swing classes not compatible with JDK 6 [v3]

2022-12-08 Thread Prasanta Sadhukhan
On Thu, 8 Dec 2022 03:35:36 GMT, Prasanta Sadhukhan wrote: >> The serialized form of the following classes in JDK 7 builds are not >> compatible with prior versions of Java: >> javax.swing.text.html.parser.ParserDelegator >> javax.swing.LayoutComparator >> They need to be declared as no

Re: RFR: 8298380: Clean up redundant array length checks in JDK code base

2022-12-08 Thread Sergey Bylokhov
On Thu, 8 Dec 2022 12:37:17 GMT, Sergey Tsypanov wrote: > Newer version of IntelliJ IDEA introduces new > [inspection](https://youtrack.jetbrains.com/issue/IDEA-301797/IDEA-should-report-redundant-array-length-check-in-certain-cases) > detecting redundant array length check in snippets like >

Re: RFR: 8298380: Clean up redundant array length checks in JDK code base

2022-12-08 Thread Alex Menkov
On Thu, 8 Dec 2022 12:37:17 GMT, Sergey Tsypanov wrote: > Newer version of IntelliJ IDEA introduces new > [inspection](https://youtrack.jetbrains.com/issue/IDEA-301797/IDEA-should-report-redundant-array-length-check-in-certain-cases) > detecting redundant array length check in snippets like >

Re: RFR: 8298380: Clean up redundant array length checks in JDK code base

2022-12-08 Thread David Holmes
On Thu, 8 Dec 2022 12:37:17 GMT, Sergey Tsypanov wrote: > Newer version of IntelliJ IDEA introduces new > [inspection](https://youtrack.jetbrains.com/issue/IDEA-301797/IDEA-should-report-redundant-array-length-check-in-certain-cases) > detecting redundant array length check in snippets like >

Integrated: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working

2022-12-08 Thread Sergey Bylokhov
On Tue, 6 Dec 2022 09:18:21 GMT, Sergey Bylokhov wrote: > We have two types of properties in Swing, the "basics": were implemented a > long time ago. Some of that properties are tested by the bug4314194 test. And > other properties implemented as part of the Synth L&F, and based on it - > Nimb

Re: RFR: 8282578: AIOOBE in javax.sound.sampled.Clip [v4]

2022-12-08 Thread Sergey Bylokhov
On Wed, 7 Dec 2022 21:23:53 GMT, Alexander Zuev wrote: >> Add try/catch clause to ignore an exception since it is harmless for we >> isolated >> the massge data before passing it ro processor. >> Add test case. > > Alexander Zuev has updated the pull request incrementally with one additional >

[jdk20] Integrated: 8298402: ProblemList javax/swing/JFileChooser/4847375/bug4847375.java on windows-x64

2022-12-08 Thread Daniel D . Daugherty
On Thu, 8 Dec 2022 18:06:58 GMT, Daniel D. Daugherty wrote: > A trivial fix for several ProblemListings: > [JDK-8298402](https://bugs.openjdk.org/browse/JDK-8298402) ProblemList > javax/swing/JFileChooser/4847375/bug4847375.java on windows-x64 > [JDK-8298414](https://bugs.openjdk.org/browse/JDK-

Re: [jdk20] RFR: 8298402: ProblemList javax/swing/JFileChooser/4847375/bug4847375.java on windows-x64

2022-12-08 Thread Daniel D . Daugherty
On Thu, 8 Dec 2022 20:16:00 GMT, Roger Riggs wrote: >> A trivial fix for several ProblemListings: >> [JDK-8298402](https://bugs.openjdk.org/browse/JDK-8298402) ProblemList >> javax/swing/JFileChooser/4847375/bug4847375.java on windows-x64 >> [JDK-8298414](https://bugs.openjdk.org/browse/JDK-8298

Re: [jdk20] RFR: 8298402: ProblemList javax/swing/JFileChooser/4847375/bug4847375.java on windows-x64

2022-12-08 Thread Roger Riggs
On Thu, 8 Dec 2022 18:06:58 GMT, Daniel D. Daugherty wrote: > A trivial fix for several ProblemListings: > [JDK-8298402](https://bugs.openjdk.org/browse/JDK-8298402) ProblemList > javax/swing/JFileChooser/4847375/bug4847375.java on windows-x64 > [JDK-8298414](https://bugs.openjdk.org/browse/JDK-

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

2022-12-08 Thread Xue-Lei Andrew Fan
On Thu, 8 Dec 2022 17:19:56 GMT, Kim Barrett wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update on review feedback > > src/hotspot/share/adlc/formssel.cpp line 28: > >> 26: #include "adlc.hpp" >> 27: >>

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v19]

2022-12-08 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns, and the > use of it causing building failure. The build could pass if warnings are > disabled for codes that use sprintf method. For the long run, the sprintf > could be replace

Re: Quick fix for openjdk20

2022-12-08 Thread Alexey Ushakov
Hi Ajit, According to the tests you’ve mentioned it’s not a big difference. Looks like we’ve faced with completely different scenario. I’ll try to figure out the main reason of the failure. Best Regards, Alexey > On Dec 8, 2022, at 12:38 PM, Ajit Ghaisas wrote: > > > >> On 08-Dec-2022, at

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

2022-12-08 Thread Kim Barrett
On Wed, 7 Dec 2022 21:25:11 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: RFR: 4512626: Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-08 Thread Alexander Zuev
On Thu, 8 Dec 2022 08:27:27 GMT, Sergey Bylokhov wrote: > someone who uses the same approach, any applications Gnome on Ubuntu 22, default applications. Editable text components have blinking carets, non-editable - non-blinking ones. - PR: https://git.openjdk.org/jdk/pull/11408

RFR: 8298380: Clean up redundant array length checks in JDK code base

2022-12-08 Thread Sergey Tsypanov
Newer version of IntelliJ IDEA introduces new [inspection](https://youtrack.jetbrains.com/issue/IDEA-301797/IDEA-should-report-redundant-array-length-check-in-certain-cases) detecting redundant array length check in snippets like void iterate(T[] items) { if (items.length == 0) { return;

Re: RFR: 4365952: Cannot disable JFileChooser

2022-12-08 Thread Tejesh R
On Thu, 8 Dec 2022 09:09:40 GMT, Sergey Bylokhov wrote: >> I guess for frame, the disable/enable functionality is handled by the peer >> (Windows it is `WFramePeer`), whereas for the swing components it should be >> the components itself like it is for all other components (Like in >> Abstract

Re: Quick fix for openjdk20

2022-12-08 Thread Ajit Ghaisas
On 08-Dec-2022, at 5:08 PM, Ajit Ghaisas mailto:ajit.ghai...@oracle.com>> wrote: On 08-Dec-2022, at 1:50 PM, Alexey Ushakov mailto:alexey.usha...@jetbrains.com>> wrote: FWIW we have just had at a report of a performance drop in JDK 20 from a b07 change to show how it takes time for these

Re: Quick fix for openjdk20

2022-12-08 Thread Ajit Ghaisas
On 08-Dec-2022, at 1:50 PM, Alexey Ushakov mailto:alexey.usha...@jetbrains.com>> wrote: FWIW we have just had at a report of a performance drop in JDK 20 from a b07 change to show how it takes time for these things to be discovered. Could you provide some more details concerning the regressio

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

2022-12-08 Thread Laurent Bourgès
On Wed, 7 Dec 2022 21:25:11 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: RFR: 4365952: Cannot disable JFileChooser

2022-12-08 Thread Sergey Bylokhov
On Thu, 8 Dec 2022 05:03:45 GMT, Tejesh R wrote: >> Why we cannot make inaccessible JFileChooser same as JFrame? We do not need >> to mark disable all components inside the frame(I guess jdialog and windows >> as well). Both are top level components, and probably should work in the >> same way

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v18]

2022-12-08 Thread Thomas Stuefe
On Wed, 7 Dec 2022 21:25:11 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: RFR: 4512626: Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-08 Thread Sergey Bylokhov
On Thu, 8 Dec 2022 05:28:31 GMT, Alexander Zuev wrote: > > If that is not possible I suggest providing that functionality so > > applications will be able to use that. Probably even provide some > > predefined cursors, like "faded"/"blurred"/nonblinked/etc. That could be > > configured per L&F

Re: RFR: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working

2022-12-08 Thread Prasanta Sadhukhan
On Tue, 6 Dec 2022 09:18:21 GMT, Sergey Bylokhov wrote: > We have two types of properties in Swing, the "basics": were implemented a > long time ago. Some of that properties are tested by the bug4314194 test. And > other properties implemented as part of the Synth L&F, and based on it - > Nimb

Re: Quick fix for openjdk20

2022-12-08 Thread Alexey Ushakov
> > FWIW we have just had at a report of a performance drop in JDK 20 from a b07 > change to show how it takes > time for these things to be discovered. Could you provide some more details concerning the regression? We also faced with a regression in metal rendering (https://youtrack.jetbrains.