On Tue, 13 Dec 2022 18:39:00 GMT, Sergey Bylokhov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update for folder list and test review comment update
>
>
On Tue, 13 Dec 2022 14:50:56 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update for folder list and test review comment update
>
> Marked as reviewed by psadhukhan (Reviewer).
> It is not possible to select all files on press of Ctrl+A in JFileChooser for
> GTK LAF where as all folders can be selected.
> In native side on press of Ctrl+A, able to select all files as well as
> folders.
>
> Proposed fix is to enable `multiselection `property by default for
>
On Mon, 12 Dec 2022 17:30:14 GMT, Alexey Ivanov wrote:
>> Observation found when JFileChooser is instantiated in WindowsLookAndFeel
>> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not
>> find the exact root cause so predicting it to be an issue with icons not
>> loaded
Can I please get a review for this change which only fixes typos? The original
PR for this change is https://github.com/openjdk/jdk/pull/10029. However, that
PR included changes to multiple different files in different areas of the JDK
and as a result didn't see progress.
This current PR
Label.foreground UIProperty is not honored by Nimbus L It needs to be
Label[Enabled].textForeground which is the corresponding Synth property
Added support for setting JLabel foreground color for Nimbus L
-
Commit messages:
- 7175396: The text on label is not painted red for Nimbus
On Wed, 7 Dec 2022 22:00:00 GMT, Sergey Bylokhov wrote:
>> In case of GTK LAF, the current selected element was not visible due to
>> arrowbutton is rendered in entire display area of Combobox.
>>
>> The proposed fix is to set the `squareButton `property of combobox to `false
>> `so that the
On Fri, 7 Oct 2022 08:40:42 GMT, Prasanta Sadhukhan
wrote:
>> Label.foreground UIProperty is not honored by Nimbus L
>> Added support for setting JLabel foreground color for Nimbus L
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last
On Tue, 13 Dec 2022 18:35:21 GMT, Sergey Bylokhov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Spec update
>> - Spec update
>
>
> Spec for
> [MetalLookAndFeel](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L247)
> says:
> "...MetalLookAndFeel registers an entry for each of the classes
> in the package javax.swing.plaf.metal that are named MetalXXXUI.
> In Swingset2 JInternalFrame demo, focusing on any internalframes and pressing
> Ctrl+F7 and then any of up/down/left/arrow key to move the internal frames
> results in NPE in NimbusL
> It is because `JComponent.processKeyBinding() `calls
> `SwingUtilities.notifyAction` which calls
>
On Mon, 12 Dec 2022 09:37:25 GMT, Sergey Bylokhov wrote:
> Hi all,
> This pull request contains a backport of commit
> [5540a8c5](https://github.com/openjdk/jdk/commit/5540a8c5b7160ab5c67bb84631e3de54fa5aeceb)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> The commit being
> Test was run on mac, windows, linux 50 times and passed after change
> Before fix, test fails about once every 50 runs on linux and windows platforms
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
setLocationRelativeTo set to null
On Mon, 12 Dec 2022 22:43:08 GMT, Harshitha Onkar wrote:
>> In this fix, the common code required for scaled border rendering is unified
>> and added to SwingUtilities3. This is achieved by adding a functional
>> interface to SwingUtilities3 and calling the the respective paintBorder
>>
Hi all,
This pull request contains a backport of commit
[5540a8c5](https://github.com/openjdk/jdk/commit/5540a8c5b7160ab5c67bb84631e3de54fa5aeceb)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Sergey Bylokhov on 8 Dec 2022 and
was
On Mon, 12 Dec 2022 22:43:08 GMT, Harshitha Onkar wrote:
>> In this fix, the common code required for scaled border rendering is unified
>> and added to SwingUtilities3. This is achieved by adding a functional
>> interface to SwingUtilities3 and calling the the respective paintBorder
>>
On Sun, 18 Sep 2022 21:23:12 GMT, SWinxy wrote:
> `JRSUIUtils.java` structurally does things weirdly. The utility class mostly
> passes parameters from functions to other functions. The indirection makes
> things harder to understand the eventual purpose.
>
> Take
On Sun, 18 Sep 2022 21:23:12 GMT, SWinxy wrote:
> `JRSUIUtils.java` structurally does things weirdly. The utility class mostly
> passes parameters from functions to other functions. The indirection makes
> things harder to understand the eventual purpose.
>
> Take
`JRSUIUtils.java` structurally does things weirdly. The utility class mostly
passes parameters from functions to other functions. The indirection makes
things harder to understand the eventual purpose.
Take `AquaInternalFrameBorderMetrics.java`. It has a `static boolean` that
caches a call to
On Tue, 13 Dec 2022 15:59:53 GMT, Artem Semenov wrote:
> [ComboBoxAccessibility accessibilityValue] works with the accessibleSelection
> object directly, however the work should go through CAccessibility so that it
> is executed on the Event Dispatch thread.
On Wed, 30 Nov 2022 17:53:08 GMT, Damon Nguyen wrote:
>> Test ran on all OS 100 times and passed. Test previously failed on macOS but
>> no longer reproducible. Added screen capture on moment of failure to have
>> more evidence of failures in the future (previously a runtime exception was
>>
On Mon, 12 Dec 2022 05:56:38 GMT, Abhishek Kumar wrote:
> It is not possible to select all files on press of Ctrl+A in JFileChooser for
> GTK LAF where as all folders can be selected.
> In native side on press of Ctrl+A, able to select all files as well as
> folders.
>
> Proposed fix is to
On Tue, 13 Dec 2022 09:56:47 GMT, Prasanta Sadhukhan
wrote:
> Spec for
> [MetalLookAndFeel](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L247)
> says:
> "...MetalLookAndFeel registers an entry for each of the classes
>
On Tue, 13 Dec 2022 09:58:21 GMT, Prasanta Sadhukhan
wrote:
>> In Swingset2 JInternalFrame demo, focusing on any internalframes and
>> pressing Ctrl+F7 and then any of up/down/left/arrow key to move the internal
>> frames results in NPE in NimbusL
>> It is because
On Mon, 12 Dec 2022 20:57:05 GMT, Alexey Ivanov wrote:
>> Naveen Narayanan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8296275: Removing trailing whitespaces.
>
> test/jdk/javax/swing/JMenuItem/JMenuItemSetAcceleratorTest.java line
On Mon, 12 Dec 2022 20:54:09 GMT, Alexey Ivanov wrote:
>> Naveen Narayanan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8296275: Removing trailing whitespaces.
>
> test/jdk/javax/swing/JMenuItem/JMenuItemSetAcceleratorTest.java line
> This testcase will
> 1) Verify setAccelerator method of JMenuitem.
> 2) Check that the selection of a menu item in the menu bar will generate
> action by a key combination of META+M.
>
> Testing:
> Tested using Mach5(20 times per platform) in Mac OS, Linux and Windows and
> got all pass.
On Mon, 5 Dec 2022 19:52:00 GMT, Alisen Chung wrote:
>> Test was run on mac, windows, linux 50 times and passed after change
>> Before fix, test fails about once every 50 runs on linux and windows
>> platforms
>
> Alisen Chung has updated the pull request with a new target base due to a
>
[ComboBoxAccessibility accessibilityValue] works with the accessibleSelection
object directly, however the work should go through CAccessibility so that it
is executed on the Event Dispatch thread.
-
Commit messages:
- 8298645 JNI works with accessibleSelection on a wrong thread
On Mon, 12 Dec 2022 05:56:38 GMT, Abhishek Kumar wrote:
> It is not possible to select all files on press of Ctrl+A in JFileChooser for
> GTK LAF where as all folders can be selected.
> In native side on press of Ctrl+A, able to select all files as well as
> folders.
>
> Proposed fix is to
On Fri, 11 Nov 2022 08:18:19 GMT, Tejesh R wrote:
> Observation found when JFileChooser is instantiated in WindowsLookAndFeel
> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find
> the exact root cause so predicting it to be an issue with icons not loaded
> where
[TableAccessibility accessibleRowWithIndex] and [TableAccessibility
accessibleColumnWithIndex] defines the getAccessibleRowWithIndex and
getAccessibleColumnWithIndex methods on the AccessibleContext instance of
AccessibleJTable class, however the call should go through CAccessibility so
that
On Mon, 12 Dec 2022 22:33:51 GMT, Alexander Zuev wrote:
> Set the text caret to be visible but not blinking on the non-editable text
> area. Fix the regression test that becames unstable after the change.
It would be better to verify the updated test passes on Windows. If so, remove
it from
On Tue, 13 Dec 2022 02:31:22 GMT, Prasanta Sadhukhan
wrote:
> Fixed Typo "form" should be "from"
This pull request has now been integrated.
Changeset: 3b1142a2
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/3b1142a280d66b2f5f7b4afbc76e940fdc30b463
Stats: 2
Spec for
[MetalLookAndFeel](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L247)
says:
"...MetalLookAndFeel registers an entry for each of the classes
in the package javax.swing.plaf.metal that are named MetalXXXUI.
The
> In Swingset2 JInternalFrame demo, focusing on any internalframes and pressing
> Ctrl+F7 and then any of up/down/left/arrow key to move the internal frames
> results in NPE in NimbusL
> It is because `JComponent.processKeyBinding() `calls
> `SwingUtilities.notifyAction` which calls
>
On Tue, 13 Dec 2022 03:32:28 GMT, Prasanta Sadhukhan
wrote:
>> The serialized form of the following classes in JDK 7 builds are not
>> compatible with prior versions of Java:
>> javax.swing.text.html.parser.ParserDelegator
>> javax.swing.LayoutComparator
>> They need to be declared as
On Tue, 13 Dec 2022 06:10:34 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/text/DefaultCaret/HidingSelection/HidingSelectionTest.java
>> line 120:
>>
>>> 118: robot.waitForIdle();
>>> 119: robot.delay(200);
>>> 120: if (!field2.getCaret().isSelectionVisible()) {
>>
38 matches
Mail list logo
