> Set the text caret to be visible but not blinking on the non-editable text
> area. Fix the regression test that becames unstable after the change.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Fixed MultiSelectionText so it is
On Thu, 15 Dec 2022 06:18:48 GMT, Jayathirth D V wrote:
>> @mrserb Please have a look on latest changes.
>
> Its better to add a comment which mentions why we enable MultiSelection by
> default in GTK LAF compared to other LAF's, since we are trying to match
> platform behaviour.
Comment added
> It is not possible to select all files on press of Ctrl+A in JFileChooser for
> GTK LAF where as all folders can be selected.
> In native side on press of Ctrl+A, able to select all files as well as
> folders.
>
> Proposed fix is to enable `multiselection `property by default for
> JFileChoo
On Tue, 6 Dec 2022 22:09:04 GMT, Alisen Chung wrote:
>> Alisen Chung has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits
On Wed, 14 Dec 2022 17:02:24 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java
>> line 567:
>>
>>> 565: fc.setLayout(new BorderLayout());
>>> 566: fc.setAlignmentX(JComponent.CENTER_ALIGNMENT);
>>> 567: fc.setM
On Fri, 11 Nov 2022 08:18:19 GMT, Tejesh R wrote:
> Observation found when JFileChooser is instantiated in WindowsLookAndFeel
> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find
> the exact root cause so predicting it to be an issue with icons not loaded
> where res
> Observation found when JFileChooser is instantiated in WindowsLookAndFeel
> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find
> the exact root cause so predicting it to be an issue with icons not loaded
> where resolutionVariants map is empty in _public Image
> get
> Open l10n drop
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Removed trailing whitespace
-
Changes:
- all: https://git.openjdk.org/jdk20/pull/35/files
- new: https://git.openjdk.org/jdk20/pull/
On Thu, 15 Dec 2022 01:04:12 GMT, Justin Lu wrote:
>> Open l10n drop
>> All tests passed
>
> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line
> 26:
>
>> 24: #
>> 25:
>> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener
>> JMOD-Dateien auflisten
On Thu, 15 Dec 2022 00:58:06 GMT, Justin Lu wrote:
>> Open l10n drop
>> All tests passed
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties
> line 188:
>
>> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757
>> 187:
>> 188: main.plugin.category=\u7C7B\u522B
>
>
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote:
> Open l10n drop
> All tests passed
src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line 26:
> 24: #
> 25:
> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener
> JMOD-Dateien auflisten
`jlink.de
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote:
> Open l10n drop
> All tests passed
src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties
line 188:
> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757
> 187:
> 188: main.plugin.category=\u7C7B\u522B
As Naoto poin
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote:
> Open l10n drop
> All tests passed
looks good
-
Marked as reviewed by achung (Committer).
PR: https://git.openjdk.org/jdk20/pull/35
Open l10n drop
All tests passed
-
Commit messages:
- open l10n drop
Changes: https://git.openjdk.org/jdk20/pull/35/files
Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=35&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8298133
Stats: 1177 lines in 110 files changed: 783
On Tue, 29 Nov 2022 23:10:56 GMT, Alisen Chung wrote:
> Test was run on mac, windows, linux 50 times and passed after change
> Before fix, test fails about once every 50 runs on linux and windows platforms
This pull request has now been integrated.
Changeset: 0ed6d0b4
Author:Alisen Chung
U
On Mon, 12 Dec 2022 18:27:24 GMT, SWinxy wrote:
>> Many `installDefaults` methods set the font, foreground, and background on
>> objects but their inverse methods `uninstallDefaults` do not remove them.
>> I've added an inverse method to remove the colors and font to call for the
>> `uninstall
> This is referenced in Java Bug Database as
> - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded
> Color](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8293776)
>
> This is tracked in JBS as
> - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded
> Color](https://bugs.openjdk.java.net/brow
On Wed, 14 Dec 2022 01:01:33 GMT, Alisen Chung wrote:
>> Test was run on mac, windows, linux 50 times and passed after change
>> Before fix, test fails about once every 50 runs on linux and windows
>> platforms
>
> Alisen Chung has updated the pull request incrementally with one additional
> co
> This is referenced in Java Bug Database as
> - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded
> Color](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8293776)
>
> This is tracked in JBS as
> - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded
> Color](https://bugs.openjdk.java.net/brow
On Wed, 14 Dec 2022 06:00:43 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which only fixes typos? The
> original PR for this change is https://github.com/openjdk/jdk/pull/10029.
> However, that PR included changes to multiple different files in different
> areas of the
On Tue, 13 Dec 2022 18:39:00 GMT, Sergey Bylokhov wrote:
>> Abhishek Kumar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> co
On Mon, 14 Nov 2022 00:03:51 GMT, Alexander Zvegintsev
wrote:
> This test has multiple issues:
>
> * Test actually does nothing and passes as it is right now, but tests nothing
> * `pgrep gnome-session` may return multiple PIDs -> picking up only first one
> * looks like jtreg does not pass GN
On Fri, 30 Sep 2022 17:42:43 GMT, Alexey Ivanov wrote:
>>> Shall I edit the subject of the issue to be more specific? “Add named
>>> colors from CSS Color Module Level 4”?
>>
>> Yes, you may. Thanks.
>>
>>> ... please create a [CSR](https://wiki.openjdk.org/display/csr/Main)
>>> request for i
On Tue, 13 Dec 2022 16:40:54 GMT, Naveen Narayanan wrote:
> My IDE’s formatter auto wraps this line for 80 chars. After every code change
> & formatting, I have to manually unwrap these lines. There are 3 lines to
> unwrap manually.
Then disable automatic reformatting of the entire file. It wo
On Tue, 13 Dec 2022 16:41:42 GMT, Naveen Narayanan wrote:
>> This testcase will
>> 1) Verify setAccelerator method of JMenuitem.
>> 2) Check that the selection of a menu item in the menu bar will generate
>> action by a key combination of META+M.
>>
>> Testing:
>> Tested using Mach5(20 times pe
On Wed, 14 Dec 2022 15:53:52 GMT, Alexey Ivanov wrote:
> > So far, from the analysis it is found that the backup mechanism to get
> > default Icon is failing when icon extraction fails.
>
> These are the new details which you've never mentioned before.
>
> The icon extraction of a folder (pres
On Wed, 7 Dec 2022 08:54:29 GMT, Matthias Baesken wrote:
>> The cleanup and error handling in function awt_parseColorModel in
>> awt_parseImage.c could be improved.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> small
On Wed, 14 Dec 2022 06:43:00 GMT, Tejesh R wrote:
> So far, from the analysis it is found that the backup mechanism to get
> default Icon is failing when icon extraction fails.
These are the new details which you've never mentioned before.
The icon extraction of a folder (presumably _Downloads
On Tue, 13 Dec 2022 13:43:05 GMT, Tejesh R wrote:
> Means checking for null when trying to insert null into MRI map?
Yes, because such an image is invalid — it will produce the NPE when it's
rendered. If icon isn't available, `null` is to be returned directly to the
caller.
-
PR:
On Wed, 14 Dec 2022 11:00:31 GMT, Abhishek Kumar wrote:
> Ok with me..Probably better to add a subtest with
> setMultiSelectionEnabled(false) and check multiple files are not selected..
Added the subtest with `setMultiSelectionEnabled(false)`.
-
PR: https://git.openjdk.org/jdk/pul
> It is not possible to select all files on press of Ctrl+A in JFileChooser for
> GTK LAF where as all folders can be selected.
> In native side on press of Ctrl+A, able to select all files as well as
> folders.
>
> Proposed fix is to enable `multiselection `property by default for
> JFileChoo
On Wed, 14 Dec 2022 04:59:56 GMT, Prasanta Sadhukhan
wrote:
> Label.foreground UIProperty is not honored by Nimbus L&F. It needs to be
> Label[Enabled].textForeground which is the corresponding Synth property
> Added support for setting JLabel foreground color for Nimbus L&F
test/jdk/javax/swi
On Wed, 14 Dec 2022 10:56:19 GMT, Prasanta Sadhukhan
wrote:
> Ok with me..Probably better to add a subtest with
> setMultiSelectionEnabled(false) and check multiple files are not selected..
OK... I will try to update the test.
-
PR: https://git.openjdk.org/jdk/pull/11627
On Mon, 12 Dec 2022 09:37:25 GMT, Sergey Bylokhov wrote:
> Hi all,
> This pull request contains a backport of commit
> [5540a8c5](https://github.com/openjdk/jdk/commit/5540a8c5b7160ab5c67bb84631e3de54fa5aeceb)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> The commit being
On Wed, 14 Dec 2022 07:32:29 GMT, Abhishek Kumar wrote:
>> It is not possible to select all files on press of Ctrl+A in JFileChooser
>> for GTK LAF where as all folders can be selected.
>> In native side on press of Ctrl+A, able to select all files as well as
>> folders.
>>
>> Proposed fix is
> In Swingset2 JInternalFrame demo, focusing on any internalframes and pressing
> Ctrl+F7 and then any of up/down/left/arrow key to move the internal frames
> results in NPE in NimbusL&F.
> It is because `JComponent.processKeyBinding() `calls
> `SwingUtilities.notifyAction` which calls
> `Basic
[OutlineRowAccessibility currentAccessibleWithENV:] defines the
getCurrentComponent method on the AccessibleContext instance of
AccessibleJTreeNode class, however the call should go through CAccessibility so
that it is executed on the Event Dispatch thread.
-
Commit messages:
- 82
On Wed, 7 Dec 2022 10:25:31 GMT, Abhishek Kumar wrote:
> In case of GTK LAF, the current selected element was not visible due to
> arrowbutton is rendered in entire display area of Combobox.
>
> The proposed fix is to set the `squareButton `property of combobox to `false
> `so that the arrowbu
On Mon, 12 Dec 2022 10:28:50 GMT, Abhishek Kumar wrote:
> > _TestComboBoxComponentRendering.java_ test failed (Synth L&F) in Ubuntu_21
> > VM machine. .jtr file and Failure case screen captured shared.
>
> Run the test in Ubuntu 20,21 and 22 in CI pipeline, test passed for all
> platform.
The
On Tue, 13 Dec 2022 19:26:37 GMT, SWinxy wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> A comment or javadoc should mention that this is called from native code,
>> specifically pointing to ComboBoxAccessibility
> [ComboBoxAccessibility accessibilityValue] works with the accessibleSelection
> object directly, however the work should go through CAccessibility so that it
> is executed on the Event Dispatch thread.
Artem Semenov has updated the pull request incrementally with one additional
commit since t
On Wed, 14 Dec 2022 03:21:57 GMT, Prasanta Sadhukhan
wrote:
>> In Swingset2 JInternalFrame demo, focusing on any internalframes and
>> pressing Ctrl+F7 and then any of up/down/left/arrow key to move the internal
>> frames results in NPE in NimbusL&F.
>> It is because `JComponent.processKeyBind
42 matches
Mail list logo
