Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-20 Thread Alexander Zuev
On Tue, 20 Dec 2022 23:38:31 GMT, Alexander Zuev wrote: > Slightly updated original fix - got rid of the extra flasher reset. Tests are > fixed to be more stable and pass on the corresponding platforms. Full test run is finished, all tests except the JCK ones are passed. And we have a JCK chal

Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-20 Thread Alexander Zuev
On Tue, 20 Dec 2022 23:38:31 GMT, Alexander Zuev wrote: > Slightly updated original fix - got rid of the extra flasher reset. Tests are > fixed to be more stable and pass on the corresponding platforms. @azvegint @aivanov-jdk Can you please take a look? - PR: https://git.openjdk.o

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11

2022-12-20 Thread Jaikiran Pai
On Tue, 20 Dec 2022 23:25:30 GMT, Harshitha Onkar wrote: > ViewportOverlapping was failing intermittently on Windows (Win10 & 11). Added > robot.setAutoWaitForIdle() to ViewportOverlapping and its base class > (OverlappingTestBase) to stabilize the test. > > Additionally added awt & swings tes

[jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-20 Thread Alexander Zuev
Slightly updated original fix - got rid of the extra flasher reset. Tests are fixed to be more stable and pass on the corresponding platforms. - Commit messages: - 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus Changes: https://g

RFR: JDK-8299052: ViewportOverlapping test fails on Win10 & Win11

2022-12-20 Thread Harshitha Onkar
ViewportOverlapping was failing intermittently on Windows (Win10 & 11). Added robot.setAutoWaitForIdle() to ViewportOverlapping and its base class (OverlappingTestBase) to stabilize the test. Additionally added awt & swings tests to exclusiveAccess.dir in TEST.ROOT. - Commit messag

Re: RFR: 8200192: Verify exported symbols in java.desktop

2022-12-20 Thread Phil Race
On Tue, 20 Dec 2022 22:09:42 GMT, Daniel Jeliński wrote: > These exports were absent even before my changes, so I believe we should be > fine here. I can't speak to all of these but we only have a subset of freetype in JDK sources, since for example we have no interest in the bitmap formats, s

Re: RFR: 8200192: Verify exported symbols in java.desktop

2022-12-20 Thread Phil Race
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote: > Please review this patch that removes unnecessary exports from libawt and > libfreetype. > > Verified that: > - mach5 client libs tests pass > - both release and debug builds finish successfully > > Did not verify the other issues repo

Re: RFR: 8200192: Verify exported symbols in java.desktop

2022-12-20 Thread Daniel Jeliński
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote: > Please review this patch that removes unnecessary exports from libawt and > libfreetype. > > Verified that: > - mach5 client libs tests pass > - both release and debug builds finish successfully > > Did not verify the other issues repo

Integrated: Merge jdk20

2022-12-20 Thread Jesper Wilhelmsson
On Tue, 20 Dec 2022 19:41:28 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: 386db071 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/386db07143883f85307138eca2f0305d997a2171 Stats: 258 lines

Re: RFR: 8200192: Verify exported symbols in java.desktop

2022-12-20 Thread Phil Race
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote: > Please review this patch that removes unnecessary exports from libawt and > libfreetype. > > Verified that: > - mach5 client libs tests pass > - both release and debug builds finish successfully > > Did not verify the other issues repo

RFR: 8200192: Verify exported symbols in java.desktop

2022-12-20 Thread Daniel Jeliński
Please review this patch that removes unnecessary exports from libawt and libfreetype. Verified that: - mach5 client libs tests pass - both release and debug builds finish successfully Did not verify the other issues reported in the linked JBS ticket. - Commit messages: - Export s

RFR: Merge jdk20

2022-12-20 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8299123: [BACKOUT] 4512626 Non-editable JTextArea provides no visual indication of keyboard focus - 8298162: Test PrintClasses hits assert when run with code that retra

Re: RFR: JDK-8299025: BMPImageReader.java readColorPalette could use staggeredReadByteStream

2022-12-20 Thread SWinxy
On Mon, 19 Dec 2022 13:49:18 GMT, Matthias Baesken wrote: > Looks like the coding in > jdk/src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java > readColorPalette is rather close to what staggeredReadByteStream does, so we > could instead use staggeredReadByteStream a

Re: RFR: JDK-8299025: BMPImageReader.java readColorPalette could use staggeredReadByteStream

2022-12-20 Thread Christoph Langer
On Mon, 19 Dec 2022 13:49:18 GMT, Matthias Baesken wrote: > Looks like the coding in > jdk/src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java > readColorPalette is rather close to what staggeredReadByteStream does, so we > could instead use staggeredReadByteStream a

[jdk20] Withdrawn: 8299077: Regression - javax/swing/text/StyledEditorKit/8016833/bug8016833.java fails on all platforms

2022-12-20 Thread Ajit Ghaisas
On Tue, 20 Dec 2022 10:54:16 GMT, Ajit Ghaisas wrote: > This PR reverts the fix done in > [JDK-4512626](https://bugs.openjdk.org/browse/JDK-4512626) as it caused few > test regressions. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk2

[jdk20] Integrated: 8299123: [BACKOUT] 4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-20 Thread Daniel D . Daugherty
On Tue, 20 Dec 2022 15:41:45 GMT, Daniel D. Daugherty wrote: > This reverts commit 3e17e3c1c12d71461213bf15cdb72d4d93c88460. This pull request has now been integrated. Changeset: f4d7f433 Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk20/commit/f4d7f433942219704072a3fef

Re: [jdk20] RFR: 8299123: [BACKOUT] 4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-20 Thread Daniel D . Daugherty
On Tue, 20 Dec 2022 16:15:09 GMT, Thomas Schatzl wrote: >> This reverts commit 3e17e3c1c12d71461213bf15cdb72d4d93c88460. > > Ship it @tschatzl - Thanks for the review! - PR: https://git.openjdk.org/jdk20/pull/62

Re: [jdk20] RFR: 8299123: [BACKOUT] 4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-20 Thread Thomas Schatzl
On Tue, 20 Dec 2022 15:41:45 GMT, Daniel D. Daugherty wrote: > This reverts commit 3e17e3c1c12d71461213bf15cdb72d4d93c88460. Ship it - Marked as reviewed by tschatzl (Reviewer). PR: https://git.openjdk.org/jdk20/pull/62

Re: [jdk20] RFR: 8299077: Regression - javax/swing/text/StyledEditorKit/8016833/bug8016833.java fails on all platforms

2022-12-20 Thread Daniel D . Daugherty
On Tue, 20 Dec 2022 10:54:16 GMT, Ajit Ghaisas wrote: > This PR reverts the fix done in > [JDK-4512626](https://bugs.openjdk.org/browse/JDK-4512626) as it caused few > test regressions. Please close this PR in favor of this one: https://github.com/openjdk/jdk20/pull/62 @jayathirthrao - The fi

[jdk20] RFR: 8299123: [BACKOUT] 4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-20 Thread Daniel D . Daugherty
This reverts commit 3e17e3c1c12d71461213bf15cdb72d4d93c88460. - Commit messages: - Revert "4512626: Non-editable JTextArea provides no visual indication of keyboard focus" Changes: https://git.openjdk.org/jdk20/pull/62/files Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=62&ra

Re: RFR: 8295707: Create a regression test for JDK-7184401 [v2]

2022-12-20 Thread Alexey Ivanov
On Fri, 2 Dec 2022 05:40:06 GMT, Sergey Bylokhov wrote: >> There was a comment in the original code before the realSync() call that was >> removed, which perhaps should have been left as is. >> // cannot substitute with robot.waitForIdle() presumably because of >> flushPendingEvents()

Re: RFR: 8295707: Create a regression test for JDK-7184401 [v2]

2022-12-20 Thread Alexey Ivanov
On Mon, 7 Nov 2022 07:28:02 GMT, Srinivas Mandalika wrote: >> 8295707: Create a regression test for JDK-7184401 >> >> JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for >> 7162144 >> Above bug got introduced due to a fix for >> [JDK-7162144](https://bugs.openjdk.java.net/b

Re: [jdk20] RFR: 8299077: Regression - javax/swing/text/StyledEditorKit/8016833/bug8016833.java fails on all platforms

2022-12-20 Thread Jayathirth D V
On Tue, 20 Dec 2022 10:54:16 GMT, Ajit Ghaisas wrote: > This PR reverts the fix done in > [JDK-4512626](https://bugs.openjdk.org/browse/JDK-4512626) as it caused few > test regressions. I dont think we should straightaway revert this fix. We should try to fix the test failure or problemlist th

[jdk20] RFR: 8299077: Regression - javax/swing/text/StyledEditorKit/8016833/bug8016833.java fails on all platforms

2022-12-20 Thread Ajit Ghaisas
This PR reverts the fix done in [JDK-4512626](https://bugs.openjdk.org/browse/JDK-4512626) as it caused few test regressions. - Commit messages: - revert JDK-4512626 fix Changes: https://git.openjdk.org/jdk20/pull/61/files Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=61&ran

Integrated: Merge jdk20

2022-12-20 Thread Jesper Wilhelmsson
On Tue, 20 Dec 2022 10:57:44 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: c5a4a7a6 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/c5a4a7a679ec76cb08a999a198e5c73e9cd9d2f0 Stats: 2286 lines

Re: RFR: Merge jdk20 [v2]

2022-12-20 Thread Jesper Wilhelmsson
> Forwardport JDK 20 -> JDK 21 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 107 commits: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8298865: Excessive memory allocation in CipherOutputStre

RFR: Merge jdk20

2022-12-20 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8298784: JFR: Test chunk integrity - 8298215: gc/g1/TestVerifyGCType.java failed with "Missing expected verification pattern Verifying After GC for: Pause Young (Prepar

Re: RFR: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null' [v3]

2022-12-20 Thread Tejesh R
> Observation found when JFileChooser is instantiated in WindowsLookAndFeel > which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find > the exact root cause so predicting it to be an issue with icons not loaded > where resolutionVariants map is empty in _public Image > get