Re: RFR: 4912623: GTK L&F: Folder list of the JFileChooser is allowing multiple selection unlike native [v4]

2022-12-27 Thread Jayathirth D V
On Thu, 15 Dec 2022 06:47:33 GMT, Abhishek Kumar wrote: >> It is not possible to select all files on press of Ctrl+A in JFileChooser >> for GTK LAF where as all folders can be selected. >> In native side on press of Ctrl+A, able to select all files as well as >> folders. >> >> Proposed fix is

Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v4]

2022-12-27 Thread ScientificWare
On Mon, 12 Dec 2022 13:06:09 GMT, Alexey Ivanov wrote: >> Looks good to me. >> >> In the description above: “…invoked one per property…”, it shoud be “once”. >> >> I think there's room for improvement. However, this is an internal-only >> class. > >> I think there's room for improvement. Howev

Re: RFR: JDK-8296661 : Typo Found In CSSParser.java [v4]

2022-12-27 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8296661 : Typo Found In > CSSParser.java](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661) > > This is tracked in JBS as > - [JDK-8296661 : Typo Found In > CSSParser.java](https://bugs.openjdk.java.net/browse/JDK-8296661) > > I

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v4]

2022-12-27 Thread Tres Finocchiaro
On Tue, 29 Nov 2022 10:36:32 GMT, Alexander Scherbatiy wrote: >> A printed content is truncated on macOS if the content paper size width >> larger than height with portrait orientation or width is less than height >> with landscape orientation. >> >> To reproduce the issue run the >> [CutOff

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v19]

2022-12-27 Thread Michael Hall
> On Dec 27, 2022, at 1:43 PM, Xue-Lei Andrew Fan wrote: > > On Tue, 27 Dec 2022 14:40:36 GMT, Christoph wrote: > >> ERROR: Build failed for target 'run-test-tier1' in configuration >> 'macosx-aarch64-server-release' (exit code 2) >> > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-829

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v19]

2022-12-27 Thread Xue-Lei Andrew Fan
On Tue, 27 Dec 2022 14:40:36 GMT, Christoph wrote: > ERROR: Build failed for target 'run-test-tier1' in configuration > 'macosx-aarch64-server-release' (exit code 2) > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) was filled to track the issue. Thanks! - PR: https:

RFR: 8081507: Open or Save button in JFileChooser has OK title in GTK LaF

2022-12-27 Thread Abhishek Kumar
Open or Save button in JFileChooser has OK title in GTK LAF. The open/save button text modified as per the native FileChooser. Manual test case is added. `open/test/jdk/sanity/client/SwingSet/src/FileChooserDemoTest.java` failed with the current fix with an exception `**Wait AbstractButton with

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v19]

2022-12-27 Thread Christoph
On Thu, 8 Dec 2022 19:41:16 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that us

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-12-27 Thread Michael Ernst
On Mon, 28 Nov 2022 09:00:09 GMT, Jaikiran Pai wrote: >> Could someone who knows the undocumented ins and outs of creating JDK pull >> requests could split this pull request up into multiple PRs? Then it can be >> merged, rather than wasting all the effort that went into it. > >> Could someone

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v3]

2022-12-27 Thread Michael Ernst
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni Michael Ernst has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge ../jdk-openjdk into typos-typos - Reinstate typos in Apache code that