Re: RFR: 8298240: Replace the usage of ImageLayoutException by the CMMException [v2]

2022-12-29 Thread Sergey Bylokhov
> ImageLayoutException is used to report any issues with image layout > calculation. But since we cannot throw the unspecified exception to the > application, all usages of ImageLayoutException are wrapped by the > CMMException. And now if such CMMException occurs we have lost at what point > t

Re: RFR: 8299412 JNI call of getAccessibleActionCount on a wrong thread [v2]

2022-12-29 Thread Sergey Bylokhov
On Thu, 29 Dec 2022 20:41:04 GMT, Artem Semenov wrote: >> [CommonComponentAccessibility getActionsWithEnv:] defines the >> getAccessibleActionCount method on the AccessibleAction class, however the >> call should go through CAccessibility so that it is executed on the Event >> Dispatch thread.

Integrated: 8299260: libawt and libfreetype should export only explicitly requested symbols

2022-12-29 Thread Daniel Jeliński
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote: > Please review this patch that removes unnecessary exports from libawt and > libfreetype. > > Verified that: > - mach5 client libs tests pass > - both release and debug builds finish successfully This pull request has now been integrate

RFR: 8272288: Funky multiresolution image breaks graphics context

2022-12-29 Thread Sergey Bylokhov
This is the next iteration of fixing the issue of rendering "broken" image. The fix for [JDK-7183828](https://bugs.openjdk.org/browse/JDK-7183828) changed the possible IllegalArgumentException during rendering to the InvalidPipeException in assumtion that the new exception will be catched by the

Re: RFR: 8299337: The java.awt.image.ColorModel#pData field is unused

2022-12-29 Thread SWinxy
On Sat, 24 Dec 2022 03:49:38 GMT, Sergey Bylokhov wrote: > I have found that we store the native pointer in the > "java.awt.image.ColorModel#pData" field and never update/clean it. We can > check how and when the native data is deallocated and reset the pointer, but > it will be easy just to d

Re: OS/X GUI applications

2022-12-29 Thread Michael Hall
> On Dec 28, 2022, at 9:51 PM, Michael Hall wrote: > > Mail.app not receiving for some reason. So from gmail in Safari. > > >The Apple system properties are going to remain as they are, unless e.g. > >there's some good reason to change the key of a property. > > OK, good to know. I'm pretty

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v4]

2022-12-29 Thread Sergey Bylokhov
On Thu, 29 Dec 2022 14:23:40 GMT, Artem Semenov wrote: >> [OutlineRowAccessibility currentAccessibleWithENV:] defines the >> getCurrentComponent method on the AccessibleContext instance of >> AccessibleJTreeNode class, however the call should go through CAccessibility >> so that it is executed

Re: RFR: 8299412 JNI call of getAccessibleActionCount on a wrong thread [v2]

2022-12-29 Thread SWinxy
On Thu, 29 Dec 2022 20:41:04 GMT, Artem Semenov wrote: >> [CommonComponentAccessibility getActionsWithEnv:] defines the >> getAccessibleActionCount method on the AccessibleAction class, however the >> call should go through CAccessibility so that it is executed on the Event >> Dispatch thread.

Re: RFR: 8299412 JNI call of getAccessibleActionCount on a wrong thread [v2]

2022-12-29 Thread Artem Semenov
On Thu, 29 Dec 2022 19:40:17 GMT, SWinxy wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> There's a more compact way of doing this: > > src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java line 530:

Re: RFR: 8299412 JNI call of getAccessibleActionCount on a wrong thread [v2]

2022-12-29 Thread Artem Semenov
> [CommonComponentAccessibility getActionsWithEnv:] defines the > getAccessibleActionCount method on the AccessibleAction class, however the > call should go through CAccessibility so that it is executed on the Event > Dispatch thread. > > @azuev-java @mrserb @prrace please review Artem Semeno

Re: RFR: 8299412 JNI call of getAccessibleActionCount on a wrong thread

2022-12-29 Thread SWinxy
On Thu, 29 Dec 2022 15:54:43 GMT, Artem Semenov wrote: > [CommonComponentAccessibility getActionsWithEnv:] defines the > getAccessibleActionCount method on the AccessibleAction class, however the > call should go through CAccessibility so that it is executed on the Event > Dispatch thread. >

RFR: 8299412 JNI call of getAccessibleActionCount on a wrong thread

2022-12-29 Thread Artem Semenov
[CommonComponentAccessibility getActionsWithEnv:] defines the getAccessibleActionCount method on the AccessibleAction class, however the call should go through CAccessibility so that it is executed on the Event Dispatch thread. @azuev-java @mrserb @prrace please review - Commit me

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v4]

2022-12-29 Thread Alexey Ushakov
On Thu, 29 Dec 2022 14:23:40 GMT, Artem Semenov wrote: >> [OutlineRowAccessibility currentAccessibleWithENV:] defines the >> getCurrentComponent method on the AccessibleContext instance of >> AccessibleJTreeNode class, however the call should go through CAccessibility >> so that it is executed

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v4]

2022-12-29 Thread Artem Semenov
> [OutlineRowAccessibility currentAccessibleWithENV:] defines the > getCurrentComponent method on the AccessibleContext instance of > AccessibleJTreeNode class, however the call should go through CAccessibility > so that it is executed on the Event Dispatch thread. Artem Semenov has updated the

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v4]

2022-12-29 Thread Artem Semenov
On Sat, 24 Dec 2022 00:35:07 GMT, Sergey Bylokhov wrote: >> Thank you. >> I removed adding accesses for TableCell and ListChildren. If that's what you >> meant. >> I would like to keep the implementation of the Accesser itself, if possible. >> Because in the future it may come in handy in this

Re: RFR: 8298644 JNI call of getCurrentComponent on a wrong thread [v3]

2022-12-29 Thread Artem Semenov
> [OutlineRowAccessibility currentAccessibleWithENV:] defines the > getCurrentComponent method on the AccessibleContext instance of > AccessibleJTreeNode class, however the call should go through CAccessibility > so that it is executed on the Event Dispatch thread. Artem Semenov has updated the