Re: RFR: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not [v2]

2023-01-03 Thread Anto J
On Tue, 3 Jan 2023 01:14:45 GMT, Sergey Bylokhov wrote: >> Anto J has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8296934: Write a test to verify whether Undecorated Frame can be iconified >> or not > > test/jdk/java/awt/Frame/Iconify/I

Re: RFR: 8299296: Write a test to verify the components selection sends ItemEvent [v2]

2023-01-03 Thread Ravi Gupta
On Mon, 2 Jan 2023 04:41:15 GMT, Ravi Gupta wrote: >> This testcase verifies the following assertions >> >> a. Selecting an item in the Choice using mouse generates ItemEvent. >> b. Single-click on an Checkbox generates ItemEvent. >> >> Testing: >> Tested using Mach5(20 times per platform) in m

Integrated: 7030853: JDK 7 Serializable Swing classes not compatible with JDK 6

2023-01-03 Thread Prasanta Sadhukhan
On Wed, 7 Dec 2022 16:35:24 GMT, Prasanta Sadhukhan wrote: > The serialized form of the following classes in JDK 7 builds are not > compatible with prior versions of Java: > javax.swing.text.html.parser.ParserDelegator > javax.swing.LayoutComparator > They need to be declared as not com

Withdrawn: 8296535: Unnecessary Vector usage in AquaFileSystemModel.FilesLoader

2023-01-03 Thread duke
On Wed, 2 Nov 2022 08:19:41 GMT, Andrey Turbanov wrote: > Couple of local variables in > `com.apple.laf.AquaFileSystemModel.FilesLoader#run` are used only within the > method from single thread. So we can avoid usage of legacy synchronized > `Vector` here and use `ArrayList` instead. This pul

Re: RFR: 8299553: Make ScaledEtchedBorderTest.java comprehensive

2023-01-03 Thread Harshitha Onkar
On Tue, 3 Jan 2023 19:59:38 GMT, Alexey Ivanov wrote: > The `ScaledEtchedBorderTest.java` test > ([JDK-8279614](https://bugs.openjdk.org/browse/JDK-8279614)) verifies that > the thickness of lines of `EtchedBorder` is consistent. The component inside > had the same background color as the fram

Re: RFR: 8299261: Clean up AWT D3D exports

2023-01-03 Thread Daniel Jeliński
On Thu, 22 Dec 2022 10:01:02 GMT, Daniel Jeliński wrote: > Please review this patch that removes unnecessary exports from awt.dll. > > The exports were introduced in e4c9db984fe1a3a9d06fb60e333e92df3b165454, and > as far as I could tell, they were never used; the exported functions are only >

Re: RFR: 8299553: Make ScaledEtchedBorderTest.java comprehensive

2023-01-03 Thread Sergey Bylokhov
On Tue, 3 Jan 2023 19:59:38 GMT, Alexey Ivanov wrote: > The `ScaledEtchedBorderTest.java` test > ([JDK-8279614](https://bugs.openjdk.org/browse/JDK-8279614)) verifies that > the thickness of lines of `EtchedBorder` is consistent. The component inside > had the same background color as the fram

Re: RFR: 8299553: Make ScaledEtchedBorderTest.java comprehensive

2023-01-03 Thread Harshitha Onkar
On Tue, 3 Jan 2023 20:28:55 GMT, Sergey Bylokhov wrote: > Don't you need to close the > [JDK-8294921](https://bugs.openjdk.org/browse/JDK-8294921) since it was fixed > already? This issue has been closed now. - PR: https://git.openjdk.org/jdk/pull/11836

Re: RFR: 7030853: JDK 7 Serializable Swing classes not compatible with JDK 6 [v8]

2023-01-03 Thread Alexey Ivanov
On Thu, 29 Dec 2022 06:52:17 GMT, Prasanta Sadhukhan wrote: >> The serialized form of the following classes in JDK 7 builds are not >> compatible with prior versions of Java: >> javax.swing.text.html.parser.ParserDelegator >> javax.swing.LayoutComparator >> They need to be declared as n

Re: RFR: 7030853: JDK 7 Serializable Swing classes not compatible with JDK 6 [v8]

2023-01-03 Thread Alexey Ivanov
On Thu, 29 Dec 2022 06:52:17 GMT, Prasanta Sadhukhan wrote: >> The serialized form of the following classes in JDK 7 builds are not >> compatible with prior versions of Java: >> javax.swing.text.html.parser.ParserDelegator >> javax.swing.LayoutComparator >> They need to be declared as n

Re: RFR: 8299553: Make ScaledEtchedBorderTest.java comprehensive

2023-01-03 Thread Sergey Bylokhov
On Tue, 3 Jan 2023 19:59:38 GMT, Alexey Ivanov wrote: > The `ScaledEtchedBorderTest.java` test > ([JDK-8279614](https://bugs.openjdk.org/browse/JDK-8279614)) verifies that > the thickness of lines of `EtchedBorder` is consistent. The component inside > had the same background color as the fram

RFR: 8299553: Make ScaledEtchedBorderTest.java comprehensive

2023-01-03 Thread Alexey Ivanov
The `ScaledEtchedBorderTest.java` test ([JDK-8279614](https://bugs.openjdk.org/browse/JDK-8279614)) verifies that the thickness of lines of `EtchedBorder` is consistent. The component inside had the same background color as the frame. Yet if there's another component the background of which is

Re: OS/X GUI applications

2023-01-03 Thread Michael Hall
> On Jan 3, 2023, at 1:10 PM, Philip Race wrote: > > > >> FX list as well as that it would be nice if SceneBuilder did have an ‘about’ >> menu item to check the version you have installed. > > For FX apps .. you really should be asking on the FX list. > Most of the above - actually I suspec

Re: RFR: 8298266: "java.home property not set" error in Graal when sun.awt.fontconfig java property is set on Windows [v2]

2023-01-03 Thread Phil Race
On Thu, 22 Dec 2022 10:57:15 GMT, Alexander Scherbatiy wrote: >> **Environment**: >> GraalVM 22.3.0 with jdk 19, Windows OS. >> >> **Description**: >> Create a native image of Swing application using GraalVM and run it with ` >> -Dsun.awt.fontconfig=fontconfig.properties.src` java property.

Re: OS/X GUI applications

2023-01-03 Thread Philip Race
PS actually java launcher code still reads -Dapple.awt.application.name -phil. On 1/3/23 11:10 AM, Philip Race wrote: On 12/28/22 7:11 AM, Michael Hall wrote: I was wondering for some reason what version of the Scene Builder application I had. There was no application “About” menu item. I no

Re: OS/X GUI applications

2023-01-03 Thread Philip Race
On 12/28/22 7:11 AM, Michael Hall wrote: I was wondering for some reason what version of the Scene Builder application I had. There was no application “About” menu item. I noticed one of my own applications did have this but I didn’t remember how. I finally noticed on my jpackage options I wa

Re: RFR: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

2023-01-03 Thread Alexey Ivanov
On Tue, 11 Oct 2022 14:17:42 GMT, Manukumar V S wrote: > java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS > machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as > adding some stability improvements fixes the issue. It intermittently fails > in CI

Re: RFR: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

2023-01-03 Thread Alexey Ivanov
On Tue, 29 Nov 2022 01:07:11 GMT, Damon Nguyen wrote: >> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS >> machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as >> adding some stability improvements fixes the issue. It intermittently fails >> in

Re: RFR: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

2023-01-03 Thread Alexey Ivanov
On Tue, 11 Oct 2022 14:17:42 GMT, Manukumar V S wrote: > java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS > machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as > adding some stability improvements fixes the issue. It intermittently fails > in CI

Re: RFR: 7175396: The text on label is not painted red for Nimbus LaF. [v2]

2023-01-03 Thread Abhishek Kumar
On Tue, 3 Jan 2023 07:39:27 GMT, Prasanta Sadhukhan wrote: >> Label.foreground UIProperty is not honored by Nimbus L&F. It needs to be >> Label[Enabled].textForeground which is the corresponding Synth property >> Added support for setting JLabel foreground color for Nimbus L&F > > Prasanta Sadh

Re: RFR: 8299430: Cleanup: delete unnecessary semicolons in java.desktop module

2023-01-03 Thread Ajit Ghaisas
On Mon, 2 Jan 2023 07:20:43 GMT, Sergey Bylokhov wrote: > Small cleanup, unnecessary semicolons are deleted here and there. I see that this PR touches only java files. A few native files have these type of typos as well. I think, it is worth cleaning them as well. - PR: https://gi

Re: RFR: 8299306: Test "javax/swing/JFileChooser/FileSystemView/CustomFSVLinkTest.java" fails on Windows 10 x64 because there are some buttons did not display button name

2023-01-03 Thread Tejesh R
On Tue, 3 Jan 2023 09:05:54 GMT, Prasanta Sadhukhan wrote: >> Any idea why "Open" button is not shown whereas "Cancel" button is shown? >> Seems to be some product issue w.r.t button size for "Open" button... > >> @prsadhuk the size issue isn't affecting anything since it is disabled >> inside

Re: RFR: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not [v2]

2023-01-03 Thread Anto J
> This test case verifies that Undecorated Frame can be iconified or not > Using mouse click events generated WINDOW_ACTIVATED, WINDOW_ICONIFIED, > WINDOW_DEACTIVATED, and WINDOW_DEICONIFIED and tested whether it is iconified > or not. Anto J has updated the pull request incrementally with one a

Re: RFR: 8299306: Test "javax/swing/JFileChooser/FileSystemView/CustomFSVLinkTest.java" fails on Windows 10 x64 because there are some buttons did not display button name

2023-01-03 Thread Prasanta Sadhukhan
On Tue, 3 Jan 2023 08:28:16 GMT, Prasanta Sadhukhan wrote: >> When JFilechooser is added to a frame, the control buttons are disabled. >> Since in the test the control buttons are not required since JFilechooser is >> added to a JFrame and in turn frame disposal is handled by PassFailJFrame.

Re: RFR: 8299306: Test "javax/swing/JFileChooser/FileSystemView/CustomFSVLinkTest.java" fails on Windows 10 x64 because there are some buttons did not display button name

2023-01-03 Thread Tejesh R
On Tue, 3 Jan 2023 08:28:16 GMT, Prasanta Sadhukhan wrote: >> When JFilechooser is added to a frame, the control buttons are disabled. >> Since in the test the control buttons are not required since JFilechooser is >> added to a JFrame and in turn frame disposal is handled by PassFailJFrame.

Re: RFR: 8299306: Test "javax/swing/JFileChooser/FileSystemView/CustomFSVLinkTest.java" fails on Windows 10 x64 because there are some buttons did not display button name

2023-01-03 Thread Tejesh R
On Tue, 3 Jan 2023 08:28:16 GMT, Prasanta Sadhukhan wrote: > Any idea why "Open" button is not shown whereas "Cancel" button is shown? > Seems to be some product issue w.r.t button size for "Open" button... Didn't analyse it yet. Thought of handling that as a separate issue. Since in this tes

Re: RFR: 8299306: Test "javax/swing/JFileChooser/FileSystemView/CustomFSVLinkTest.java" fails on Windows 10 x64 because there are some buttons did not display button name

2023-01-03 Thread Prasanta Sadhukhan
On Tue, 3 Jan 2023 07:08:13 GMT, Tejesh R wrote: > When JFilechooser is added to a frame, the control buttons are disabled. > Since in the test the control buttons are not required since JFilechooser is > added to a JFrame and in turn frame disposal is handled by PassFailJFrame. > The fix is t