> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated for a constructor `A()` in a class `A`
> when the
> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated for a constructor `A()` in a class `A`
> when the
On Sat, 7 Jan 2023 18:03:04 GMT, Alan Bateman wrote:
> I don't think the implementation notes should be included as part of the
> adding the lint warning as I think it creates an attractive nuisance.
I agree with you - not only for that reason, but also because as others have
pointed out the
On Fri, 6 Jan 2023 23:08:27 GMT, Archie L. Cobbs wrote:
> I've moved the `@SuppressWarnings` annotations onto a new branch
> `ThisEscapeAnnotations`. This is just for future reference in case somebody
> wants to add them back someday and doesn't want to start from scratch.
>
> > I suspect
> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated for a constructor `A()` in a class `A`
> when the
On Fri, 6 Jan 2023 23:13:09 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is
On Fri, 6 Jan 2023 12:59:40 GMT, Prasanta Sadhukhan
wrote:
> Also, looking at other Synth classes, it seems to be the way to go to
> maintain consistency
But I think we should understand what goes wrong when we pass current values,
and what we fix by this change.
-
PR: