On Fri, 23 Dec 2022 19:48:02 GMT, Abhishek Kumar wrote:
>> Reported broken links are updated accordingly.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Links and spec version update
Marked as reviewed by serb (Reviewer
On Mon, 9 Jan 2023 03:57:17 GMT, Prasanta Sadhukhan
wrote:
>> Some methods and constants has a hyperreference to self in javadoc which is
>> rectified to reference proper methods
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revis
On Thu, 22 Dec 2022 10:01:02 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from awt.dll.
>
> The exports were introduced in e4c9db984fe1a3a9d06fb60e333e92df3b165454, and
> as far as I could tell, they were never used; the exported functions are only
>
On Thu, 22 Dec 2022 10:01:02 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from awt.dll.
>
> The exports were introduced in e4c9db984fe1a3a9d06fb60e333e92df3b165454, and
> as far as I could tell, they were never used; the exported functions are only
>
On Sun, 8 Jan 2023 09:09:56 GMT, Sergey Bylokhov wrote:
>>> Did we check how the native code works w/o using JFileChooser, buy
>>> FileSystemView, or by the native example? Is it possible that it is
>>> intermittent because of timing related to "com" thread?
>>
>>
>>
>>>
>>
>> I have teste
On Mon, 9 Jan 2023 17:47:41 GMT, Damon Nguyen wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 93:
>
>> 91:
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is returned as Button string the Button size is incorrectly
On Mon, 9 Jan 2023 18:49:23 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java
>> line 413:
>>
>>> 411: helpButtonText =
>>> UIManager.getString("FileChooser.helpButtonText",l);
>>> 412: directoryOpenButtonText =
>>> UI
On Mon, 9 Jan 2023 10:24:49 GMT, Tejesh R wrote:
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is return
On Mon, 9 Jan 2023 18:59:52 GMT, Alexey Ivanov wrote:
>
> If the programmer uses `CUSTOM_DIALOG`, they are responsible for setting the
> text and, if required, tooltip for the approve button, which is implied by
> the required `approveButtonText` parameter to
> [JFileChooser.showDialog](ht
On Mon, 12 Dec 2022 01:49:23 GMT, Sergey Bylokhov wrote:
> The code from `AccessibilityGraphicsEnvironment` is moved/merged back to the
> `SunGraphicsEnvironment` from where it was initially
> [copied](https://github.com/openjdk/jdk18/pull/72#issuecomment-1001050200).
> The required API is exp
On Thu, 22 Dec 2022 10:01:02 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from awt.dll.
>
> The exports were introduced in e4c9db984fe1a3a9d06fb60e333e92df3b165454, and
> as far as I could tell, they were never used; the exported functions are only
>
On Mon, 9 Jan 2023 10:24:49 GMT, Tejesh R wrote:
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is return
On Mon, 9 Jan 2023 17:28:36 GMT, Damon Nguyen wrote:
>> FileChooser Open/Approve button size is shown incorrectly when no Approve
>> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
>> Approve Button text is returned during Dialog Type Property change. Since
>> `null` i
On Sun, 8 Jan 2023 09:09:56 GMT, Sergey Bylokhov wrote:
>>> Did we check how the native code works w/o using JFileChooser, buy
>>> FileSystemView, or by the native example? Is it possible that it is
>>> intermittent because of timing related to "com" thread?
>>
>>
>>
>>>
>>
>> I have teste
On Mon, 9 Jan 2023 10:24:49 GMT, Tejesh R wrote:
> FileChooser Open/Approve button size is shown incorrectly when no Approve
> button text is set in `CUSTOM_DIALOG` type. Reason being that no default
> Approve Button text is returned during Dialog Type Property change. Since
> `null` is return
On Mon, 9 Jan 2023 09:59:04 GMT, Andrey Turbanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> frame changed back to decorated and exclude on linux
>
> test/jdk/java/awt/FullScreen/FullScreenInsets/FullScreenI
On Wed, 7 Dec 2022 09:20:34 GMT, Sergey Bylokhov wrote:
> On Windows, it does not work as well if a non-accelerated java2d pipeline is
> selected. You can test that by using this option: `-Dsun.java2d.d3d=false`
Or rather try with `-Dsun.java2d.d3d=True` and check if Direct3D is enabled. If
it
On Thu, 22 Dec 2022 22:02:39 GMT, Harshitha Onkar wrote:
> > Why can't we scan all the pixels? It was the purpose of the test to ensure
> > each window has the exact color. Does it take very long time?
>
> There isn't a significant time difference but I think it might be a better
> and efficie
On Wed, 4 Jan 2023 19:33:01 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains ten commits:
>>
>> - minor changes
>> - Merge branch 'master' into RefactorBorder_8294484
>> - Merge branc
On Mon, 9 Jan 2023 10:17:01 GMT, Prasanta Sadhukhan
wrote:
> I dont think there is any difference between passing method argument
> vis-a-vis this as I think both point to same object..
Are you sure that it is always the same? Right now we ignore the component
passed from the SynthListUI.prop
On Fri, 6 Jan 2023 22:02:38 GMT, Sergey Bylokhov wrote:
>> This assertion happens when we try to build the path linked by the shortcut
>> file when part of that path is not accessible. For example, if the ".lnk"
>> file is pointed to the "windows-update. settings" inside the
>> "Internet.setti
Note that fixes aren't accepted as patches.
You need to submit a github PR after signing the OCA and getting it
recorded.
https://openjdk.org/contribute/
However I've re-opened this bug (I do not understand why it was closed) and
assigned to someone might be able to find time to take care of it
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to ge
The getRGBdefault() was made thread safe via holder implemented as a local
interface.
-
Commit messages:
- Update RGBdefaultSingleton.java
- the test
- 8299772: The ColorModel.getRGBdefault() method is not thread-safe
Changes: https://git.openjdk.org/jdk/pull/11895/files
Webrev:
FileChooser Open/Approve button size is shown incorrectly when no Approve
button text is set in `CUSTOM_DIALOG` type. Reason being that no default
Approve Button text is returned during Dialog Type Property change. Since
`null` is returned as Button string the Button size is incorrectly shown. T
On Mon, 9 Jan 2023 06:37:22 GMT, David Holmes wrote:
> All your new files need a copyright and GPL header.
Sorry if I'm being blind but I'm not seeing it. Which file(s) are you referring
to?
The `@test /nodynamiccopyright/` files don't get one per
[this](https://openjdk.org/groups/compiler/te
On Mon, 2 Jan 2023 08:24:44 GMT, Prasanta Sadhukhan
wrote:
> This is a revert of commit
> https://github.com/openjdk/jdk/commit/415bf44191632cd8dbcc158c0ff0992c0b61c3ba
> which was a fix for 8275715: D3D pipeline processes multiple PaintEvent at
> initial drawing
> as it is causing some repai
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to ge
On Thu, 29 Dec 2022 06:22:01 GMT, Prasanta Sadhukhan
wrote:
>> Spec for
>> [MetalLookAndFeel](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L247)
>> says:
>> "...MetalLookAndFeel registers an entry for each of the classes
On Mon, 5 Dec 2022 22:10:15 GMT, Harshitha Onkar wrote:
>> The above test was failing due to incorrect pixel color and wrong window
>> bounds on Mac-ARM, Windows and Linux platforms.
>>
>> The following changes have been made:
>> - Correct window bounds are obtained using the current ScreenDevi
31 matches
Mail list logo
