Re: RFR: 8293478: [java.desktop/macOS] Condense SDRenderType usages in QuartzRenderer.m [v3]

2023-01-14 Thread SWinxy
On Sun, 25 Sep 2022 18:00:39 GMT, SWinxy wrote: >> The `SDRenderType` enum is often returned using a variable declared at the >> start of functions. These can be inlined in the `return` itself. Using a >> ternary operator condenses what may be 12 lines into one, in the most >> extreme cases. `

Re: RFR: 7131166: SynthListUI / SynthInternalFrameTitlePane updateStyle() ignores method argument

2023-01-14 Thread SWinxy
On Wed, 11 Jan 2023 07:52:13 GMT, Sergey Bylokhov wrote: > Is it possible to change the current UI style based on the context from the > separate component? Looks like it. It _could_ be addressed by passing the `list` object into `SynthListUI#updateStyle` instead. Or by making these classes no

Re: RFR: 8300169: Build failure with clang-15

2023-01-14 Thread Jie Fu
On Sat, 14 Jan 2023 15:03:42 GMT, Kevin Rushforth wrote: > Normally, such changes in third-party libraries need to be done upstream, and > not locally. @prrace can confirm. Thanks @kevinrushforth for your review. Yes, it had been fixed in the upstream and I just follow it. Please see https://g

Re: RFR: 8300169: Build failure with clang-15

2023-01-14 Thread Kevin Rushforth
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2) src/hotspot/share/runtime/notificationThre

RFR: 8300169: Build failure with clang-15

2023-01-14 Thread Jie Fu
Hi all, Please review the fix for the build failure with clang-15. 1. -Wbitwise-instead-of-logical 1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the warning 2) src/hotspot/share/runtime/notificationThread.cpp <--- keep the code and disable warnings 3) src/hotspot/s