Integrated: 8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs

2023-01-23 Thread Tingjun Yuan
On Sat, 21 Jan 2023 02:55:29 GMT, Tingjun Yuan wrote: > API docs of `java.awt.image.renderable.ParameterBlock` and > `java.awt.font.LineBreakMeasurer` used deprecated constructors of > `java.lang.Short` and `java.lang.Float`. > > Replacing by `valueOf` factory methods. This pull request has n

Integrated: 8300828: Avoid unnecessary array fill after creation in com.sun.media.sound

2023-01-23 Thread Andrey Turbanov
On Sat, 21 Jan 2023 19:44:39 GMT, Andrey Turbanov wrote: > No need to fill elements of array with default values if it was just created. > Java guarantees that all elements of array have default values after > allocations: boolean - `false`, reference types - `null`, double - `0.` This pull re

Re: RFR: 8300929: Avoid unnecessary array fill after creation in java.awt.image

2023-01-23 Thread SWinxy
On Mon, 23 Jan 2023 17:20:41 GMT, Andrey Turbanov wrote: > No need to fill elements of array with default values if it was just created. > Java guarantees that all elements of numeric array have default values after > allocations - 0. Marked as reviewed by swi...@github.com (no known OpenJDK u

RFR: 8300929: Avoid unnecessary array fill after creation in java.awt.image

2023-01-23 Thread Andrey Turbanov
No need to fill elements of array with default values if it was just created. Java guarantees that all elements of numeric array have default values after allocations - 0. - Commit messages: - [PATCH] Avoid unnecessary array fill after creation in java.awt.image Changes: https://g

Re: RFR: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF [v3]

2023-01-23 Thread Phil Race
On Fri, 20 Jan 2023 22:45:32 GMT, Damon Nguyen wrote: >> The fixed height causes the titled border insets to reserve a majority of >> the height available for the component. This fixed height is meant for the >> default AquaComboBox usage, so the old default height is more applicable >> when a

Re: RFR: 7131166: SynthListUI / SynthInternalFrameTitlePane updateStyle() ignores method argument

2023-01-23 Thread SWinxy
On Mon, 23 Jan 2023 06:11:46 GMT, Prasanta Sadhukhan wrote: > I think it was mistakenly done I agree. All classes would probably be fine if their code only referenced their protected object instead of the `e.getSource()` one. If they aren't, then that means there are bugs elsewhere.

Re: RFR: 8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs

2023-01-23 Thread Phil Race
On Sat, 21 Jan 2023 02:55:29 GMT, Tingjun Yuan wrote: > API docs of `java.awt.image.renderable.ParameterBlock` and > `java.awt.font.LineBreakMeasurer` used deprecated constructors of > `java.lang.Short` and `java.lang.Float`. > > Replacing by `valueOf` factory methods. This won't need a CSR

Re: RFR: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF [v2]

2023-01-23 Thread Damon Nguyen
On Mon, 23 Jan 2023 06:31:36 GMT, Prasanta Sadhukhan wrote: >> Adding 1 to the height would go back to the previous implementation, but it >> actually causes the comboBox to look more misaligned by 1 extra pixel. I can >> re-add the +1 to return to the original method if preferred. >> >> > sr

Re: RFR: 8300828: Avoid unnecessary array fill after creation in com.sun.media.sound

2023-01-23 Thread Phil Race
On Sat, 21 Jan 2023 19:44:39 GMT, Andrey Turbanov wrote: > No need to fill elements of array with default values if it was just created. > Java guarantees that all elements of array have default values after > allocations: boolean - `false`, reference types - `null`, double - `0.` Marked as re

Integrated: 8244400: MenuItem may cache the size and did not update it when the screen DPI is changed

2023-01-23 Thread Prasanta Sadhukhan
On Wed, 7 Dec 2022 03:48:16 GMT, Prasanta Sadhukhan wrote: > The MenuItemLayoutHelper.clearUsedParentClientProperties must be called > automatically when the DPI was changed. > Workaround added in the test for this bug is removed. > > CI tests are ok. This pull request has now been integrate