Re: RFR: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distributive [v2]

2023-01-27 Thread SWinxy
On Fri, 27 Jan 2023 17:00:48 GMT, Alexander Scherbatiy wrote: >> [JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font >> coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE >> detection by checking SLES os name property in `/etc/os-release` file. >> >>

Withdrawn: 8298042: Fix hidden but significant trailing whitespace in properties files for client code

2023-01-27 Thread duke
On Fri, 2 Dec 2022 16:38:54 GMT, Magnus Ihse Bursie wrote: > According to [the > specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) > trailing whitespaces in the values of properties files are (somewhat > surprisingly) ac

[jdk20] Integrated: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF

2023-01-27 Thread Damon Nguyen
On Fri, 27 Jan 2023 02:40:27 GMT, Damon Nguyen wrote: > Fixes regression bug where Aqua L&F editable JComboBox with a TitledBorder > was not visible. > > This fix adds a conditional that addresses cases where a border is used on an > AquaComboBox. The patch that caused the issue set a static

Integrated: Merge jdk20

2023-01-27 Thread Jesper Wilhelmsson
On Fri, 27 Jan 2023 21:00:03 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: 5c59de52 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/5c59de52a31da937663ad2cef055213489b0516e Stats: 1078 lines

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v24]

2023-01-27 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.openjdk

Re: [jdk20] RFR: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF [v2]

2023-01-27 Thread Phil Race
On Fri, 27 Jan 2023 10:14:51 GMT, Damon Nguyen wrote: >> Fixes regression bug where Aqua L&F editable JComboBox with a TitledBorder >> was not visible. >> >> This fix adds a conditional that addresses cases where a border is used on >> an AquaComboBox. The patch that caused the issue set a st

RFR: Merge jdk20

2023-01-27 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8301206: Fix issue with LocaleData after JDK-8300719 - 8300953: ClassDesc::ofInternalName missing @since tag - 8300719: JDK 20 RDP2 L10n resource files update The webr

Re: RFR: 8300891: Deprecate for removal javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) [v3]

2023-01-27 Thread Phil Race
On Fri, 27 Jan 2023 20:22:48 GMT, Phil Race wrote: >> SynthLookAndFeel.load(URL) is problematic because applications need to trust >> the URL. >> As documented in the bug report there are alternative mechanisms and JDK >> itself has not used this for the two Synth based L&Fs : Nimbus and GTK. >

Re: [jdk20] RFR: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF [v2]

2023-01-27 Thread Alisen Chung
On Fri, 27 Jan 2023 10:14:51 GMT, Damon Nguyen wrote: >> Fixes regression bug where Aqua L&F editable JComboBox with a TitledBorder >> was not visible. >> >> This fix adds a conditional that addresses cases where a border is used on >> an AquaComboBox. The patch that caused the issue set a st

Re: RFR: 8300891: Deprecate for removal javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) [v3]

2023-01-27 Thread Phil Race
> SynthLookAndFeel.load(URL) is problematic because applications need to trust > the URL. > As documented in the bug report there are alternative mechanisms and JDK > itself has not used this for the two Synth based L&Fs : Nimbus and GTK. > So deprecating - for removal - and adding warnings now i

Withdrawn: 8296546: Add @spec tags to API

2023-01-27 Thread duke
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote: > Please review a "somewhat automated" change to insert `@spec` tags into doc > comments, as appropriate, to leverage the recent new javadoc feature to > generate a new page listing the references to all external specifications > listed

Re: [jdk20] RFR: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF [v2]

2023-01-27 Thread Alexander Zuev
On Fri, 27 Jan 2023 10:14:51 GMT, Damon Nguyen wrote: >> Fixes regression bug where Aqua L&F editable JComboBox with a TitledBorder >> was not visible. >> >> This fix adds a conditional that addresses cases where a border is used on >> an AquaComboBox. The patch that caused the issue set a st

Re: RFR: 6817009: Action.SELECTED_KEY not toggled when using key binding

2023-01-27 Thread SWinxy
On Fri, 27 Jan 2023 10:26:10 GMT, Prasanta Sadhukhan wrote: > When the Action.SELECTED_KEY property action is assigned to ToggleButton and > an accelerator key binding is mapped to the action, then pressing the > accelerator key binding does not toggle the toggle button. > This is because Swin

client-libs-dev@openjdk.org

2023-01-27 Thread Abhishek Kumar
On Fri, 13 Jan 2023 04:25:59 GMT, Prasanta Sadhukhan wrote: > It is observed that if SwingSet2 is run in Nimbus L&F and > we drag the icon tool bar (which is floatable) out of the GUI Window > and Once the tool bar is detached, click on "Look & Feel" menu option to > change to any L&F (say Jav

Re: RFR: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distributive [v2]

2023-01-27 Thread Alexander Scherbatiy
> [JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font > coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE > detection by checking SLES os name property in `/etc/os-release` file. > > `opensuse/leap:15.4` docker defines os name property as `"openSUSE Le

RFR: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distributive

2023-01-27 Thread Alexander Scherbatiy
[JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE detection by checking SLES os name property in `/etc/os-release` file. `opensuse/leap:15.4` docker defines os name property as `"openSUSE Leap"` in `

Re: RFR: 6817009: Action.SELECTED_KEY not toggled when using key binding

2023-01-27 Thread Tejesh R
On Fri, 27 Jan 2023 10:26:10 GMT, Prasanta Sadhukhan wrote: > When the Action.SELECTED_KEY property action is assigned to ToggleButton and > an accelerator key binding is mapped to the action, then pressing the > accelerator key binding does not toggle the toggle button. > This is because Swin

Re: RFR: 8300891: Deprecate for removal javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) [v2]

2023-01-27 Thread Alexey Ivanov
On Fri, 27 Jan 2023 03:38:50 GMT, Prasanta Sadhukhan wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8300891 > > src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java > line 627: > >> 625:

Re: RFR: 8300891: Deprecate for removal javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) [v2]

2023-01-27 Thread Alexey Ivanov
On Thu, 26 Jan 2023 20:21:24 GMT, Phil Race wrote: >> SynthLookAndFeel.load(URL) is problematic because applications need to trust >> the URL. >> As documented in the bug report there are alternative mechanisms and JDK >> itself has not used this for the two Synth based L&Fs : Nimbus and GTK. >

Integrated: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case

2023-01-27 Thread Tejesh R
On Wed, 18 Jan 2023 06:37:30 GMT, Tejesh R wrote: > This is a diagnostic update related to > [JDK-8295804](https://bugs.openjdk.org/browse/JDK-8295804). The issue was not > reproducible and was showing up in particular machines (Where the machines > are down now). So adding a screen capture to

Re: RFR: 8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor

2023-01-27 Thread Abhishek Kumar
On Wed, 25 Jan 2023 08:32:33 GMT, Prasanta Sadhukhan wrote: > Issue seems to be very old, very intermittent bug which is not reproducible > in repeated test run, > so added some stability fixes like accessing swing components in EDT, delay, > frame dispose and take a screenshot during fail. >

Re: RFR: 8297454: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to show opaque button"

2023-01-27 Thread Tejesh R
On Wed, 25 Jan 2023 06:41:19 GMT, Prasanta Sadhukhan wrote: > Test intermittently failed in CI macos system owing to robot screencapture > failing to compare the images. > Seems like from artifacts, that composite image created by robot contains > mouse cursor, which when compared are not givi

Re: [jdk20] RFR: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF [v2]

2023-01-27 Thread Prasanta Sadhukhan
On Fri, 27 Jan 2023 10:14:51 GMT, Damon Nguyen wrote: >> Fixes regression bug where Aqua L&F editable JComboBox with a TitledBorder >> was not visible. >> >> This fix adds a conditional that addresses cases where a border is used on >> an AquaComboBox. The patch that caused the issue set a st

RFR: 6817009: Action.SELECTED_KEY not toggled when using key binding

2023-01-27 Thread Prasanta Sadhukhan
When the Action.SELECTED_KEY property action is assigned to ToggleButton and an accelerator key binding is mapped to the action, then pressing the accelerator key binding does not toggle the toggle button. This is because SwingUtilities.notifyAction does not fire itemStateChanged event for such

Re: [jdk20] RFR: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF [v2]

2023-01-27 Thread Damon Nguyen
On Fri, 27 Jan 2023 07:19:43 GMT, Prasanta Sadhukhan wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change return to continue > > test/jdk/javax/swing/JComboBox/JComboBoxWithTitledBorderTest.java line 76: > >> 7

Re: [jdk20] RFR: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF [v2]

2023-01-27 Thread Damon Nguyen
> Fixes regression bug where Aqua L&F editable JComboBox with a TitledBorder > was not visible. > > This fix adds a conditional that addresses cases where a border is used on an > AquaComboBox. The patch that caused the issue set a static height, but this > height caused issues with a TitledBo

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v2]

2023-01-27 Thread Abhishek Kumar
On Fri, 27 Jan 2023 04:25:48 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> i