Re: RFR: JDK-7154070: in SwingSet2, switching between LaFs it's easy to lose JTable dividers [v4]

2023-02-05 Thread Jayathirth D V
On Thu, 2 Feb 2023 17:39:53 GMT, Prasanta Sadhukhan wrote: >> In SwingSet2 in TableDemo, we can see grid dividers in Metal L&F but >> if we Switch to the Nimbus LaF which has no grid dividers by default and >> then if we switch to Java (Metal): it will show no dividers. >> >> Issue is Nimbus

Re: RFR: 7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color [v3]

2023-02-05 Thread Abhishek Kumar
On Fri, 3 Feb 2023 19:56:18 GMT, Damon Nguyen wrote: >> Before the fix, a JComboBox in Nimbus L&F would have normal black text even >> when the JComboBox was disabled if SynthComboBoxRenderer was replaced with a >> DefaultListCellRenderer. This text should be greyed out like in other L&F's. >>

Re: RFR: 8297454: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to show opaque button"

2023-02-05 Thread Jayathirth D V
On Wed, 25 Jan 2023 06:41:19 GMT, Prasanta Sadhukhan wrote: > Test intermittently failed in CI macos system owing to robot screencapture > failing to compare the images. > Seems like from artifacts, that composite image created by robot contains > mouse cursor, which when compared are not givi

client-libs-dev@openjdk.org

2023-02-05 Thread Jayathirth D V
On Fri, 13 Jan 2023 04:25:59 GMT, Prasanta Sadhukhan wrote: > It is observed that if SwingSet2 is run in Nimbus L&F and > we drag the icon tool bar (which is floatable) out of the GUI Window > and Once the tool bar is detached, click on "Look & Feel" menu option to > change to any L&F (say Jav

Re: RFR: 8301443: Clean broken comments from Windows code [v2]

2023-02-05 Thread Julian Waters
On Sun, 5 Feb 2023 17:26:29 GMT, Weijun Wang wrote: >> I've just tried copying and pasting the command with ^ instead of \ and cmd >> doesn't seem to be correctly reading the compile command either even with ^, >> is there something I'm missing here? > > I don't know. I'm quite sure I was using

Re: RFR: 8301443: Clean broken comments from Windows code [v4]

2023-02-05 Thread Julian Waters
> Several comments are technically broken in Windows code, this change cleans > up the broken comments that managed to slip past reviewers during Integration Julian Waters has updated the pull request incrementally with one additional commit since the last revision: sspi.cpp - C

Re: RFR: 8301820: C4819 warnings were reported on Windows

2023-02-05 Thread David Holmes
On Sat, 4 Feb 2023 09:42:57 GMT, Yasumasa Suenaga wrote: > C4819 warnings were reported when I tried to build JDK on Windows with VS2022. > This PR contains changes both HotSpot and client libraries. Let me know if > they should be separated. > > * HotSpot > * stubGenerator_x86_64_poly.cpp

Re: Enhancing java2d Image classes & pipelines to support HDR (10b) or 16bits RGBA

2023-02-05 Thread SWinxy
I support this! HDR support would be nice, but if there are issues with color spaces, that to me is a higher priority. What do you mean to fix in the macros and graphics pipelines? On Thu, Jan 26, 2023 at 5:11 AM Laurent Bourgès wrote: > Hi, > > I would like enhancing Java Image classes (awt /

Re: RFR: 8301443: Clean broken comments from Windows code [v2]

2023-02-05 Thread Weijun Wang
On Sun, 5 Feb 2023 15:55:29 GMT, Julian Waters wrote: >> I used to have Visual Studio compilers available in my Cygwin environment. >> Now I don't, I just point the `configure` script to the batch file which >> configures the environment. >> >> If this command is supposed to be run in `cmd.exe

Re: RFR: 8301443: Clean broken comments from Windows code [v3]

2023-02-05 Thread Julian Waters
> Several comments are technically broken in Windows code, this change cleans > up the broken comments that managed to slip past reviewers during Integration Julian Waters has updated the pull request incrementally with one additional commit since the last revision: awt_Toolkit.cpp -

Re: RFR: 8301443: Clean broken comments from Windows code [v2]

2023-02-05 Thread Julian Waters
On Sat, 4 Feb 2023 17:23:04 GMT, Alexey Ivanov wrote: >> I have no objection to the code change. Or maybe you can change it to the >> windows line extension character `^`. >> >> I was using this command for quick recompiling while writing this code, and >> it's in a `cmd.exe` window launched w

Re: RFR: JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color [v13]

2023-02-05 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded > Color](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8293776) > > This is tracked in JBS as > - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded > Color](https://bugs.openjdk.java.net/brow

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v26]

2023-02-05 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.openjdk

Re: RFR: 8301828: Avoid unnecessary array fill after creation in javax.swing.text

2023-02-05 Thread Sergey Bylokhov
On Thu, 26 Jan 2023 20:58:45 GMT, Andrey Turbanov wrote: > No need to fill elements of array with default values if it was just created. > Java guarantees that all elements of numeric array have default values after > allocations - 0. Looks fine. - PR: https://git.openjdk.org/jdk

Re: RFR: 8301828: Avoid unnecessary array fill after creation in javax.swing.text

2023-02-05 Thread SWinxy
On Thu, 26 Jan 2023 20:58:45 GMT, Andrey Turbanov wrote: > No need to fill elements of array with default values if it was just created. > Java guarantees that all elements of numeric array have default values after > allocations - 0. Marked as reviewed by swi...@github.com (no known OpenJDK u

RFR: 8301828: Avoid unnecessary array fill after creation in javax.swing.text

2023-02-05 Thread Andrey Turbanov
No need to fill elements of array with default values if it was just created. Java guarantees that all elements of numeric array have default values after allocations - 0. - Commit messages: - [PATCH] Avoid unnecessary array fill after creation in javax.swing.text Changes: https:/

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v23]

2023-02-05 Thread ScientificWare
On Wed, 25 Jan 2023 22:13:16 GMT, Alexey Ivanov wrote: >> Still waiting a review. > > @scientificware could you put your suggested text into the code change? I > mean incorporate into the PR itself. > > Is it necessary to have the _long_ sample code? > >> @aivanov-jdk Can we dissociate the rel

Integrated: 8301342: Prefer ArrayList to LinkedList in LayoutComparator

2023-02-05 Thread Andrey Turbanov
On Sat, 28 Jan 2023 14:54:38 GMT, Andrey Turbanov wrote: > There is only add/iterator calls on this list. No removes from the head or > something like this. Not sure why LinkedList was used, but ArrayList should > be preferred as more efficient and widely used (more chances for JIT) > collecti

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v25]

2023-02-05 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.openjdk