Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus [v2]

2023-02-09 Thread Alexander Zuev
On Thu, 9 Feb 2023 19:42:09 GMT, Sergey Bylokhov wrote: >> src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java line 373: >> >>> 371: // --- FocusListener methods -- >>> 372: >>> 373: /** >> >> I guess everybody noticed the specification of this met

Re: RFR: 8301616: Drag & maximize to another monitor places window incorrectly (Windows)

2023-02-09 Thread Nikita Gubarkov
On Fri, 3 Feb 2023 06:09:50 GMT, Sergey Bylokhov wrote: >> Maximized bounds are treated as absolute virtual screen coordinates, when >> maximized, window will be reshaped to that specific bounds no matter what >> monitor it is currently on. That is, when dragging to fullscreen from >> monitor

Re: RFR: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished [v14]

2023-02-09 Thread Alexey Ivanov
On Wed, 8 Feb 2023 09:46:21 GMT, Prasanta Sadhukhan wrote: >> SwingWorker done() method [spec >> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452) >> says "Executed on the Event Dispatch Thread after the doInBackground method >> is

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v5]

2023-02-09 Thread Alexey Ivanov
On Thu, 9 Feb 2023 02:59:11 GMT, Prasanta Sadhukhan wrote: >> Issue is observed that after changing the Look & Feel from Metal to Nimbus >> and back to Metal, the Nimbus font continues to be used by a JFileChooser. >> This is because Synth `installDefaults `methods set the font, but its >> in

Re: RFR: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished [v10]

2023-02-09 Thread Alexey Ivanov
On Thu, 9 Feb 2023 20:24:18 GMT, Alexey Ivanov wrote: >>> The specification isn't clear, and some parts somewhat contradict each >>> other. Logically, the state should transition to DONE as soon as >>> doInBackground completes. Then both done method and listeners are called >>> when the state

Re: RFR: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished [v10]

2023-02-09 Thread Alexey Ivanov
On Wed, 8 Feb 2023 01:22:52 GMT, Sergey Bylokhov wrote: > > The specification isn't clear, and some parts somewhat contradict each > > other. Logically, the state should transition to `DONE` as soon as > > `doInBackground` completes. Then both done method and listeners are called > > when the

Re: RFR: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished [v13]

2023-02-09 Thread Alexey Ivanov
On Wed, 8 Feb 2023 05:45:43 GMT, Prasanta Sadhukhan wrote: > > Since a CSR is required, I suggest updating the spec for `isDone` method so > > that it returns `true` only after `doInBackground` exits. Now `isDone` > > returns `true` after `cancel` completes but the `DONE` state isn't reached

Re: RFR: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished [v14]

2023-02-09 Thread Alexey Ivanov
On Wed, 8 Feb 2023 09:46:21 GMT, Prasanta Sadhukhan wrote: >> SwingWorker done() method [spec >> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452) >> says "Executed on the Event Dispatch Thread after the doInBackground method >> is

Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus [v2]

2023-02-09 Thread Sergey Bylokhov
On Fri, 23 Dec 2022 23:03:17 GMT, Sergey Bylokhov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Simplifying the two nested if conditions into one. > > src/java.desktop/share/classes/javax/swing/text/DefaultCare

Integrated: 8272288: Funky multiresolution image breaks graphics context

2023-02-09 Thread Sergey Bylokhov
On Wed, 14 Dec 2022 08:20:31 GMT, Sergey Bylokhov wrote: > This is the next iteration of fixing the issue of rendering "broken" image. > The fix for [JDK-7183828](https://bugs.openjdk.org/browse/JDK-7183828) > changed the possible IllegalArgumentException during rendering to the > InvalidPipeE

Integrated: 8301822: BasicLookAndFeel does not need to check for null after checking for type

2023-02-09 Thread SWinxy
On Mon, 16 Jan 2023 20:30:08 GMT, SWinxy wrote: > BasicLookAndFeel checks an instanceof in its `AWTEventHelper` listener class, > but the result of that will always be non-null. The check should be removed. This pull request has now been integrated. Changeset: 597a9a48 Author:SWinxy Commi

Integrated: Merge jdk20

2023-02-09 Thread Jesper Wilhelmsson
On Thu, 9 Feb 2023 07:43:28 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: af8973dc Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/af8973dc509c1f326223e3ffd1773c9e930141d8 Stats: 69 lines in

Re: RFR: 8302120: Prefer ArrayList to LinkedList in AggregatePainter

2023-02-09 Thread Sergey Bylokhov
On Fri, 27 Jan 2023 13:26:28 GMT, Andrey Turbanov wrote: > There is only add/iterator calls on this list. No removes from the head or > something like this. Not sure why LinkedList was used, but ArrayList should > be preferred as more efficient and widely used (more chances for JIT) > collecti

RFR: 8302120: Prefer ArrayList to LinkedList in AggregatePainter

2023-02-09 Thread Andrey Turbanov
There is only add/iterator calls on this list. No removes from the head or something like this. Not sure why LinkedList was used, but ArrayList should be preferred as more efficient and widely used (more chances for JIT) collection - Commit messages: - [PATCH] Prefer ArrayList to L