Re: RFR: 8299522: Incorrect size of Approve button in custom JFileChooser [v13]

2023-02-19 Thread Tejesh R
> FileChooser Open/Approve button size is shown incorrectly when no Approve > button text is set in `CUSTOM_DIALOG` type. Reason being that no default > Approve Button text is returned during Dialog Type Property change. Since > `null` is returned as Button string the Button size is incorrectly

Re: RFR: 8302525: Write a test to check various components send Events while mouse and key are used simultaneously [v2]

2023-02-19 Thread Ravi Gupta
> Main aim of this testcase is to test the behavior of various events under > stress. > > This testcase verifies the following assertions > a. This TestCase performs various mouse and key operations on components and > checks whether all the events are getting triggered properly. > b. It also ch

RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme

2023-02-19 Thread Archie L . Cobbs
This bug relates to the "potentially ambiguous overload" warning which is enabled by `-Xlint:overloads`. The warning detects certain ambiguities that can cause problems for lambdas. For example, consider the interface `Spliterator.OfInt`, which declares these two methods: void forEachRemaining

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-19 Thread Julian Waters
On Sun, 19 Feb 2023 09:35:53 GMT, SWinxy wrote: >> Many `installDefaults` methods set the font, foreground, and background on >> objects but their inverse methods `uninstallDefaults` do not remove them. >> I've added an inverse method to remove the colors and font to call for the >> `uninstall

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-19 Thread SWinxy
On Sun, 19 Feb 2023 09:35:53 GMT, SWinxy wrote: >> Many `installDefaults` methods set the font, foreground, and background on >> objects but their inverse methods `uninstallDefaults` do not remove them. >> I've added an inverse method to remove the colors and font to call for the >> `uninstall

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-19 Thread SWinxy
> Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the > `uninstallDefaults` methods that install defaults. > > `AquaBut

Re: RFR: 8302268: Prefer ArrayList to LinkedList in XEmbeddedFramePeer

2023-02-19 Thread Sergey Bylokhov
On Thu, 9 Feb 2023 09:51:10 GMT, Andrey Turbanov wrote: > There is only add/iterator/indexOf calls on this list. No removes from the > head or something like this. ArrayList should be preferred as more efficient > and widely used (more chances for JIT) collection Marked as reviewed by serb (Re