Integrated: 8302151: BMPImageReader throws an exception reading BMP images

2023-02-20 Thread Jayathirth D V
On Wed, 15 Feb 2023 13:18:31 GMT, Jayathirth D V wrote: > We have check in BMPImageReader, where we verify image data size using BMP > file size and bitmap offset value. > But we can't rely on this calculation when we have color palette. Also color > palette is necessary in BMP when bits per pi

Re: RFR: 8302151: BMPImageReader throws an exception reading BMP images

2023-02-20 Thread Tejesh R
On Wed, 15 Feb 2023 13:18:31 GMT, Jayathirth D V wrote: > We have check in BMPImageReader, where we verify image data size using BMP > file size and bitmap offset value. > But we can't rely on this calculation when we have color palette. Also color > palette is necessary in BMP when bits per pi

Integrated: 8299522: Incorrect size of Approve button in custom JFileChooser

2023-02-20 Thread Tejesh R
On Mon, 9 Jan 2023 10:24:49 GMT, Tejesh R wrote: > FileChooser Open/Approve button size is shown incorrectly when no Approve > button text is set in `CUSTOM_DIALOG` type. Reason being that no default > Approve Button text is returned during Dialog Type Property change. Since > `null` is return

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme

2023-02-20 Thread SWinxy
On Sun, 19 Feb 2023 23:52:52 GMT, Archie L. Cobbs wrote: > This bug relates to the "potentially ambiguous overload" warning which is > enabled by `-Xlint:overloads`. > > The warning detects certain ambiguities that can cause problems for lambdas. > For example, consider the interface `Splitera

Re: RFR: 8302838: jabswitch main() should avoid calling exit explicitly

2023-02-20 Thread SWinxy
On Mon, 20 Feb 2023 08:10:54 GMT, Julian Waters wrote: > In jabswitch, main is defined as `void main()`, which requires an explicit > exit call whenever an error occurs, and extra error checking code on our > part. Visual C++ will automatically convert all instances of `void main()` to > retur

Integrated: 8302525: Write a test to check various components send Events while mouse and key are used simultaneously

2023-02-20 Thread Ravi Gupta
On Wed, 15 Feb 2023 12:50:42 GMT, Ravi Gupta wrote: > Main aim of this testcase is to test the behavior of various events under > stress. > > This testcase verifies the following assertions > a. This TestCase performs various mouse and key operations on components and > checks whether all the

Re: RFR: 8302151: BMPImageReader throws an exception reading BMP images

2023-02-20 Thread Sergey Bylokhov
On Wed, 15 Feb 2023 13:18:31 GMT, Jayathirth D V wrote: > We have check in BMPImageReader, where we verify image data size using BMP > file size and bitmap offset value. > But we can't rely on this calculation when we have color palette. Also color > palette is necessary in BMP when bits per pi

Re: RFR: 8302849: SurfaceManager might expose partially constructed object

2023-02-20 Thread Sergey Bylokhov
On Mon, 20 Feb 2023 10:25:34 GMT, Per Minborg wrote: > This PR proposes to add `volatile` to a variable declaration in order to > prevent partially initialized objects to be observed by threads. > > `SurfaceManager` is using a lazily initialized cacheMap that is initialized > using a double-ch

Re: RFR: 8299522: Incorrect size of Approve button in custom JFileChooser [v13]

2023-02-20 Thread Abhishek Kumar
On Mon, 20 Feb 2023 07:13:20 GMT, Tejesh R wrote: >> FileChooser Open/Approve button size is shown incorrectly when no Approve >> button text is set in `CUSTOM_DIALOG` type. Reason being that no default >> Approve Button text is returned during Dialog Type Property change. Since >> `null` is r

Re: Integrated: 8302882: Newly added test javax/swing/JFileChooser/JFileChooserFontReset.java fails with HeadlessException

2023-02-20 Thread Alexey Ivanov
On Mon, 20 Feb 2023 14:38:01 GMT, Prasanta Sadhukhan wrote: > Added key headful to the test test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 25: > 23: /* > 24: * @test > 25: * @bug 6753661 8302882 8302882 shouldn't have been added to bug list. [JDK-8302882](https://bugs.op

Integrated: 8302882: Newly added test javax/swing/JFileChooser/JFileChooserFontReset.java fails with HeadlessException

2023-02-20 Thread Prasanta Sadhukhan
On Mon, 20 Feb 2023 14:38:01 GMT, Prasanta Sadhukhan wrote: > Added key headful to the test This pull request has now been integrated. Changeset: e7316952 Author:Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/e731695217b75fd55dc3e820c3123b8739a19c04 Stats: 2 lines i

Re: Integrated: 8302882: Newly added test javax/swing/JFileChooser/JFileChooserFontReset.java fails with HeadlessException

2023-02-20 Thread Jayathirth D V
On Mon, 20 Feb 2023 14:38:01 GMT, Prasanta Sadhukhan wrote: > Added key headful to the test Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12666

Integrated: 8302882: Newly added test javax/swing/JFileChooser/JFileChooserFontReset.java fails with HeadlessException

2023-02-20 Thread Prasanta Sadhukhan
Added key headful to the test - Commit messages: - 8302882: Newly added test javax/swing/JFileChooser/JFileChooserFontReset.java fails with HeadlessException Changes: https://git.openjdk.org/jdk/pull/12666/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12666&range=00 Iss

Re: RFR: 8299522: Incorrect size of Approve button in custom JFileChooser [v13]

2023-02-20 Thread Alexey Ivanov
On Mon, 20 Feb 2023 07:13:20 GMT, Tejesh R wrote: >> FileChooser Open/Approve button size is shown incorrectly when no Approve >> button text is set in `CUSTOM_DIALOG` type. Reason being that no default >> Approve Button text is returned during Dialog Type Property change. Since >> `null` is r

Re: RFR: 8302525: Write a test to check various components send Events while mouse and key are used simultaneously [v2]

2023-02-20 Thread Ravi Gupta
On Sat, 18 Feb 2023 22:22:29 GMT, Sergey Bylokhov wrote: >> Ravi Gupta has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8302525: Review Fixes > > Marked as reviewed by serb (Reviewer). @mrserb requesting you to please sponsor. -

RFR: 8302849: SurfaceManager might expose partially constructed object

2023-02-20 Thread Per Minborg
This PR proposes to add `volatile` to a variable declaration in order to prevent partially initialized objects to be observed by threads. `SurfaceManager` is using a lazily initialized cacheMap that is initialized using a double-checked locking mechanism. Generally, objects initialized using su

Re: RFR: 8302151: BMPImageReader throws an exception reading BMP images

2023-02-20 Thread Jayathirth D V
On Wed, 15 Feb 2023 23:20:03 GMT, Sergey Bylokhov wrote: >> We have check in BMPImageReader, where we verify image data size using BMP >> file size and bitmap offset value. >> But we can't rely on this calculation when we have color palette. Also color >> palette is necessary in BMP when bits p

Integrated: 6753661: JFileChooser font not reset after Look & Feel change

2023-02-20 Thread Prasanta Sadhukhan
On Wed, 25 Jan 2023 06:45:53 GMT, Prasanta Sadhukhan wrote: > Issue is observed that after changing the Look & Feel from Metal to Nimbus > and back to Metal, the Nimbus font continues to be used by a JFileChooser. > This is because Synth `installDefaults `methods set the font, but its > inver

RFR: 8302838: jabswitch main() should avoid calling exit explicitly

2023-02-20 Thread Julian Waters
In jabswitch, main is defined as `void main()`, which requires an explicit exit call whenever an error occurs, and extra error checking code on our part. Visual C++ will automatically convert all instances of `void main()` to return 0 in all cases anyway, and there isn't anything gained from usi

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-20 Thread SWinxy
On Sun, 19 Feb 2023 09:35:53 GMT, SWinxy wrote: >> Many `installDefaults` methods set the font, foreground, and background on >> objects but their inverse methods `uninstallDefaults` do not remove them. >> I've added an inverse method to remove the colors and font to call for the >> `uninstall

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v4]

2023-02-20 Thread SWinxy
> Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the > `uninstallDefaults` methods that install defaults. > > `AquaBut