Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-23 Thread Phil Race
On Fri, 24 Feb 2023 01:37:44 GMT, SWinxy wrote: > > And if a default font prevents the FontUIResource from being installed, how > > does it get installed the in the first place ? > > Perhaps that first time the component has no peer and it really is null ? > > The font is null when it's created

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-23 Thread SWinxy
On Fri, 24 Feb 2023 00:07:20 GMT, Phil Race wrote: > And if a default font prevents the FontUIResource from being installed, how > does it get installed the in the first place ? Perhaps that first time the component has no peer and it really is null ? The font is null when it's created. Calling

Re: RFR: 8302513: remove sun.awt.util.IdentityLinkedList [v2]

2023-02-23 Thread Stuart Marks
> IdentityLinkedList is used in only one place, so it's fairly simple to > replace it with IdentityArrayList. Stuart Marks has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pu

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-23 Thread Phil Race
On Mon, 20 Feb 2023 08:08:22 GMT, SWinxy wrote: > Figured it out. When setting a Component's font to null, it inherits the font > from the component tree. Good to know but .. > Changing the fallback font type to a FontUIResource in the peers fixes this. Sorry, but I don't think we should do

Re: RFR: 8299333: Unify exceptions used by all variants of ICC_Profile.getInstance(null) [v2]

2023-02-23 Thread Phil Race
On Fri, 20 Jan 2023 20:20:32 GMT, Sergey Bylokhov wrote: >> I tried to clean up the documentation in the `java.awt.color` package and >> specify how the `null` parameters are handled here and there. But it looks >> like the `ICC_profile` class is too specific so I would like to discuss it >> s

Re: RFR: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distribution [v3]

2023-02-23 Thread Phil Race
On Tue, 7 Feb 2023 17:20:19 GMT, Alexander Scherbatiy wrote: >> [JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font >> coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE >> detection by checking SLES os name property in `/etc/os-release` file. >> >>

Re: RFR: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"

2023-02-23 Thread Phil Race
On Thu, 23 Feb 2023 20:14:11 GMT, Alexey Ivanov wrote: >>>For this reason, GC logs are enabled. If, for whatever reason, the call to >>>System.gc() is ignored, we'll see it in the test log. Then a specific GC >>>could be selected, for example, or another fix implemented. >> >> As of now this t

Withdrawn: 8302813: awt.image.incrementaldraw can use Boolean.parseBoolean() to parse the system property

2023-02-23 Thread SWinxy
On Sat, 18 Feb 2023 22:18:52 GMT, SWinxy wrote: > Please review this change which moves the parsing of the > `awt.image.incrementaldraw` property from the static initializer block into > the field itself by invoking `Boolean.parseBoolean()` on the system property > getter. > > Hopefully in th

Re: RFR: 8302813: awt.image.incrementaldraw can use Boolean.parseBoolean() to parse the system property

2023-02-23 Thread SWinxy
On Sat, 18 Feb 2023 22:18:52 GMT, SWinxy wrote: > Please review this change which moves the parsing of the > `awt.image.incrementaldraw` property from the static initializer block into > the field itself by invoking `Boolean.parseBoolean()` on the system property > getter. > > Hopefully in th

Re: RFR: 8302813: awt.image.incrementaldraw can use Boolean.parseBoolean() to parse the system property

2023-02-23 Thread Phil Race
On Sat, 18 Feb 2023 22:18:52 GMT, SWinxy wrote: > Please review this change which moves the parsing of the > `awt.image.incrementaldraw` property from the static initializer block into > the field itself by invoking `Boolean.parseBoolean()` on the system property > getter. > > Hopefully in th

Integrated: 8302173: Button border overlaps with button icon on macOS system LaF

2023-02-23 Thread Damon Nguyen
On Sat, 11 Feb 2023 00:23:05 GMT, Damon Nguyen wrote: > Previous fix to HTML in AquaButtonUI fixed spacing issue for HTML images in a > JButton in Aqua L&F. The new issue comes from having text inside the HTML as > the button's text. If an icon is used, this icon exceeds the bounds of the > bu

Re: RFR: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"

2023-02-23 Thread Alexey Ivanov
On Fri, 17 Feb 2023 00:26:30 GMT, Sergey Bylokhov wrote: >> For this reason, GC logs are enabled. If, for whatever reason, the call to >> `System.gc()` is ignored, we'll see it in the test log. Then a specific GC >> could be selected, for example, or another fix implemented. >> >> OOME does no

Re: RFR: JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color [v13]

2023-02-23 Thread SWinxy
On Sun, 5 Feb 2023 09:55:27 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded >> Color](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8293776) >> >> This is tracked in JBS as >> - [JDK-8293776 : Adds CSS 4 and

Withdrawn: 8298385: Some font classes rely on blind casting to implement Object.equals()

2023-02-23 Thread SWinxy
On Sun, 25 Sep 2022 04:01:26 GMT, SWinxy wrote: > Some also had two separate methods to check equality, one calling the other. > Objects.equals() is used in some places as a replacement for a local copy of > the function. In the end, the equals methods become quicker to understand > their chec

Re: RFR: 8298385: Some font classes rely on blind casting to implement Object.equals() [v2]

2023-02-23 Thread SWinxy
On Wed, 22 Feb 2023 20:49:43 GMT, SWinxy wrote: >> Some also had two separate methods to check equality, one calling the other. >> Objects.equals() is used in some places as a replacement for a local copy of >> the function. In the end, the equals methods become quicker to understand >> their

Re: RFR: 8273986: JEditorPane HTML Demo - Accessibility issues [v2]

2023-02-23 Thread Alexander Zuev
On Thu, 23 Feb 2023 03:22:19 GMT, Abhishek Kumar wrote: >> JAccessWalker was not able to show component tree correctly if we switch >> pages for HTML content. >> >> Observation: >> The issue observed is that the children are not reported correct for root >> element when switching of pages hap