Re: RFR: 8273986: JEditorPane HTML Demo - Accessibility issues [v2]

2023-02-27 Thread Abhishek Kumar
On Mon, 27 Feb 2023 20:57:35 GMT, Sergey Bylokhov wrote: >> The "AccessibleHTML" does internally register the listener on the editor to >> update the state/doc. >> >> But the `rootHTMLAccessibleContext` is not updated/created for the new root >> element on doc change and when `getAccessibleCh

Re: RFR: 8273986: JEditorPane HTML Demo - Accessibility issues [v3]

2023-02-27 Thread Abhishek Kumar
> JAccessWalker was not able to show component tree correctly if we switch > pages for HTML content. > > Observation: > The issue observed is that the children are not reported correct for root > element when switching of pages happened. The reason behind it is that the > `getAccessibleChildre

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 22:58:55 GMT, Phil Race wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 126: > >> 124: # about initializing a declared

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v3]

2023-02-27 Thread Jayathirth D V
> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of > gcc optimizations from -O1 level for libawt build. This improved our J2DBench > performance numbers in some options considerably. > > Recent changes done under https://bugs.openjdk.org/browse/JDK-8299337 causes > dif

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 23:02:15 GMT, Phil Race wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 130: > >> 128: BUILD_LIBAWT_debug_mem.c_CFLA

Re: RFR: 8273986: JEditorPane HTML Demo - Accessibility issues [v2]

2023-02-27 Thread Abhishek Kumar
On Mon, 27 Feb 2023 20:57:35 GMT, Sergey Bylokhov wrote: >> The "AccessibleHTML" does internally register the listener on the editor to >> update the state/doc. >> >> But the `rootHTMLAccessibleContext` is not updated/created for the new root >> element on doc change and when `getAccessibleCh

Re: RFR: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"

2023-02-27 Thread Tejesh R
On Thu, 16 Feb 2023 14:38:21 GMT, Alexey Ivanov wrote: > The test has become unstable recently, there were quite a few failures, on > Windows mostly. I was lucky enough to find a host where the test failed > consistently. > > I call `System.gc()` directly as suggested in comments to the bug. I

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v29]

2023-02-27 Thread Phil Race
On Mon, 27 Feb 2023 21:56:28 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add nam

Re: RFR: JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color [v13]

2023-02-27 Thread Phil Race
On Sun, 5 Feb 2023 09:55:27 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded >> Color](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8293776) >> >> This is tracked in JBS as >> - [JDK-8293776 : Adds CSS 4 and

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v29]

2023-02-27 Thread Phil Race
On Mon, 27 Feb 2023 21:56:28 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add nam

Re: RFR: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"

2023-02-27 Thread Phil Race
On Thu, 16 Feb 2023 14:38:21 GMT, Alexey Ivanov wrote: > The test has become unstable recently, there were quite a few failures, on > Windows mostly. I was lucky enough to find a host where the test failed > consistently. > > I call `System.gc()` directly as suggested in comments to the bug. I

Re: RFR: 8302558: Editable JComboBox 's popup blocks user from seeing characters in Acq look and feel [v2]

2023-02-27 Thread Damon Nguyen
On Mon, 27 Feb 2023 19:19:40 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Propagate exceptions. Move methods to EDT. > > src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxPopup.java li

Re: RFR: 8302558: Editable JComboBox 's popup blocks user from seeing characters in Acq look and feel [v2]

2023-02-27 Thread Damon Nguyen
On Mon, 27 Feb 2023 19:11:43 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Propagate exceptions. Move methods to EDT. > > test/jdk/javax/swing/JComboBox/EditableComboBoxPopupPos.java line 62: >

Re: RFR: 8302558: Editable JComboBox 's popup blocks user from seeing characters in Acq look and feel [v2]

2023-02-27 Thread Damon Nguyen
> The issue is in Aqua L&F when an editable JComboBox with a border is used. In > this case, when the comboBox is clicked for the drop-down menu to show, the > drop-down menu appears at the wrong coordinates (blocking the text of the > comboBox and making it unreadable). > > This seems to have

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Phil Race
On Mon, 27 Feb 2023 16:16:50 GMT, Jayathirth D V wrote: >> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of >> gcc optimizations from -O1 level for libawt build. This improved our >> J2DBench performance numbers in some options considerably. >> >> Recent changes done

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v29]

2023-02-27 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.openjdk

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v28]

2023-02-27 Thread ScientificWare
On Mon, 27 Feb 2023 20:09:11 GMT, Alexey Ivanov wrote: >> ScientificWare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Delete configure >> >> Delete configure from the pull request. > >> Delete configure from the pull request. >

Re: RFR: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"

2023-02-27 Thread Alexey Ivanov
On Mon, 27 Feb 2023 21:01:28 GMT, Sergey Bylokhov wrote: > > Can be but it's not ignored, it's respected. > > It could be ignored per the specification. Yet it's not. > > Nevertheless, I think generating OOME is redundant, it adds another level > > of complexity and makes the test slower. >

Re: RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Alexey Ivanov
On Mon, 27 Feb 2023 20:54:08 GMT, Sergey Bylokhov wrote: >> Added the section devoted to client UI test which use Robot API > > doc/testing.html line 621: > >> 619: the following apps are allowed to control your computer: >> 620: Java and Terminal. If the tests are run from >> 621: an IDE, the I

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v28]

2023-02-27 Thread Alexey Ivanov
On Sun, 12 Feb 2023 08:59:42 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add nam

Re: RFR: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"

2023-02-27 Thread Sergey Bylokhov
On Mon, 27 Feb 2023 15:42:49 GMT, Alexey Ivanov wrote: > Can be but it's not ignored, it's respected. It could be ignored per the specification. > Nevertheless, I think generating OOME is redundant, it adds another level of > complexity and makes the test slower. If it is redundant then let's

Re: RFR: 8273986: JEditorPane HTML Demo - Accessibility issues [v2]

2023-02-27 Thread Sergey Bylokhov
On Mon, 27 Feb 2023 04:51:50 GMT, Abhishek Kumar wrote: >> src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java line >> 690: >> >>> 688: if (accessibleContext == null >>> 689: || doc != theEditor.getDocument()) { >>> 690: AccessibleHTML a = new

Re: RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Sergey Bylokhov
On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov wrote: > Added the section devoted to client UI test which use Robot API doc/testing.html line 621: > 619: the following apps are allowed to control your computer: > 620: Java and Terminal. If the tests are run from > 621: an IDE, the IDE should b

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v6]

2023-02-27 Thread Phil Race
On Mon, 27 Feb 2023 16:32:02 GMT, Alexander Scherbatiy wrote: >> A printed content is truncated on macOS if the content paper size width >> larger than height with portrait orientation or width is less than height >> with landscape orientation. >> >> To reproduce the issue run the >> [CutOff

Re: RFR: 8303213: Avoid AtomicReference in TextComponentPrintable [v3]

2023-02-27 Thread Andrey Turbanov
> If CompareAndSwap is not used, then AtomicReference could be replaced with > volatile. It simplified code a bit. Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8303213: Avoid AtomicReference in TextComponentPrintable expan

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v28]

2023-02-27 Thread Alexey Ivanov
On Sun, 12 Feb 2023 08:59:42 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add nam

Re: RFR: 8302558: Editable JComboBox 's popup blocks user from seeing characters in Acq look and feel

2023-02-27 Thread Alexey Ivanov
On Fri, 24 Feb 2023 21:54:30 GMT, Damon Nguyen wrote: > The issue is in Aqua L&F when an editable JComboBox with a border is used. In > this case, when the comboBox is clicked for the drop-down menu to show, the > drop-down menu appears at the wrong coordinates (blocking the text of the > comb

Re: RFR: 8303213: Avoid AtomicReference in TextComponentPrintable [v2]

2023-02-27 Thread Alexey Ivanov
On Sun, 26 Feb 2023 14:55:27 GMT, Andrey Turbanov wrote: >> If CompareAndSwap is not used, then AtomicReference could be replaced with >> volatile. It simplified code a bit. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Alexey Ivanov
On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov wrote: > Added the section devoted to client UI test which use Robot API doc/testing.md line 616: > 614: system key shortcuts for various platforms are provided below. > 615: > 616: # MacOS Suggestion: # macOS Shall we spell _macOS_ wi

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v6]

2023-02-27 Thread Alexander Scherbatiy
On Mon, 27 Feb 2023 16:32:02 GMT, Alexander Scherbatiy wrote: >> A printed content is truncated on macOS if the content paper size width >> larger than height with portrait orientation or width is less than height >> with landscape orientation. >> >> To reproduce the issue run the >> [CutOff

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Erik Joelsson
On Mon, 27 Feb 2023 16:16:50 GMT, Jayathirth D V wrote: >> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of >> gcc optimizations from -O1 level for libawt build. This improved our >> J2DBench performance numbers in some options considerably. >> >> Recent changes done

Re: RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v3]

2023-02-27 Thread Alexey Ivanov
On Fri, 24 Feb 2023 04:58:12 GMT, Phil Race wrote: > > > And if a default font prevents the FontUIResource from being installed, > > > how does it get installed the in the first place ? > > > Perhaps that first time the component has no peer and it really is null ? > > > > > > The font is null

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Patrick Chen
lgtm Le lun. 27 févr. 2023 à 17:17, Jayathirth D V a écrit : > > Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level > of gcc optimizations from -O1 level for libawt build. This improved our > J2DBench performance numbers in some options considerably. > > > > Recent changes

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v6]

2023-02-27 Thread Alexander Scherbatiy
> A printed content is truncated on macOS if the content paper size width > larger than height with portrait orientation or width is less than height > with landscape orientation. > > To reproduce the issue run the > [CutOffImage](https://bugs.openjdk.org/secure/attachment/101145/CutOffImage.ja

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 15:14:22 GMT, Erik Joelsson wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 132: > >> 130: # that any cleanup of cod

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of > gcc optimizations from -O1 level for libawt build. This improved our J2DBench > performance numbers in some options considerably. > > Recent changes done under https://bugs.openjdk.org/browse/JDK-8299337 causes > dif

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v5]

2023-02-27 Thread Alexander Scherbatiy
> A printed content is truncated on macOS if the content paper size width > larger than height with portrait orientation or width is less than height > with landscape orientation. > > To reproduce the issue run the > [CutOffImage](https://bugs.openjdk.org/secure/attachment/101145/CutOffImage.ja

RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Dmitry Markov
Added the section devoted to client UI test which use Robot API - Commit messages: - 8303130: Document required Accessibility permissions on macOS Changes: https://git.openjdk.org/jdk/pull/12772/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12772&range=00 Issue: https://

Re: RFR: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"

2023-02-27 Thread Alexey Ivanov
On Sun, 26 Feb 2023 05:21:59 GMT, Sergey Bylokhov wrote: > > Yes, I saw this method, and [it periodically calls > > System.gc()](https://github.com/openjdk/jdk/blob/b4ea80731c6c0a0328a9801590ba5b081f08c3bd/test/jdk/javax/swing/regtesthelpers/Util.java#L102-L103). > > It generates OOM to make su

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64

2023-02-27 Thread Erik Joelsson
On Mon, 27 Feb 2023 11:49:27 GMT, Jayathirth D V wrote: > Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of > gcc optimizations from -O1 level for libawt build. This improved our J2DBench > performance numbers in some options considerably. > > Recent changes done under

RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64

2023-02-27 Thread Jayathirth D V
Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of gcc optimizations from -O1 level for libawt build. This improved our J2DBench performance numbers in some options considerably. Recent changes done under https://bugs.openjdk.org/browse/JDK-8299337 causes difference in g

Re[3]: Stage Manager Problems

2023-02-27 Thread Jeremy Wood
FWIW: I wrapped this exploration up by submitting two bug reports: 9074851, 9074856 . Regards, - Jeremy -- Original Message -- From "Jeremy Wood" To "Philip Race" ; "Harshitha Onkar" Cc "client-libs-dev@openjdk.org" Date 2/18/2023 5:22:25 AM Subject Re[2]: Stage Manager Problems

Integrated: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished

2023-02-27 Thread Prasanta Sadhukhan
On Wed, 11 Jan 2023 11:01:18 GMT, Prasanta Sadhukhan wrote: > SwingWorker done() method [spec > ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452) > says "Executed on the Event Dispatch Thread after the doInBackground method > is fin