Re: RFR: JDK-8301998: Update HarfBuzz to 7.0.1 [v3]

2023-03-06 Thread Harshitha Onkar
On Tue, 7 Mar 2023 00:36:18 GMT, Harshitha Onkar wrote: >> HarfBuzz library updated from v4.4.1 to v7.0.1 >> >> - harfbuzz.md file updated >> - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid >> build issues on linux and macos targets. >> - GPOS.hh has been moved

Re: RFR: JDK-8301998: Update HarfBuzz to 7.0.1 [v3]

2023-03-06 Thread Harshitha Onkar
> HarfBuzz library updated from v4.4.1 to v7.0.1 > > - harfbuzz.md file updated > - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid > build issues on linux and macos targets. > - GPOS.hh has been moved from Layout to Layout/GPOS to match upstream changes. Harshitha

Re: RFR: 7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color [v6]

2023-03-06 Thread Damon Nguyen
On Thu, 16 Feb 2023 05:03:32 GMT, Prasanta Sadhukhan wrote: >> Damon Nguyen has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Remove extra bufferedImage >> - Fix crlf >> - Add automated test. Cycle thru all LAF >> - Add testing for

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Roger Riggs
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Lance Andersen
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Jonathan Gibbons
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Jonathan Gibbons
On Fri, 3 Mar 2023 11:31:04 GMT, Alexey Ivanov wrote: >> Yes, iff means if-and-only-if and is used for extra precision in formal >> logic, mathematics. As @pavelrappo points out it's a relatively common >> occurrence in the OpenJDK sources, though perhaps not in the public >> javadocs.

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Pavel Rappo
> Please review this superficial documentation cleanup that was triggered by > unrelated analysis of doc comments in JDK API. > > The only effect that this multi-area PR has on the JDK API Documentation > (i.e. the observable effect on the generated HTML pages) can be summarized as > follows:

Re: RFR: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected" [v2]

2023-03-06 Thread Alexey Ivanov
On Mon, 6 Mar 2023 17:24:13 GMT, Alexey Ivanov wrote: >> The test has become unstable recently, there were quite a few failures, on >> Windows mostly. I was lucky enough to find a host where the test failed >> consistently. >> >> I call `System.gc()` directly as suggested in comments to the

Re: RFR: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected" [v2]

2023-03-06 Thread Alexey Ivanov
> The test has become unstable recently, there were quite a few failures, on > Windows mostly. I was lucky enough to find a host where the test failed > consistently. > > I call `System.gc()` directly as suggested in comments to the bug. I used > `PhantomReference` instead of `WeakReference`.

Integrated: 8297454: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to show opaque button"

2023-03-06 Thread Prasanta Sadhukhan
On Wed, 25 Jan 2023 06:41:19 GMT, Prasanta Sadhukhan wrote: > Test intermittently failed in CI macos system owing to robot screencapture > failing to compare the images. > Seems like from artifacts, that composite image created by robot contains > mouse cursor, which when compared are not

Re: RFR: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX

2023-03-06 Thread Prasanta Sadhukhan
On Fri, 3 Mar 2023 08:07:12 GMT, Prasanta Sadhukhan wrote: > Refactor-ed Swing interop was calling > `JLightweightFrame.notifyDisplayChanged()` with [wrong scale >

Re: RFR: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX

2023-03-06 Thread Ajit Ghaisas
On Mon, 6 Mar 2023 09:21:41 GMT, Prasanta Sadhukhan wrote: > > The fix looks fine. > > I think, an automated JavaFX system test can be developed to validate this > > fix. You will need to do it as a separate JBS issue since the code > > repositories are different. > > I am not sure if an

Re: RFR: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX

2023-03-06 Thread Prasanta Sadhukhan
On Mon, 6 Mar 2023 08:50:31 GMT, Ajit Ghaisas wrote: > The fix looks fine. > > I think, an automated JavaFX system test can be developed to validate this > fix. You will need to do it as a separate JBS issue since the code > repositories are different. I am not sure if an automated test is

Re: RFR: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX

2023-03-06 Thread Ajit Ghaisas
On Fri, 3 Mar 2023 08:07:12 GMT, Prasanta Sadhukhan wrote: > Refactor-ed Swing interop was calling > `JLightweightFrame.notifyDisplayChanged()` with [wrong scale >