> I'm confident about the new test case for this ticket, but the resolution is
> more invasive than I'd like. (It works, though.)
>
> In short:
> This introduces a new RenderingHint (in SunHints) to bypass the call in
> Window to `gg2d.fillRect(0, 0, getWidth(), getHeight());`
>
> I left more d
On Mon, 20 Mar 2023 23:52:11 GMT, Chen Liang wrote:
>> PR for Sequenced Collections implementation.
>
> Just curious, does sequenced collection specify if add simulates addLast if
> addition supports custom ordering? I wish to have efficient reversible batch
> addition operations available, lik
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
(Heh, it looks like a whole bunch of old PR comments from when it was in draft
state just got replayed to the mailing lists.)
-
PR Comment: https://git.openjdk.org/jdk/pull/7387#iss
On Fri, 17 Mar 2023 18:23:33 GMT, Damon Nguyen wrote:
>> I guess now in JDK with your testcase, popup button are shown opposite to
>> what native components shows ie editable combobox shows non-editable pop-up
>> button and non-editable combobox shows editable pull-down button
>>
>>
>>  is now Targeted to JDK 21. Hooray! It
thus seems as good a time as any to mark this PR as ready for review. Currently
I'm focusing on getting the specific
On Fri, 17 Mar 2023 07:30:12 GMT, ExE Boss wrote:
>> PR for Sequenced Collections implementation.
>
> src/java.base/share/classes/java/util/SequencedMap.java line 343:
>
>> 341: return new SeqEntrySet();
>> 342: }
>> 343: }
>
> Missing trailing newline:
> Suggestion:
>
> }
will fi
On Wed, 5 Oct 2022 15:15:05 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/SequencedCollection.java line 93:
>>
>>> 91: * underlying collection. Changes to the underlying collection
>>> might or might not be visible
>>> 92: * in this reversed view, depending upon th
On Tue, 4 Oct 2022 14:43:44 GMT, Viktor Klang wrote:
>> PR for Sequenced Collections implementation.
>
> src/java.base/share/classes/java/util/SequencedCollection.java line 93:
>
>> 91: * underlying collection. Changes to the underlying collection might
>> or might not be visible
>> 92:
On Sun, 28 Aug 2022 05:45:54 GMT, Grzegorz Piwowarek wrote:
>> PR for Sequenced Collections implementation.
>
> src/java.base/share/classes/java/util/SequencedCollection.java line 84:
>
>> 82: * the iterator() method, calls next() on it and returns the result.
>> 83: */
>> 84: defa
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
src/java.base/share/classes/java/util/SequencedCollection.java line 84:
> 82: * the iterator() method, calls next() on it and returns the result.
> 83: */
> 84: default E getFirst()
On Wed, 13 Apr 2022 19:08:58 GMT, Stuart Marks wrote:
>> Won’t `super.keySet()` resolve to a bridge method in that case?
>
> Oh yes, in this case it might resolve to a bridge method, and it might
> actually work. In this case. However, the compatibility matrix for covariant
> overrides and brid
On Wed, 13 Apr 2022 11:53:52 GMT, ExE Boss wrote:
>> Yes. Previously compiled binaries will also throw `NoSuchMethodError` if
>> they call `super.keySet()`. Clearly these are incompatibilities; the
>> question is whether they are severe enough to warrant pursuing a different
>> approach. If yo
On Tue, 12 Apr 2022 23:25:14 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/util/LinkedHashMap.java line 604:
>>
>>> 602: * @return a set view of the keys contained in this map
>>> 603: */
>>> 604: public SequencedSet keySet() {
>>
>> Changing the return type means t
On Thu, 3 Nov 2022 07:41:05 GMT, ExE Boss wrote:
>> Yeah, the coupling here is rather distasteful. (Otherwise known as a quick
>> and dirty hack.) Unfortunately the coupling between HashMap and
>> LinkedHashMap is pretty special-purposed for exactly the intended usage
>> modes (insertion-order
On Tue, 12 Apr 2022 19:55:13 GMT, Eamonn McManus wrote:
>> PR for Sequenced Collections implementation.
>
> src/java.base/share/classes/java/util/LinkedHashMap.java line 604:
>
>> 602: * @return a set view of the keys contained in this map
>> 603: */
>> 604: public SequencedSet key
On Thu, 3 Nov 2022 01:56:05 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/util/LinkedHashMap.java line 384:
>>
>>> 382: return this.put(k, v);
>>> 383: } finally {
>>> 384: putMode = PUT_NORM;
>>
>> @stuart-marks Would it be an alternative to have
On Wed, 5 Oct 2022 13:30:08 GMT, Viktor Klang wrote:
>> PR for Sequenced Collections implementation.
>
> src/java.base/share/classes/java/util/LinkedHashMap.java line 384:
>
>> 382: return this.put(k, v);
>> 383: } finally {
>> 384: putMode = PUT_NORM;
>
> @stuar
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
src/java.base/share/classes/java/util/LinkedHashMap.java line 384:
> 382: return this.put(k, v);
> 383: } finally {
> 384: putMode = PUT_NORM;
@stuart-marks Would
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
src/java.base/share/classes/java/util/Collections.java line 376:
> 374: * reversed-ordered view of a list without mutating it, use the
> 375: * {@link List#reversed List::reversed} meth
On Tue, 8 Nov 2022 20:36:40 GMT, Stuart Marks wrote:
> @sadayapalam
>
> > Please include the following fix for the langtools test "failures":
>
> OK, applying these patches lets the tests pass. I can include them in this PR.
>
> The patch in TestJavacTaskScanner.java adjusts the expected numbe
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
Note that `SortedMap::firstKey` and `SortedMap::lastKey` can now both have a
default implementation that delegates to `SequencedMap::firstEntry` and
`SequencedMap::lastEntry` respectively.
src/
On Tue, 8 Nov 2022 06:15:48 GMT, Srikanth Adayapalam
wrote:
>> PR for Sequenced Collections implementation.
>
> Please include the following fix for the langtools test "failures":
>
>
> diff --git a/test/langtools/tools/javac/api/TestJavacTaskScanner.java
> b/test/langtools/tools/javac/api/T
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
Please include the following fix for the langtools test "failures":
diff --git a/test/langtools/tools/javac/api/TestJavacTaskScanner.java
b/test/langtools/tools/javac/api/TestJavacTaskScanner.
On Sat, 5 Nov 2022 11:17:04 GMT, ExE Boss wrote:
>> @liach
>>
>>> Is there a particular reason we define poll (null on empty) in SequencedMap
>>> but remove (NSEE on empty) in SequencedCollection?
>>>
>>> I understand that SequencedCollection doesn't want to be null-ambiguous,
>>> and map en
On Sat, 5 Nov 2022 05:44:42 GMT, Stuart Marks wrote:
>> Is there a particular reason we define poll (null on empty) in SequencedMap
>> but remove (NSEE on empty) in SequencedCollection?
>>
>> I understand that SequencedCollection doesn't want to be null-ambiguous, and
>> map entries are non-nu
On Wed, 21 Sep 2022 04:01:13 GMT, Chen Liang wrote:
>> PR for Sequenced Collections implementation.
>
> Since we added reversal to deque, can we add notes to a few Collections APIs
> like `Collections::asLifoQueue` about this newer alternative? Also on using
> `reverse` on the list view than ac
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
Since we added reversal to deque, can we add notes to a few Collections APIs
like `Collections::asLifoQueue` about this newer alternative? Also on using
`reverse` on the list view than actually
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
I'm not convinced it's binary compatible. :-) Perhaps this particular case is,
but there are a bunch of other cases (additional subclasses, etc.) that need to
be considered.
Thanks for the Sour
On Tue, 8 Feb 2022 17:23:38 GMT, Stuart Marks wrote:
> PR for Sequenced Collections implementation.
Yes, I think this `LinkedHashMap.keySet()` change is binary compatible but
source incompatible. Surely binary incompatibility would have been enough to
rule it out immediately. For the source co
PR for Sequenced Collections implementation.
-
Commit messages:
- Specification cleanups.
- Update spec of CopyOnWriteArrayList::reversed.
- Move AbstractViewCollection to AbstractMap.ViewCollection to avoid exposing
it publicly.
- Merge branch 'master' into JDK-8266571-Sequenced
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan
wrote:
> It seems Synth has two cases of updateStyle() where its argument is not
> passed to the getContext() call. It seems to be an oversight as in other
> Synth classes, the component argument passed to updateStyle is being passed
> to ge
On Tue, 14 Mar 2023 07:28:21 GMT, Nikita Gubarkov wrote:
> Cool, then I wouldn't have to implement lookup tables myself :)
It is now integrated so you can sync master into your branch and take it for a
spin !
-
PR Comment: https://git.openjdk.org/jdk/pull/4798#issuecomment-1476938
> On Mar 20, 2023, at 2:50 PM, Sergey Bylokhov wrote:
>
> On 3/20/23 12:33, Michael Hall wrote:
>>/*
>> * We cannot use dispatch_sync here, because it blocks the main
>> dispatch queue.
>> * Using the main NSRunLoop allows the dispatch queue to run
>> pr
On 3/20/23 12:33, Michael Hall wrote:
/*
* We cannot use dispatch_sync here, because it blocks the main
dispatch queue.
* Using the main NSRunLoop allows the dispatch queue to run
properly once
* SWT (or whatever toolkit this is needed for)
On Fri, 17 Mar 2023 09:08:56 GMT, Matthias Baesken wrote:
> The ToFromCIEXYZRoundTrip test times out on slow platforms , especially when
> (fast)debug binaries are used.
> This was observed on Alpine Linux and AIX in our automated tests. Setting an
> increased timeout for the test helps to red
> On Mar 20, 2023, at 2:12 PM, Sergey Bylokhov wrote:
>
> On 3/16/23 12:15, Alan Snyder wrote:
>> The test for already being on the main thread should be performed in one
>> place, in this method:
>>> On Mar 16, 2023, at 6:07 AM, Michael Hall wrote:
>>>
>>>[ThreadUtilities performOnMain
On Fri, 17 Mar 2023 06:19:02 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java
>> line 198:
>>
>>> 196:
>>> 197: public int getSize() {
>>> 198: return fileCache.size();
>>
>> The fileCache is a Vector, and the methods of that o
On 3/16/23 12:15, Alan Snyder wrote:
The test for already being on the main thread should be performed in one place,
in this method:
On Mar 16, 2023, at 6:07 AM, Michael Hall wrote:
[ThreadUtilities performOnMainThreadWaiting:YES block:^(){
That check is already there:
https://github.co
On Fri, 17 Mar 2023 09:08:56 GMT, Matthias Baesken wrote:
> The ToFromCIEXYZRoundTrip test times out on slow platforms , especially when
> (fast)debug binaries are used.
> This was observed on Alpine Linux and AIX in our automated tests. Setting an
> increased timeout for the test helps to red
On Fri, 17 Mar 2023 09:08:56 GMT, Matthias Baesken wrote:
> The ToFromCIEXYZRoundTrip test times out on slow platforms , especially when
> (fast)debug binaries are used.
> This was observed on Alpine Linux and AIX in our automated tests. Setting an
> increased timeout for the test helps to red
Mathias dewulf did it
Le lun. 20 mars 2023 à 16:33, Martin Doerr a écrit :
> On Fri, 17 Mar 2023 09:08:56 GMT, Matthias Baesken
> wrote:
>
> > The ToFromCIEXYZRoundTrip test times out on slow platforms , especially
> when (fast)debug binaries are used.
> > This was observed on Alpine Linux and
On Fri, 17 Mar 2023 09:08:56 GMT, Matthias Baesken wrote:
> The ToFromCIEXYZRoundTrip test times out on slow platforms , especially when
> (fast)debug binaries are used.
> This was observed on Alpine Linux and AIX in our automated tests. Setting an
> increased timeout for the test helps to red
On Mon, 20 Mar 2023 13:06:19 GMT, Eirik Bjorsnos wrote:
> Please review this PR which suggests to modernize the JVM arguments used to
> enable debugging in the netbeans project files for demos.
>
> The netbeans projects found in src/demo/share/nbproject currently use the
> following outdated
Please review this PR which suggests to modernize the JVM arguments used to
enable debugging in the netbeans project files for demos.
The netbeans projects found in src/demo/share/nbproject currently use the
following outdated combination of jvm arguments to set up debugging:
They shoul
> Please review this PR which suggests we remove the orhphaned `SwingApplet`
> netbeans project directory.
>
> The `SwingApplet` demo was removed in
> [JDK-8205119](https://bugs.openjdk.org/browse/JDK-8205119), but the netbeans
> projects files were left behind.
>
> Additionally, the following
On Mon, 20 Mar 2023 10:31:50 GMT, Eirik Bjorsnos wrote:
> Please review this PR which suggests we remove the orhphaned `SwingApplet`
> netbeans project directory.
>
> The `SwingApplet` demo was removed in
> [JDK-8205119](https://bugs.openjdk.org/browse/JDK-8205119), but the netbeans
> project
Please review this PR which suggests we remove the orhphaned `SwingApplet`
netbeans project directory.
The `SwingApplet` demo was removed in
[JDK-8205119](https://bugs.openjdk.org/browse/JDK-8205119), but the netbeans
projects files were left behind.
-
Commit messages:
- Since th
48 matches
Mail list logo
