Re: RFR: 7124527: [macosx] SwingSet2, label is not read by VoiceOver when focus is on textfield for Internalframe and Table demo.

2023-04-02 Thread Abhishek Kumar
On Fri, 31 Mar 2023 22:01:15 GMT, Sergey Bylokhov wrote: > Looks fine, please update the dates in the copyright block. Copyright year updated. - PR Comment: https://git.openjdk.org/jdk/pull/13268#issuecomment-1493774418

Re: RFR: 7124527: [macosx] SwingSet2, label is not read by VoiceOver when focus is on textfield for Internalframe and Table demo. [v2]

2023-04-02 Thread Abhishek Kumar
> In SwingSet2, few label components are not set for textfield component in > InternalFrame and Table demo and due to this VoiceOver doesn't announce the > label along with the textfield value. Added a fix for that and verified in > SwingSet2. > > Apart from that for Selection mode combobox and

Integrated: 8283404: [macos] a11y : Screen magnifier does not show JMenu name

2023-04-02 Thread Abhishek Kumar
On Fri, 31 Mar 2023 15:27:50 GMT, Abhishek Kumar wrote: > It seems that the accessibility role returned by the MenuAccessibility class > is not correct for top level menu. > > Added a condition check to return the accessibility role as > `NSAccessibilityMenuBarItemRole` in stead of `NSAccessib

Re: RFR: 8283404: [macos] a11y : Screen magnifier does not show JMenu name [v2]

2023-04-02 Thread M4ximumPizza
On Fri, 31 Mar 2023 17:08:19 GMT, Abhishek Kumar wrote: >> It seems that the accessibility role returned by the MenuAccessibility class >> is not correct for top level menu. >> >> Added a condition check to return the accessibility role as >> `NSAccessibilityMenuBarItemRole` in stead of `NSAcc

Re: RFR: 7124527: [macosx] SwingSet2, label is not read by VoiceOver when focus is on textfield for Internalframe and Table demo.

2023-04-02 Thread Artem Semenov
On Fri, 31 Mar 2023 11:54:40 GMT, Abhishek Kumar wrote: > In SwingSet2, few label components are not set for textfield component in > InternalFrame and Table demo and due to this VoiceOver doesn't announce the > label along with the textfield value. Added a fix for that and verified in > Swing

Re: RFR: 8304503: Modernize debugging jvm args in demo netbeans projects

2023-04-02 Thread Eirik Bjorsnos
On Mon, 20 Mar 2023 13:06:19 GMT, Eirik Bjorsnos wrote: > Please review this PR which suggests to modernize the JVM arguments used to > enable debugging in the netbeans project files for demos. > > The netbeans projects found in src/demo/share/nbproject currently use the > following outdated

Re: RFR: 8304295: harfbuzz build fails with GCC 7 after JDK-8301998 [v2]

2023-04-02 Thread Julian Waters
On Fri, 31 Mar 2023 21:27:08 GMT, Joshua Cao wrote: >> Builds successfully with GCC 7 >> >> >> gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-15) >> Copyright (C) 2017 Free Software Foundation, Inc. >> This is free software; see the source for copying conditions. There is NO >> warranty; not even for