Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v4]

2023-04-26 Thread Tejesh R
> Open source few AWT ScrollPane related tests. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments - Changes: - all: https://git.openjdk.org/jdk/pull/13621/files - new: https://git.openjdk.o

Re: RFR: 8306640: Open source several AWT TextArea related tests

2023-04-26 Thread Tejesh R
On Wed, 26 Apr 2023 17:34:25 GMT, Sergey Bylokhov wrote: >> Open source few AWT TextArea related tests. > > test/jdk/java/awt/TextArea/ReplaceRangeTest.java line 26: > >> 24: @test >> 25: @bug 5025532 >> 26: @requires (os.family == "windows") > > Is this test can pass on windows only or w

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v3]

2023-04-26 Thread Tejesh R
On Wed, 26 Apr 2023 17:49:11 GMT, Phil Race wrote: >> Yeah, I guess 5000 might not be required 1000 might be fine, but either >> delay or sleep is required I feel. > > It seems just wrong to me. This sleep should be on the main thread after > returning from invokeAndWait Ok, moved it outside i

Re: RFR: 8306681: Open source more AWT DnD related tests [v2]

2023-04-26 Thread Sergey Bylokhov
On Wed, 26 Apr 2023 22:48:24 GMT, Damon Nguyen wrote: >> This PR open sources more AWT DnD related tests > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Add endline Marked as reviewed by serb (Reviewer). - PR

RFR: 8306949: Resolve miscellaneous multiple symbol definition issues when statically linking JDK/VM natives with standard launcher

2023-04-26 Thread Jiangli Zhou
Resolve misc symbol issues observed when statically linking JDK/VM natives with the standard Java launcher executable. Use the same approaches adopted by earlier fixes for static linking related symbol problems (e.g. JDK-8306033): - Change findFunction() to be a static function in src/java.smar

Re: RFR: 8071693: Introspector ignores default interface methods [v8]

2023-04-26 Thread Archie Cobbs
On Tue, 25 Apr 2023 18:52:16 GMT, Archie Cobbs wrote: >> The `Introspector` class was never updated to include `default` methods >> inherited from interfaces. >> >> This patch attempts to fix that omission. > > Archie Cobbs has updated the pull request with a new target base due to a > merge o

Re: RFR: 8071693: Introspector ignores default interface methods [v8]

2023-04-26 Thread Joe Darcy
On Tue, 25 Apr 2023 18:52:16 GMT, Archie Cobbs wrote: >> The `Introspector` class was never updated to include `default` methods >> inherited from interfaces. >> >> This patch attempts to fix that omission. > > Archie Cobbs has updated the pull request with a new target base due to a > merge o

Integrated: 8071693: Introspector ignores default interface methods

2023-04-26 Thread Archie Cobbs
On Wed, 19 Apr 2023 21:29:05 GMT, Archie Cobbs wrote: > The `Introspector` class was never updated to include `default` methods > inherited from interfaces. > > This patch attempts to fix that omission. This pull request has now been integrated. Changeset: 1e4eafb4 Author:Archie Cobbs Co

Re: RFR: 8306681: Open source more AWT DnD related tests [v2]

2023-04-26 Thread Damon Nguyen
On Wed, 26 Apr 2023 22:11:54 GMT, Sergey Bylokhov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add endline > > test/jdk/java/awt/dnd/ZeroFormatTransferableTest.java line 82: > >> 80: throw new Unsupport

Re: RFR: 8306681: Open source more AWT DnD related tests [v2]

2023-04-26 Thread Damon Nguyen
> This PR open sources more AWT DnD related tests Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Add endline - Changes: - all: https://git.openjdk.org/jdk/pull/13674/files - new: https://git.openjdk.org/jdk/pull/136

Re: RFR: 8306681: Open source more AWT DnD related tests

2023-04-26 Thread Sergey Bylokhov
On Wed, 26 Apr 2023 18:00:14 GMT, Damon Nguyen wrote: > This PR open sources more AWT DnD related tests test/jdk/java/awt/dnd/ZeroFormatTransferableTest.java line 82: > 80: throw new UnsupportedFlavorException(df); > 81: } > 82: } There is no new line at the end of each file?

Re: RFR: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions [v5]

2023-04-26 Thread Sergey Bylokhov
On Wed, 26 Apr 2023 10:29:00 GMT, Maxim Kartashev wrote: >> Getting bounds of a `GraphicsDevice` and insets of a screen are fairly >> frequent operations. When working over the network (remote X session), those >> can take several *seconds* to complete, introducing repeated freezes even >> wh

Re: RFR: 8306850: Open source AWT Model related tests

2023-04-26 Thread Sergey Bylokhov
On Wed, 26 Apr 2023 19:48:00 GMT, Abhishek Kumar wrote: > This PR is to open source Modal related AWT tests. Marked as reviewed by serb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13676#pullrequestreview-1402893878

RFR: 8306850: Open source AWT Model related tests

2023-04-26 Thread Abhishek Kumar
This PR is to open source Modal related AWT tests. - Commit messages: - Open source Modal AWT tests Changes: https://git.openjdk.org/jdk/pull/13676/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13676&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306850 Stats: 10

Re: RFR: 8306681: Open source more AWT DnD related tests

2023-04-26 Thread Phil Race
On Wed, 26 Apr 2023 18:00:14 GMT, Damon Nguyen wrote: > This PR open sources more AWT DnD related tests Marked as reviewed by prr (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13674#pullrequestreview-1402709469

Re: RFR: JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color [v13]

2023-04-26 Thread ScientificWare
On Sun, 5 Feb 2023 09:55:27 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded >> Color](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8293776) >> >> This is tracked in JBS as >> - [JDK-8293776 : Adds CSS 4 and

Integrated: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests

2023-04-26 Thread Abhishek Kumar
On Tue, 25 Apr 2023 07:07:41 GMT, Abhishek Kumar wrote: > This PR is to open source Keyboard Focus Manager, Light Weight Component and > few other AWT tests. This pull request has now been integrated. Changeset: 732179ca Author:Abhishek Kumar URL: https://git.openjdk.org/jdk/commit

RFR: 8306681: Open source more AWT DnD related tests

2023-04-26 Thread Damon Nguyen
This PR open sources more AWT DnD related tests - Commit messages: - Initial test move Changes: https://git.openjdk.org/jdk/pull/13674/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13674&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306681 Stats: 545 lines in 7

Re: RFR: 8306466: Open source more AWT Drag & Drop related tests [v2]

2023-04-26 Thread Phil Race
On Wed, 26 Apr 2023 17:37:34 GMT, Sergey Bylokhov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove extra folders > > test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 114: > >> 112: } >> 113:

Re: RFR: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests [v2]

2023-04-26 Thread Sergey Bylokhov
On Wed, 26 Apr 2023 06:07:00 GMT, Abhishek Kumar wrote: >> test/jdk/java/awt/LightweightComponent/LWClobberDragEvent.java line 88: >> >>> 86: frame.add(lc); >>> 87: frame.pack(); >>> 88: frame.setLocationRelativeTo(null); >> >> I amnot sure but pack and setLo

Re: RFR: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests [v3]

2023-04-26 Thread Sergey Bylokhov
On Wed, 26 Apr 2023 06:27:53 GMT, Abhishek Kumar wrote: >> This PR is to open source Keyboard Focus Manager, Light Weight Component and >> few other AWT tests. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review comme

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v3]

2023-04-26 Thread Phil Race
On Wed, 26 Apr 2023 16:49:56 GMT, Tejesh R wrote: >> test/jdk/java/awt/ScrollPane/ComponentScrollTest.java line 80: >> >>> 78: Thread.sleep(5000); >>> 79: } catch (InterruptedException ie) { >>> 80: } >> >> This `sleep` blocks EDT. Is it inten

Re: RFR: 8306640: Open source several AWT TextArea related tests

2023-04-26 Thread Sergey Bylokhov
On Wed, 26 Apr 2023 14:23:27 GMT, Tejesh R wrote: > Open source few AWT TextArea related tests. test/jdk/java/awt/TextArea/ReplaceRangeTest.java line 26: > 24: @test > 25: @bug 5025532 > 26: @requires (os.family == "windows") Is this test can pass on windows only or we can run it on all

Re: RFR: 8306466: Open source more AWT Drag & Drop related tests [v2]

2023-04-26 Thread Sergey Bylokhov
On Tue, 25 Apr 2023 23:16:33 GMT, Damon Nguyen wrote: >> This PR open sources a few more AWT DnD related tests > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Remove extra folders test/jdk/java/awt/dnd/RejectDragDropAction

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v2]

2023-04-26 Thread Tejesh R
On Wed, 26 Apr 2023 14:22:52 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Updated based on Review Comments >> - Updated based on Review Comments > > test/jdk/java/awt/ScrollPane/ComponentScroll

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v3]

2023-04-26 Thread Tejesh R
On Wed, 26 Apr 2023 14:25:42 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated ScrollPaneWindowsTest.java > > test/jdk/java/awt/ScrollPane/ComponentScrollTest.java line 80: > >> 78:

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v2]

2023-04-26 Thread Alexey Ivanov
On Tue, 25 Apr 2023 15:43:18 GMT, Tejesh R wrote: >> Open source few AWT ScrollPane related tests. > > Tejesh R has updated the pull request incrementally with two additional > commits since the last revision: > > - Updated based on Review Comments > - Updated based on Review Comments test/j

RFR: 8306640: Open source several AWT TextArea related tests

2023-04-26 Thread Tejesh R
Open source few AWT TextArea related tests. - Commit messages: - Open sourced TextArea tests Changes: https://git.openjdk.org/jdk/pull/13670/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13670&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306640 Stats: 437 lines

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v3]

2023-04-26 Thread Alexey Ivanov
On Wed, 26 Apr 2023 14:40:53 GMT, Tejesh R wrote: >> Open source few AWT ScrollPane related tests. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Updated ScrollPaneWindowsTest.java test/jdk/java/awt/ScrollPane/ComponentScroll

Re: RFR: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests [v3]

2023-04-26 Thread Tejesh R
On Wed, 26 Apr 2023 06:27:53 GMT, Abhishek Kumar wrote: >> This PR is to open source Keyboard Focus Manager, Light Weight Component and >> few other AWT tests. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review comme

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v3]

2023-04-26 Thread Tejesh R
> Open source few AWT ScrollPane related tests. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated ScrollPaneWindowsTest.java - Changes: - all: https://git.openjdk.org/jdk/pull/13621/files - new: https://git.openjdk

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v3]

2023-04-26 Thread Tejesh R
On Tue, 25 Apr 2023 17:08:42 GMT, Phil Race wrote: >> The bug was raised specifically for Win2000, also states that it is not >> reproducible for Windows NT 4.0 and Windows 98. I don't think that this test >> is specific to Win2000, in JBS they mention about a feature being added from >> Win20

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v29]

2023-04-26 Thread ScientificWare
On Mon, 27 Feb 2023 21:56:28 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add nam

Re: RFR: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions [v5]

2023-04-26 Thread Maxim Kartashev
On Fri, 21 Apr 2023 20:17:42 GMT, Sergey Bylokhov wrote: > You do not need to move the code around, just cache it in the GC instead of > the hashmap, and then re-cache it by some notification. I implemented something along these lines, please, have a look. - PR Review Comment: htt

Re: RFR: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions [v5]

2023-04-26 Thread Maxim Kartashev
> Getting bounds of a `GraphicsDevice` and insets of a screen are fairly > frequent operations. When working over the network (remote X session), those > can take several *seconds* to complete, introducing repeated freezes even > when typing in an editor feels only slightly sluggish. > > On the