On Fri, 5 May 2023 17:59:25 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More Attrbutes added
>
> src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 2897:
>
>> 2895:
> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual()
> method which can fail due to missing implementation of equals method in CSS
> subclasses.
> In this issue, even when two CSS AttributeSet has same 42 font size string
> value, Object equality fails.
> Fixed by implementi
> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual()
> method which can fail due to missing implementation of equals method in CSS
> subclasses.
> In this issue, even when two CSS AttributeSet has same 42 font size string
> value, Object equality fails.
> Fixed by implementi
On Thu, 4 May 2023 12:42:14 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More Attrbutes added
>
> test/jdk/javax/swing/text/html/CSS/CSSAttributeEqualityBug.java line 119:
>
>> 117:
On Fri, 5 May 2023 17:50:54 GMT, Alexey Ivanov wrote:
>> yes this needs to be changed.
>> Also needs to be changed at line 2034.
>
> The following test still fails.
>
>
> private static void testFontFamilyCSS() {
> StyleSheet ss = new StyleSheet();
>
> AttributeSet a = ss.g
> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual()
> method which can fail due to missing implementation of equals method in CSS
> subclasses.
> In this issue, even when two CSS AttributeSet has same 42 font size string
> value, Object equality fails.
> Fixed by implementi
On Fri, 5 May 2023 12:27:04 GMT, Alexander Zvegintsev
wrote:
> On Linux systems, we rely on XGrabPointer (X11 API) to capture mouse input
> and dismiss popup menus on mouse clicks outside the popup menu.
> Unfortunately, on Linux systems using the
> [Wayland](https://wayland.freedesktop.org/)
On Thu, 4 May 2023 19:35:32 GMT, Rajat Mahajan wrote:
>> src/java.desktop/share/classes/sun/swing/CachedPainter.java line 318:
>>
>>> 316: public Image getResolutionVariant(double destWidth, double
>>> destHeight) {
>>> 317: int w = (int) Math.floor(destWidth + 0.5);
>>> 318
On Mon, 8 May 2023 18:41:45 GMT, Alexey Ivanov wrote:
>> What is GC ?
>
>> What is GC ?
>
> I guess Graphics Configuration.
>
>> Then that layout code will be broken if layout will be calculated on already
>> visible component, I guess it should take into account the GC where the
>> component
> Problem:
>
> Check boxes and radio buttons in Windows Look-and-Feel have rendering issues
> when window is moved from display with one scale to display with a different
> scale on a multi-monitor setup:
>
> - Scrawly ticks in checkboxes;
> - Wrong circle relations in selected radio buttons.
>
On Fri, 5 May 2023 17:41:26 GMT, Damon Nguyen wrote:
> Open source few Swing JMenu tests
This pull request has now been integrated.
Changeset: d9052b94
Author:Damon Nguyen
URL:
https://git.openjdk.org/jdk/commit/d9052b946682d1c0f2629455d73fe4e6b95b29db
Stats: 293 lines in 4 file
On Fri, 5 May 2023 20:43:41 GMT, Erik Joelsson wrote:
> Further I would like to suggest that libjvm.a gets put in the variant subdir
> under lib, just like libjvm.so does today (e.g. `lib/server/libjvm.a`). That
> way you can support building libjvm.a for all variants without worry. It will
>
> Adding some DnD tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fix space
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13756/files
- new: https://git.openjdk.org/jdk/pull/13756/files/c2451e28..7d514e47
On Sat, 6 May 2023 03:14:32 GMT, Alisen Chung wrote:
>> update freetype version to 2.13, all tests passed
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> readd spaces to comments
md file overall looks fine to me so far
sr
On Mon, 8 May 2023 08:57:37 GMT, Severin Gehwolf wrote:
> > All of that said, I think we can get away with a smaller subset of targets
> > and deliverables. AFAIK, graal needs the combined `graal-builder-image` as
> > input to their build anyway, so they should not have any dependency on what
On Mon, 8 May 2023 18:36:08 GMT, Alisen Chung wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add Util. Change helper path
>
> test/jdk/javax/swing/JMenu/bug5013739.java line 85:
>
>> 83: robo.delay(10
> Open source few Swing JMenu tests
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Add null check
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13839/files
- new: https://git.openjdk.org/jdk/pull/13839/files/1d
On Mon, 8 May 2023 18:22:31 GMT, Sergey Bylokhov wrote:
> > It may be useful to be able to run Java on previous versions though, yet
> > it's not a priority.
>
> Then probably it is better to add a fallback since that method was added to
> the win 10 after GA, and it does not exist in the earl
On Fri, 5 May 2023 14:58:15 GMT, Alexander Zvegintsev
wrote:
> It seems that the current robot API is not suitable for this.
Can we just reset the token when we create a new instance of Robot?
-
PR Comment: https://git.openjdk.org/jdk/pull/13803#issuecomment-1538859204
On Mon, 8 May 2023 18:30:36 GMT, Rajat Mahajan wrote:
> What is GC ?
I guess Graphics Configuration.
> Then that layout code will be broken if layout will be calculated on already
> visible component, I guess it should take into account the GC where the
> component is located.
It works fine
On Sat, 6 May 2023 00:50:33 GMT, Damon Nguyen wrote:
>> Open source few Swing JMenu tests
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add Util. Change helper path
test/jdk/javax/swing/JMenu/bug5013739.java line 85:
>
On Fri, 5 May 2023 18:35:05 GMT, Alisen Chung wrote:
>> moving tests to open
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/java/awt/dnd/MissedDragEnterTest.java
>
> Co-authored-by: Andrey Turbanov
t
On Tue, 2 May 2023 22:09:18 GMT, Alisen Chung wrote:
> added DnD tests
test/jdk/java/awt/dnd/MouseExitGestureTriggerTest.java line 107:
> 105: Thread.sleep(RECOGNITION_TIMEOUT);
> 106:
> 107: if (recognized) {
This field is set on EDT, and used here on main w/o synchronization
On Mon, 8 May 2023 18:26:37 GMT, Sergey Bylokhov wrote:
>>> Why does everything else use defaultDPI, is it possible that some values
>>> depend on the DPI?
>>
>> Because Swing's user space coordinates use the default 96dpi. Some values do
>> depend on the DPI, yet layout code still uses the de
On Tue, 2 May 2023 15:02:37 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 280:
>>
>>> 278: readLock.lock();
>>> 279: try {
>>> 280: return getPoint(getTheme(widget, defaultDPI), part, state,
>>> property);
>>
>>
On Tue, 2 May 2023 14:59:11 GMT, Alexey Ivanov wrote:
> It may be useful to be able to run Java on previous versions though, yet it's
> not a priority.
Then probably it is better to add a fallback since that method was added to the
win 10 after GA, and it does not exist in the early version.
> Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13828/file
On Tue, 2 May 2023 20:46:00 GMT, Damon Nguyen wrote:
> When converting this test to be applicable to be open sourced, changes were
> made. I reverted some of these changes to get the test stable again. Now it
> passes when run on various OS's 100x.
This pull request has now been integrated.
C
> Please review this patch that removes a number of unused exports from
> java.desktop native libraries.
>
> In most cases I removed JNIEXPORT from methods and variables that are only
> used within a single shared library. Other than that:
> - removed `getSunFontIDs` that was reportedly used by
On Sat, 6 May 2023 00:31:37 GMT, Harshitha Onkar wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/javax/swing/JMenuItem/bug4839464.java line 220:
>
>> 218: // Check mnem
On Mon, 8 May 2023 09:33:40 GMT, Abhishek Kumar wrote:
>> This PR is to open source JMenuItem related swing tests.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment update
Marked as reviewed by dnguyen (Comm
On Fri, 21 Apr 2023 12:58:58 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> Noticed this test case not verifying all the cases which is intended.
> Modified it for improving the coverage for 3 type of popups (menu, context
> menu and combobox).
>
> Evaluating conditions:
> 1. Not e
On Mon, 8 May 2023 10:29:56 GMT, Matthias Baesken wrote:
> After the harfbuzz 7.2 update we run into
>
> /linuxmuslx86_64/jdk-dev/src/java.desktop/share/native/libharfbuzz/OT/glyf/Glyph.hh:281:8:
> error: offset '4' outside bounds of constant string [-Werror=array-bounds]
> 281 | bool get_poi
On Mon, 8 May 2023 10:29:56 GMT, Matthias Baesken wrote:
> After the harfbuzz 7.2 update we run into
>
> /linuxmuslx86_64/jdk-dev/src/java.desktop/share/native/libharfbuzz/OT/glyf/Glyph.hh:281:8:
> error: offset '4' outside bounds of constant string [-Werror=array-bounds]
> 281 | bool get_poi
On Sat, 6 May 2023 01:14:50 GMT, Jie Fu wrote:
> The fix disables expansion-to-defined warning for gcc.
> Thanks.
This pull request has now been integrated.
Changeset: 64c09628
Author:Jie Fu
URL:
https://git.openjdk.org/jdk/commit/64c09628664fd19c281723f15bf677c52e360acd
Stats:
On Mon, 8 May 2023 10:29:56 GMT, Matthias Baesken wrote:
> After the harfbuzz 7.2 update we run into
>
> /linuxmuslx86_64/jdk-dev/src/java.desktop/share/native/libharfbuzz/OT/glyf/Glyph.hh:281:8:
> error: offset '4' outside bounds of constant string [-Werror=array-bounds]
> 281 | bool get_poi
On Mon, 8 May 2023 13:29:26 GMT, Erik Joelsson wrote:
>> Jie Fu has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Add comment
>
> Marked as reviewed by erikj (Reviewer).
Thanks @erikj79 for the review.
-
PR Comment: https://
On Sat, 6 May 2023 01:41:11 GMT, Jie Fu wrote:
>> The fix disables expansion-to-defined warning for gcc.
>> Thanks.
>
> Jie Fu has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Add comment
Marked as reviewed by erikj (Reviewer).
---
On Mon, 8 May 2023 10:29:56 GMT, Matthias Baesken wrote:
> After the harfbuzz 7.2 update we run into
>
> /linuxmuslx86_64/jdk-dev/src/java.desktop/share/native/libharfbuzz/OT/glyf/Glyph.hh:281:8:
> error: offset '4' outside bounds of constant string [-Werror=array-bounds]
> 281 | bool get_poi
On Mon, 8 May 2023 10:45:00 GMT, Matthias Baesken wrote:
> The AIX build is broken after
> [JDK-8307301](https://bugs.openjdk.org/browse/JDK-8307301) which updated
> harfbuzz to 7.2 .
> This was expected because an older AIX workaround was removed.
> Bringing back the AIX workaround solves the
On Mon, 8 May 2023 10:45:00 GMT, Matthias Baesken wrote:
> The AIX build is broken after
> [JDK-8307301](https://bugs.openjdk.org/browse/JDK-8307301) which updated
> harfbuzz to 7.2 .
> This was expected because an older AIX workaround was removed.
> Bringing back the AIX workaround solves the
On Mon, 8 May 2023 10:45:00 GMT, Matthias Baesken wrote:
> The AIX build is broken after
> [JDK-8307301](https://bugs.openjdk.org/browse/JDK-8307301) which updated
> harfbuzz to 7.2 .
> This was expected because an older AIX workaround was removed.
> Bringing back the AIX workaround solves the
On Mon, 8 May 2023 10:29:56 GMT, Matthias Baesken wrote:
> After the harfbuzz 7.2 update we run into
>
> /linuxmuslx86_64/jdk-dev/src/java.desktop/share/native/libharfbuzz/OT/glyf/Glyph.hh:281:8:
> error: offset '4' outside bounds of constant string [-Werror=array-bounds]
> 281 | bool get_poi
The AIX build is broken after
[JDK-8307301](https://bugs.openjdk.org/browse/JDK-8307301) which updated
harfbuzz to 7.2 .
This was expected because an older AIX workaround was removed.
Bringing back the AIX workaround solves the issue.
-
Commit messages:
- JDK-8307603
Changes: http
After the harfbuzz 7.2 update we run into
/linuxmuslx86_64/jdk-dev/src/java.desktop/share/native/libharfbuzz/OT/glyf/Glyph.hh:281:8:
error: offset '4' outside bounds of constant string [-Werror=array-bounds]
281 | bool get_points (hb_font_t *font, const accelerator_t &glyf_accelerator,
|
On Sat, 6 May 2023 00:17:01 GMT, Damon Nguyen wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/javax/swing/JMenuItem/bug4839464.java line 29:
>
>> 27: @summary Shortcoming i
On Fri, 5 May 2023 18:03:12 GMT, Phil Race wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/javax/swing/JMenuItem/bug4304129.java line 47:
>
>> 45: public static void main(S
> This PR is to open source JMenuItem related swing tests.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Review comment update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13822/files
- new: https://git.ope
On Fri, 5 May 2023 20:43:41 GMT, Erik Joelsson wrote:
> All of that said, I think we can get away with a smaller subset of targets
> and deliverables. AFAIK, graal needs the combined `graal-builder-image` as
> input to their build anyway, so they should not have any dependency on what
> the ta
On Fri, 5 May 2023 16:52:22 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle c
50 matches
Mail list logo
